Minor PR

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Minor PR

Atri Sharma-2
Hi,

Please help review this PR:

https://github.com/apache/ignite/pull/8845

Regards,

Atri
Reply | Threaded
Open this post in threaded view
|

Re: Minor PR

Ilya Kasnacheev
Hello!

Please run tests against this change, get a green TC visa for the ticket.

Regards,
--
Ilya Kasnacheev


ср, 3 мар. 2021 г. в 17:13, Atri Sharma <[hidden email]>:

> Hi,
>
> Please help review this PR:
>
> https://github.com/apache/ignite/pull/8845
>
> Regards,
>
> Atri
>
Reply | Threaded
Open this post in threaded view
|

Re: Minor PR

Atri Sharma-2
Hello,

I ran the test suite and here is the link:

https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_RunAll/5906237

I ran all of the failed tests but they passed for me. Most of them are
marked as flaky.

Regards,

Atri

On Fri, Mar 5, 2021 at 5:42 PM Ilya Kasnacheev
<[hidden email]> wrote:

>
> Hello!
>
> Please run tests against this change, get a green TC visa for the ticket.
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> ср, 3 мар. 2021 г. в 17:13, Atri Sharma <[hidden email]>:
>
> > Hi,
> >
> > Please help review this PR:
> >
> > https://github.com/apache/ignite/pull/8845
> >
> > Regards,
> >
> > Atri
> >

--
Regards,

Atri
Apache Concerted
Reply | Threaded
Open this post in threaded view
|

Re: Minor PR

Ilya Kasnacheev
Hello!

You can use MTCGA to check those runs, such as
https://mtcga.gridgain.com/pr.html?serverId=apache&suiteId=IgniteTests24Java8_RunAll&branchForTc=pull/8845/head&action=Latest

This one looks OK, I will merge.

Regards,
--
Ilya Kasnacheev


пн, 8 мар. 2021 г. в 10:57, Atri Sharma <[hidden email]>:

> Hello,
>
> I ran the test suite and here is the link:
>
>
> https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_RunAll/5906237
>
> I ran all of the failed tests but they passed for me. Most of them are
> marked as flaky.
>
> Regards,
>
> Atri
>
> On Fri, Mar 5, 2021 at 5:42 PM Ilya Kasnacheev
> <[hidden email]> wrote:
> >
> > Hello!
> >
> > Please run tests against this change, get a green TC visa for the ticket.
> >
> > Regards,
> > --
> > Ilya Kasnacheev
> >
> >
> > ср, 3 мар. 2021 г. в 17:13, Atri Sharma <[hidden email]>:
> >
> > > Hi,
> > >
> > > Please help review this PR:
> > >
> > > https://github.com/apache/ignite/pull/8845
> > >
> > > Regards,
> > >
> > > Atri
> > >
>
> --
> Regards,
>
> Atri
> Apache Concerted
>
Reply | Threaded
Open this post in threaded view
|

Re: Minor PR

Atri Sharma-2
Thank you!

On Tue, 9 Mar 2021, 21:46 Ilya Kasnacheev, <[hidden email]>
wrote:

> Hello!
>
> You can use MTCGA to check those runs, such as
>
> https://mtcga.gridgain.com/pr.html?serverId=apache&suiteId=IgniteTests24Java8_RunAll&branchForTc=pull/8845/head&action=Latest
>
> This one looks OK, I will merge.
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> пн, 8 мар. 2021 г. в 10:57, Atri Sharma <[hidden email]>:
>
> > Hello,
> >
> > I ran the test suite and here is the link:
> >
> >
> >
> https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_RunAll/5906237
> >
> > I ran all of the failed tests but they passed for me. Most of them are
> > marked as flaky.
> >
> > Regards,
> >
> > Atri
> >
> > On Fri, Mar 5, 2021 at 5:42 PM Ilya Kasnacheev
> > <[hidden email]> wrote:
> > >
> > > Hello!
> > >
> > > Please run tests against this change, get a green TC visa for the
> ticket.
> > >
> > > Regards,
> > > --
> > > Ilya Kasnacheev
> > >
> > >
> > > ср, 3 мар. 2021 г. в 17:13, Atri Sharma <[hidden email]>:
> > >
> > > > Hi,
> > > >
> > > > Please help review this PR:
> > > >
> > > > https://github.com/apache/ignite/pull/8845
> > > >
> > > > Regards,
> > > >
> > > > Atri
> > > >
> >
> > --
> > Regards,
> >
> > Atri
> > Apache Concerted
> >
>