[ML] IGNITE-9978 Compound Naive Bayes Pull Request

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[ML] IGNITE-9978 Compound Naive Bayes Pull Request

Ravil Galeyev
Hi Team,

A week ago I submitted a pull-request
<https://github.com/apache/ignite/pull/6567> for IGNITE-9978
<https://issues.apache.org/jira/browse/IGNITE-9978> but it still unreviewed.
Can somebody take a look at it?

Dear
@zaleslaw @ybabak @avplatonov @dmitrievanthony
I mentioned you in the PR, but it looks like I did something wrong,
if you didn't receive notifications.

If you are busy now just let me know and I'll proceed with another task.

Best regards,
Ravil
Reply | Threaded
Open this post in threaded view
|

Re: [ML] IGNITE-9978 Compound Naive Bayes Pull Request

Dmitry Pavlov
Hi Ravil,

Thank you for your efforts. I've triggered tests for this PR.

I'm sure that ML experts will take care of it. Please always feel free to
remind the community about submitted PR.

Some Apache projects have a weekly digest about JIRAs in PA state, maybe we
can adapt this technique. And for now, I hope to add a similar feature to
Apache Ignite TC Bot (including information about tests failures). Since
JIRA digest nor TC Bot feature are not available yet, forgotten PR may
occur from time to time.

Sincerely,
Dmitriy Pavlov

сб, 1 июн. 2019 г. в 00:12, Ravil Galeyev <[hidden email]>:

> Hi Team,
>
> A week ago I submitted a pull-request
> <https://github.com/apache/ignite/pull/6567> for IGNITE-9978
> <https://issues.apache.org/jira/browse/IGNITE-9978> but it still
> unreviewed.
> Can somebody take a look at it?
>
> Dear
> @zaleslaw @ybabak @avplatonov @dmitrievanthony
> I mentioned you in the PR, but it looks like I did something wrong,
> if you didn't receive notifications.
>
> If you are busy now just let me know and I'll proceed with another task.
>
> Best regards,
> Ravil
>
Reply | Threaded
Open this post in threaded view
|

Re: [ML] IGNITE-9978 Compound Naive Bayes Pull Request

Alexey Zinoviev
In reply to this post by Ravil Galeyev
I will have a look this week, currently it has conflicts with master



--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Reply | Threaded
Open this post in threaded view
|

Re: [ML] IGNITE-9978 Compound Naive Bayes Pull Request

Dmitry Pavlov
Hi Alexey, thank you.

Hi Ravil,

4 blockers from TC bot seems to be unrelated to the change. Please check
only that contributed files have appropriate licenses. I see failure here
https://ci.ignite.apache.org/viewLog.html?buildId=4003665&buildTypeId=IgniteTests24Java8_LicensesHeaders&tab=artifacts&branch_IgniteTests24Java8=%3Cdefault%3E


Sincerely,
Dmitriy Pavlov

пн, 3 июн. 2019 г. в 18:30, Alexey Zinoviev <[hidden email]>:

> I will have a look this week, currently it has conflicts with master
>
>
>
> --
> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>