[ML] IGNITE-9282 Naive Bayes task split

[Ravil Galeyev]

Hi Team,
I work on implementing Naive Bayes classifiers.

Withing IGNITE-9282 <https://issues.apache.org/jira/browse/IGNITE-9282> I
implemented a Gaussian Bayes and created a PR
https://github.com/apache/ignite/pull/4869

But  there are already a lot of changes
That's' why I'd like to create separate tasks for
multinomial and Bernoulli Bayes classifiers and continue work.

Any objections?

Best regards,
Ravil

[Yuriy Babak]

Hi Ravil,

I think this is a good idea. I prefer to have several small single-feature
tickets instead of a big one with several features.

I will start reviewing 9282 on this week. Also, I looking forward to seeing
those new tickets.

Regards,
Yuriy

вс, 30 сент. 2018 г. в 3:58, Ravil Galeyev <[hidden email]>:

> Hi Team,
> I work on implementing Naive Bayes classifiers.
>
> Withing IGNITE-9282 <https://issues.apache.org/jira/browse/IGNITE-9282> I
> implemented a Gaussian Bayes and created a PR
> https://github.com/apache/ignite/pull/4869
>
> But  there are already a lot of changes
> That's' why I'd like to create separate tasks for
> multinomial and Bernoulli Bayes classifiers and continue work.
>
> Any objections?
>
> Best regards,
> Ravil
>

[Ravil Galeyev]

Hi Yuriy,

I created new tickets for other Bayes classifiers
IGNITE-9745 <https://issues.apache.org/jira/browse/IGNITE-9745> Multinomial
Naive Bayes
IGNITE-9746 <https://issues.apache.org/jira/browse/IGNITE-9746> Complement
Naive Bayes
IGNITE-9747 <https://issues.apache.org/jira/browse/IGNITE-9747> Bernoulli
Naive Bayes

they are isolated and independent. That's why anybody can work on them.

Regards,
Ravil

On Sun, 30 Sep 2018 at 19:53 Yuriy Babak <[hidden email]> wrote:

> Hi Ravil,
>
> I think this is a good idea. I prefer to have several small single-feature
> tickets instead of a big one with several features.
>
> I will start reviewing 9282 on this week. Also, I looking forward to seeing
> those new tickets.
>
> Regards,
> Yuriy
>
> вс, 30 сент. 2018 г. в 3:58, Ravil Galeyev <[hidden email]>:
>
> > Hi Team,
> > I work on implementing Naive Bayes classifiers.
> >
> > Withing IGNITE-9282 <https://issues.apache.org/jira/browse/IGNITE-9282>
> I
> > implemented a Gaussian Bayes and created a PR
> > https://github.com/apache/ignite/pull/4869
> >
> > But  there are already a lot of changes
> > That's' why I'd like to create separate tasks for
> > multinomial and Bernoulli Bayes classifiers and continue work.
> >
> > Any objections?
> >
> > Best regards,
> > Ravil
> >
>

[Alexey Zinoviev]

Great, I support this idea, will help with review too



--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

[Ravil Galeyev]

Hi Team

so, can somebody look at PR https://github.com/apache/ignite/pull/4869 with
naive Bayes?

@zaleslaw, @ybabak do you have time?
if reviewing takes time, can I take some other task?
I.e. I can implement IGNITE-9284
<https://issues.apache.org/jira/browse/IGNITE-9284> Standart scaler for a
while.
Because I've already implemented one preprocessor and know what to do.

On Mon, 1 Oct 2018 at 09:44 Alexey Zinoviev <[hidden email]> wrote:

> Great, I support this idea, will help with review too
>
>
>
> --
> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>

[Alexey Zinoviev]

Dear Ravil, will help with review next week, currently a lot of work with
release documentation review/writing.

Of course, you could assign Standart Scaler task for yourself.


пт, 5 окт. 2018 г. в 16:38, Ravil Galeyev <[hidden email]>:

> Hi Team
>
> so, can somebody look at PR https://github.com/apache/ignite/pull/4869
> with
> naive Bayes?
>
> @zaleslaw, @ybabak do you have time?
> if reviewing takes time, can I take some other task?
> I.e. I can implement IGNITE-9284
> <https://issues.apache.org/jira/browse/IGNITE-9284> Standart scaler for a
> while.
> Because I've already implemented one preprocessor and know what to do.
>
> On Mon, 1 Oct 2018 at 09:44 Alexey Zinoviev <[hidden email]>
> wrote:
>
> > Great, I support this idea, will help with review too
> >
> >
> >
> > --
> > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> >
>