Igniters, Alexey G, Pavel K,
IGNITE-6113 changes [1] caused broken .NET test [2] Have you run TeamCity before merging? Please fix this. When new APIs are added to Java you should: a) add them to .NET as well - or - b) file a ticket and update .NET test (see how in CacheParityTest.cs we have a bunch of ignored APIs with JIRA tickets in comments) [1] https://github.com/apache/ignite/commit/6dc5804af6dda90ca210a39d622964d78e3890f1 [2] https://ci.ignite.apache.org/viewLog.html?buildId=1128191 Thanks, Pavel |
Hi Pavel,
Thank you for pointing to this issue. We have detected it under Teamcity monitoring, but still any additional info on test failures is appreciated. I've checked PR run but did not noticed this failures, I have considered this failures as flaky: Ignite Platform .NET Core Linux [ tests 1 ] dll: CacheMetricsParityTest.TestCacheMetrics (fail rate 2,9%) Ignite Platform .NET [ tests 1 ] exe: CacheMetricsParityTest.TestCacheMetrics (fail rate 1,9%) Please see https://issues.apache.org/jira/browse/IGNITE-7773 Igniters, who can help with adding this metric to .NET? Sincerely, Dmitriy Pavlov ср, 7 мар. 2018 г. в 11:35, Pavel Tupitsyn <[hidden email]>: > Igniters, Alexey G, Pavel K, > > IGNITE-6113 changes [1] caused broken .NET test [2] > Have you run TeamCity before merging? > > Please fix this. > > When new APIs are added to Java you should: > a) add them to .NET as well > - or - > b) file a ticket and update .NET test (see how in CacheParityTest.cs we > have a bunch of ignored APIs with JIRA tickets in comments) > > [1] > > https://github.com/apache/ignite/commit/6dc5804af6dda90ca210a39d622964d78e3890f1 > [2] https://ci.ignite.apache.org/viewLog.html?buildId=1128191 > > Thanks, > Pavel > |
Yep, this test is not flaky at all, it had failed before for the same exact
reason, forgetting to update .NET. On Wed, Mar 7, 2018 at 12:13 PM, Dmitry Pavlov <[hidden email]> wrote: > Hi Pavel, > > Thank you for pointing to this issue. We have detected it under Teamcity > monitoring, but still any additional info on test failures is appreciated. > > I've checked PR run but did not noticed this failures, I have considered > this failures as flaky: > > Ignite Platform .NET Core Linux [ tests 1 ] > dll: CacheMetricsParityTest.TestCacheMetrics (fail rate 2,9%) > > Ignite Platform .NET [ tests 1 ] > exe: CacheMetricsParityTest.TestCacheMetrics (fail rate 1,9%) > > Please see https://issues.apache.org/jira/browse/IGNITE-7773 > > Igniters, who can help with adding this metric to .NET? > > Sincerely, > Dmitriy Pavlov > > > ср, 7 мар. 2018 г. в 11:35, Pavel Tupitsyn <[hidden email]>: > > > Igniters, Alexey G, Pavel K, > > > > IGNITE-6113 changes [1] caused broken .NET test [2] > > Have you run TeamCity before merging? > > > > Please fix this. > > > > When new APIs are added to Java you should: > > a) add them to .NET as well > > - or - > > b) file a ticket and update .NET test (see how in CacheParityTest.cs we > > have a bunch of ignored APIs with JIRA tickets in comments) > > > > [1] > > > > https://github.com/apache/ignite/commit/6dc5804af6dda90ca210a39d622964 > d78e3890f1 > > [2] https://ci.ignite.apache.org/viewLog.html?buildId=1128191 > > > > Thanks, > > Pavel > > > |
Yes, it seems I need to do some update to
https://github.com/dspavlov/ignite-teamcity-helper to reset fail rate after reasonable timeout/runs of tests. I quess 3 weeks and/or 100 successfull runs may be sufficient to consider test as fixed. WDYT? ср, 7 мар. 2018 г. в 15:02, Pavel Tupitsyn <[hidden email]>: > Yep, this test is not flaky at all, it had failed before for the same exact > reason, forgetting to update .NET. > > On Wed, Mar 7, 2018 at 12:13 PM, Dmitry Pavlov <[hidden email]> > wrote: > > > Hi Pavel, > > > > Thank you for pointing to this issue. We have detected it under Teamcity > > monitoring, but still any additional info on test failures is > appreciated. > > > > I've checked PR run but did not noticed this failures, I have considered > > this failures as flaky: > > > > Ignite Platform .NET Core Linux [ tests 1 ] > > dll: CacheMetricsParityTest.TestCacheMetrics (fail rate 2,9%) > > > > Ignite Platform .NET [ tests 1 ] > > exe: CacheMetricsParityTest.TestCacheMetrics (fail rate 1,9%) > > > > Please see https://issues.apache.org/jira/browse/IGNITE-7773 > > > > Igniters, who can help with adding this metric to .NET? > > > > Sincerely, > > Dmitriy Pavlov > > > > > > ср, 7 мар. 2018 г. в 11:35, Pavel Tupitsyn <[hidden email]>: > > > > > Igniters, Alexey G, Pavel K, > > > > > > IGNITE-6113 changes [1] caused broken .NET test [2] > > > Have you run TeamCity before merging? > > > > > > Please fix this. > > > > > > When new APIs are added to Java you should: > > > a) add them to .NET as well > > > - or - > > > b) file a ticket and update .NET test (see how in CacheParityTest.cs we > > > have a bunch of ignored APIs with JIRA tickets in comments) > > > > > > [1] > > > > > > https://github.com/apache/ignite/commit/6dc5804af6dda90ca210a39d622964 > > d78e3890f1 > > > [2] https://ci.ignite.apache.org/viewLog.html?buildId=1128191 > > > > > > Thanks, > > > Pavel > > > > > > |
Free forum by Nabble | Edit this page |