Looking for quick help on "Adding dynamic indexes and fields to ignite cache"

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Looking for quick help on "Adding dynamic indexes and fields to ignite cache"

Vamsi Krishna
Can you please check pull request (
https://github.com/apache/ignite/pull/7016) and let me know if you can
merge it. Please find the conversation @

http://apache-ignite-users.70518.x6.nabble.com/Issue-with-adding-nested-index-dynamically-td29571i40.html

This fix is really important for us to take our datagrid ignite to
production in January. Any quick help will be appreciated.

This fix will support dynamic addition of fields and indexes. Fix is pretty
small

_____________________________________


--
Regards,
Vamsi.
Cell: 908-674-2818.
Reply | Threaded
Open this post in threaded view
|

Re: Looking for quick help on "Adding dynamic indexes and fields to ignite cache"

dmagda
Hello, thanks for your contribution. Have you checked the PR with our
continuous integration tests (see TeamCity paragraph below)?
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-1.CreateGitHubpull-request

As for the review, I'll let our SQL experts step in.
-
Denis


On Wed, Nov 6, 2019 at 10:41 AM Vamsi Krishna <[hidden email]> wrote:

> Can you please check pull request (
> https://github.com/apache/ignite/pull/7016) and let me know if you can
> merge it. Please find the conversation @
>
>
> http://apache-ignite-users.70518.x6.nabble.com/Issue-with-adding-nested-index-dynamically-td29571i40.html
>
> This fix is really important for us to take our datagrid ignite to
> production in January. Any quick help will be appreciated.
>
> This fix will support dynamic addition of fields and indexes. Fix is pretty
> small
>
> _____________________________________
>
>
> --
> Regards,
> Vamsi.
> Cell: 908-674-2818.
>
Reply | Threaded
Open this post in threaded view
|

Re: Looking for quick help on "Adding dynamic indexes and fields to ignite cache"

Ilya Kasnacheev
In reply to this post by Vamsi Krishna
Hello!

Unfortunately, the use case of this fix is still not clear. Can you please
introduce a test which will show which capacity is added here? Are you sure
it will not break any existing deployments where SQL is used together with
nested objects?

Regards,
--
Ilya Kasnacheev


ср, 6 нояб. 2019 г. в 21:41, Vamsi Krishna <[hidden email]>:

> Can you please check pull request (
> https://github.com/apache/ignite/pull/7016) and let me know if you can
> merge it. Please find the conversation @
>
>
> http://apache-ignite-users.70518.x6.nabble.com/Issue-with-adding-nested-index-dynamically-td29571i40.html
>
> This fix is really important for us to take our datagrid ignite to
> production in January. Any quick help will be appreciated.
>
> This fix will support dynamic addition of fields and indexes. Fix is pretty
> small
>
> _____________________________________
>
>
> --
> Regards,
> Vamsi.
> Cell: 908-674-2818.
>