Hi Igniters,
I completed the patch. I have filled the request in JIRA: https://issues.apache.org/jira/browse/IGNITE-788. The implementation provides a single java file with a configuration file for log4j2. The basic idea was to use a router appender that properly generates a log file by default and a log for instance ignite. The implementation is the simplest I could find.Obviously you need to invoke the module with a path to a valid configuration file.You will find attached also the test cases updated with the call to the new API log4j2. I am available for any questions, suggestions etc .. Regards, Gianfranco |
Thanks Gianfranco!
I am certain someone will review your patch within a couple of days and provide feedback. Just so you know, once your patch is accepted, you will be eligible to become a committer. D. On Sun, May 31, 2015 at 7:36 AM, Gianfranco Murador < [hidden email]> wrote: > Hi Igniters, > I completed the patch. I have filled the request in JIRA: > https://issues.apache.org/jira/browse/IGNITE-788. The implementation > provides a single java file with > a configuration file for log4j2. The basic idea was to use a router > appender that properly generates > a log file by default and a log for instance ignite. The implementation is > the simplest I could find.Obviously you need to invoke the module with a > path to a valid configuration file.You will find attached also the test > cases updated with the call to the new API log4j2. > I am available for any questions, suggestions etc .. > Regards, Gianfranco > |
In reply to this post by Gianfranco Murador
Gianfranco, can you please attach regular patch file so I can apply it to
my local ignite-sprint-5 branch? For contributor convenience we created script formatting the patches - IGNITE_HOME/scripts/git-format-patch.sh. --Yakov 2015-05-31 17:36 GMT+03:00 Gianfranco Murador <[hidden email]> : > Hi Igniters, > I completed the patch. I have filled the request in JIRA: > https://issues.apache.org/jira/browse/IGNITE-788. The implementation > provides a single java file with > a configuration file for log4j2. The basic idea was to use a router > appender that properly generates > a log file by default and a log for instance ignite. The implementation is > the simplest I could find.Obviously you need to invoke the module with a > path to a valid configuration file.You will find attached also the test > cases updated with the call to the new API log4j2. > I am available for any questions, suggestions etc .. > Regards, Gianfranco > |
Hello Yakov,
I will commit the patch as soon as possible ( I'm at work now :) ). For " regular file " you mean the single java file ? Or directly the module folder ? I will attach a new file this afternoon , I hope :), the worse tomorrow. Regards, Gianfranco 2015-06-01 10:57 GMT+02:00 Yakov Zhdanov <[hidden email]>: > Gianfranco, can you please attach regular patch file so I can apply it to > my local ignite-sprint-5 branch? > > For contributor convenience we created script formatting the patches - > IGNITE_HOME/scripts/git-format-patch.sh. > > --Yakov > > 2015-05-31 17:36 GMT+03:00 Gianfranco Murador < > [hidden email]> > : > > > Hi Igniters, > > I completed the patch. I have filled the request in JIRA: > > https://issues.apache.org/jira/browse/IGNITE-788. The implementation > > provides a single java file with > > a configuration file for log4j2. The basic idea was to use a router > > appender that properly generates > > a log file by default and a log for instance ignite. The implementation > is > > the simplest I could find.Obviously you need to invoke the module with a > > path to a valid configuration file.You will find attached also the test > > cases updated with the call to the new API log4j2. > > I am available for any questions, suggestions etc .. > > Regards, Gianfranco > > > |
Gianfranco, regular patch file in terms of git. It's like diff between your
branch and ignite-sprint-5. Just checkout your branch with your changes and run git-format-patch.sh to create patch file. -- Artem -- On Mon, Jun 1, 2015 at 12:52 PM, Gianfranco Murador < [hidden email]> wrote: > Hello Yakov, > I will commit the patch as soon as possible ( I'm at work now :) ). > For " regular file " you mean the single java file ? Or directly the module > folder ? > I will attach a new file this afternoon , I hope :), the worse tomorrow. > Regards, Gianfranco > > 2015-06-01 10:57 GMT+02:00 Yakov Zhdanov <[hidden email]>: > > > Gianfranco, can you please attach regular patch file so I can apply it to > > my local ignite-sprint-5 branch? > > > > For contributor convenience we created script formatting the patches - > > IGNITE_HOME/scripts/git-format-patch.sh. > > > > --Yakov > > > > 2015-05-31 17:36 GMT+03:00 Gianfranco Murador < > > [hidden email]> > > : > > > > > Hi Igniters, > > > I completed the patch. I have filled the request in JIRA: > > > https://issues.apache.org/jira/browse/IGNITE-788. The implementation > > > provides a single java file with > > > a configuration file for log4j2. The basic idea was to use a router > > > appender that properly generates > > > a log file by default and a log for instance ignite. The implementation > > is > > > the simplest I could find.Obviously you need to invoke the module with > a > > > path to a valid configuration file.You will find attached also the test > > > cases updated with the call to the new API log4j2. > > > I am available for any questions, suggestions etc .. > > > Regards, Gianfranco > > > > > > |
Free forum by Nabble | Edit this page |