Java thin client transactions withLabel ot working

[Sergey Stronchinskiy]

Dear Igniters,

Correct me if I'm wrong, but it seems that Java thin client
*client.transactions().withLabel* functionality is broken. I've tried to
add next test:




















* @Test    public void testTransactions1() throws Exception {        try
(Ignite ignite = Ignition.start(Config.getServerConfiguration());
   IgniteClient client = Ignition.startClient(getClientConfiguration())
    ) {            ClientCache<Integer, String> cache =
client.createCache(new ClientCacheConfiguration()
.setName("cache")
.setAtomicityMode(CacheAtomicityMode.TRANSACTIONAL)            );
  cache.put(0, "value0");            cache.put(1, "value1");            //
Test implicit rollback when transaction closed.            try
(ClientTransaction tx =
client.transactions().withLabel("asdasda").txStart()) {
cache.put(1, "value2");            }            assertEquals("value1",
cache.get(1));}    }*

And it fails with:




*org.junit.ComparisonFailure: Expected :value1Actual   :value2*
Thank you.

[Sergey Stronchinskiy]

To be more specific - test was added to thin client functional tests
located in *org.apache.ignite.client.FunctionalTest.*

Thank you.

On Sun, 21 Jun 2020 at 23:56, Guru Stron <[hidden email]> wrote:

> Dear Igniters,
>
> Correct me if I'm wrong, but it seems that Java thin client
> *client.transactions().withLabel* functionality is broken. I've tried to
> add next test:
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> * @Test    public void testTransactions1() throws Exception {        try
> (Ignite ignite = Ignition.start(Config.getServerConfiguration());
>    IgniteClient client = Ignition.startClient(getClientConfiguration())
>     ) {            ClientCache<Integer, String> cache =
> client.createCache(new ClientCacheConfiguration()
> .setName("cache")
> .setAtomicityMode(CacheAtomicityMode.TRANSACTIONAL)            );
>   cache.put(0, "value0");            cache.put(1, "value1");            //
> Test implicit rollback when transaction closed.            try
> (ClientTransaction tx =
> client.transactions().withLabel("asdasda").txStart()) {
> cache.put(1, "value2");            }            assertEquals("value1",
> cache.get(1));}    }*
>
> And it fails with:
>
>
>
>
> *org.junit.ComparisonFailure: Expected :value1Actual   :value2*
> Thank you.
>

[Alexey Plekhanov]

Hello,

Looks like a bug. I've filled the ticket [1].

Thanks for your report.

[1]: https://issues.apache.org/jira/browse/IGNITE-13170

пн, 22 июн. 2020 г. в 02:05, Guru Stron <[hidden email]>:

> To be more specific - test was added to thin client functional tests
> located in *org.apache.ignite.client.FunctionalTest.*
>
> Thank you.
>
> On Sun, 21 Jun 2020 at 23:56, Guru Stron <[hidden email]>
> wrote:
>
> > Dear Igniters,
> >
> > Correct me if I'm wrong, but it seems that Java thin client
> > *client.transactions().withLabel* functionality is broken. I've tried to
> > add next test:
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > * @Test    public void testTransactions1() throws Exception {        try
> > (Ignite ignite = Ignition.start(Config.getServerConfiguration());
> >    IgniteClient client = Ignition.startClient(getClientConfiguration())
> >     ) {            ClientCache<Integer, String> cache =
> > client.createCache(new ClientCacheConfiguration()
> > .setName("cache")
> > .setAtomicityMode(CacheAtomicityMode.TRANSACTIONAL)            );
> >   cache.put(0, "value0");            cache.put(1, "value1");
> //
> > Test implicit rollback when transaction closed.            try
> > (ClientTransaction tx =
> > client.transactions().withLabel("asdasda").txStart()) {
> > cache.put(1, "value2");            }            assertEquals("value1",
> > cache.get(1));}    }*
> >
> > And it fails with:
> >
> >
> >
> >
> > *org.junit.ComparisonFailure: Expected :value1Actual   :value2*
> > Thank you.
> >
>

[Sergey Stronchinskiy]

Hello Alex,

Thank you. Few more questions:

   1. how something like this should behave:
   *client.transactions().withLabel("lab1").withLabel("lab2") *
   2. should it be possible for a thin client to start in one thread a
   transaction with a label and without one?

Thank you.

`

On Mon, 22 Jun 2020 at 06:28, Alex Plehanov <[hidden email]> wrote:

> Hello,
>
> Looks like a bug. I've filled the ticket [1].
>
> Thanks for your report.
>
> [1]: https://issues.apache.org/jira/browse/IGNITE-13170
>
> пн, 22 июн. 2020 г. в 02:05, Guru Stron <[hidden email]>:
>
> > To be more specific - test was added to thin client functional tests
> > located in *org.apache.ignite.client.FunctionalTest.*
> >
> > Thank you.
> >
> > On Sun, 21 Jun 2020 at 23:56, Guru Stron <[hidden email]>
> > wrote:
> >
> > > Dear Igniters,
> > >
> > > Correct me if I'm wrong, but it seems that Java thin client
> > > *client.transactions().withLabel* functionality is broken. I've tried
> to
> > > add next test:
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > * @Test    public void testTransactions1() throws Exception {
> try
> > > (Ignite ignite = Ignition.start(Config.getServerConfiguration());
> > >    IgniteClient client = Ignition.startClient(getClientConfiguration())
> > >     ) {            ClientCache<Integer, String> cache =
> > > client.createCache(new ClientCacheConfiguration()
> > > .setName("cache")
> > > .setAtomicityMode(CacheAtomicityMode.TRANSACTIONAL)            );
> > >   cache.put(0, "value0");            cache.put(1, "value1");
> > //
> > > Test implicit rollback when transaction closed.            try
> > > (ClientTransaction tx =
> > > client.transactions().withLabel("asdasda").txStart()) {
> > > cache.put(1, "value2");            }            assertEquals("value1",
> > > cache.get(1));}    }*
> > >
> > > And it fails with:
> > >
> > >
> > >
> > >
> > > *org.junit.ComparisonFailure: Expected :value1Actual   :value2*
> > > Thank you.
> > >
> >
>

[Alexey Plekhanov]

1. Transaction with label "lab2" will start.
2. No, only one transaction in a thread.
These tests already added to PR: [1]

[1]: https://github.com/apache/ignite/pull/7951/files

пн, 22 июн. 2020 г. в 14:58, Guru Stron <[hidden email]>:

> Hello Alex,
>
> Thank you. Few more questions:
>
>    1. how something like this should behave:
>    *client.transactions().withLabel("lab1").withLabel("lab2") *
>    2. should it be possible for a thin client to start in one thread a
>    transaction with a label and without one?
>
> Thank you.
>
> `
>
> On Mon, 22 Jun 2020 at 06:28, Alex Plehanov <[hidden email]>
> wrote:
>
> > Hello,
> >
> > Looks like a bug. I've filled the ticket [1].
> >
> > Thanks for your report.
> >
> > [1]: https://issues.apache.org/jira/browse/IGNITE-13170
> >
> > пн, 22 июн. 2020 г. в 02:05, Guru Stron <[hidden email]>:
> >
> > > To be more specific - test was added to thin client functional tests
> > > located in *org.apache.ignite.client.FunctionalTest.*
> > >
> > > Thank you.
> > >
> > > On Sun, 21 Jun 2020 at 23:56, Guru Stron <[hidden email]>
> > > wrote:
> > >
> > > > Dear Igniters,
> > > >
> > > > Correct me if I'm wrong, but it seems that Java thin client
> > > > *client.transactions().withLabel* functionality is broken. I've tried
> > to
> > > > add next test:
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > * @Test    public void testTransactions1() throws Exception {
> > try
> > > > (Ignite ignite = Ignition.start(Config.getServerConfiguration());
> > > >    IgniteClient client =
> Ignition.startClient(getClientConfiguration())
> > > >     ) {            ClientCache<Integer, String> cache =
> > > > client.createCache(new ClientCacheConfiguration()
> > > > .setName("cache")
> > > > .setAtomicityMode(CacheAtomicityMode.TRANSACTIONAL)            );
> > > >   cache.put(0, "value0");            cache.put(1, "value1");
> > > //
> > > > Test implicit rollback when transaction closed.            try
> > > > (ClientTransaction tx =
> > > > client.transactions().withLabel("asdasda").txStart()) {
> > > > cache.put(1, "value2");            }
> assertEquals("value1",
> > > > cache.get(1));}    }*
> > > >
> > > > And it fails with:
> > > >
> > > >
> > > >
> > > >
> > > > *org.junit.ComparisonFailure: Expected :value1Actual   :value2*
> > > > Thank you.
> > > >
> > >
> >
>

[Sergey Stronchinskiy]

Thank you for the information!

On Mon, 22 Jun 2020 at 13:21, Alex Plehanov <[hidden email]> wrote:

> 1. Transaction with label "lab2" will start.
> 2. No, only one transaction in a thread.
> These tests already added to PR: [1]
>
> [1]: https://github.com/apache/ignite/pull/7951/files
>
> пн, 22 июн. 2020 г. в 14:58, Guru Stron <[hidden email]>:
>
> > Hello Alex,
> >
> > Thank you. Few more questions:
> >
> >    1. how something like this should behave:
> >    *client.transactions().withLabel("lab1").withLabel("lab2") *
> >    2. should it be possible for a thin client to start in one thread a
> >    transaction with a label and without one?
> >
> > Thank you.
> >
> > `
> >
> > On Mon, 22 Jun 2020 at 06:28, Alex Plehanov <[hidden email]>
> > wrote:
> >
> > > Hello,
> > >
> > > Looks like a bug. I've filled the ticket [1].
> > >
> > > Thanks for your report.
> > >
> > > [1]: https://issues.apache.org/jira/browse/IGNITE-13170
> > >
> > > пн, 22 июн. 2020 г. в 02:05, Guru Stron <[hidden email]>:
> > >
> > > > To be more specific - test was added to thin client functional tests
> > > > located in *org.apache.ignite.client.FunctionalTest.*
> > > >
> > > > Thank you.
> > > >
> > > > On Sun, 21 Jun 2020 at 23:56, Guru Stron <[hidden email]>
> > > > wrote:
> > > >
> > > > > Dear Igniters,
> > > > >
> > > > > Correct me if I'm wrong, but it seems that Java thin client
> > > > > *client.transactions().withLabel* functionality is broken. I've
> tried
> > > to
> > > > > add next test:
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > * @Test    public void testTransactions1() throws Exception {
> > > try
> > > > > (Ignite ignite = Ignition.start(Config.getServerConfiguration());
> > > > >    IgniteClient client =
> > Ignition.startClient(getClientConfiguration())
> > > > >     ) {            ClientCache<Integer, String> cache =
> > > > > client.createCache(new ClientCacheConfiguration()
> > > > > .setName("cache")
> > > > > .setAtomicityMode(CacheAtomicityMode.TRANSACTIONAL)            );
> > > > >   cache.put(0, "value0");            cache.put(1, "value1");
> > > > //
> > > > > Test implicit rollback when transaction closed.            try
> > > > > (ClientTransaction tx =
> > > > > client.transactions().withLabel("asdasda").txStart()) {
> > > > > cache.put(1, "value2");            }
> > assertEquals("value1",
> > > > > cache.get(1));}    }*
> > > > >
> > > > > And it fails with:
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > *org.junit.ComparisonFailure: Expected :value1Actual   :value2*
> > > > > Thank you.
> > > > >
> > > >
> > >
> >
>