Incorrect setter method

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Incorrect setter method

Vasiliy Sisko
Hello.

I found in IgniteConfiguration incorrectly named pair of getter and setter
methods:
Get method is: getMarshallerCacheThreadPoolSize
Set method is: setMarshallerCachePoolSize

I think we should to deprecate setMarshallerCachePoolSize method and create
new setMarshallerCacheThreadPoolSize method.

Thoughts?

--
Vasiliy Sisko
GridGain Systems
www.gridgain.com
Reply | Threaded
Open this post in threaded view
|

Re: Incorrect setter method

dsetrakyan
Agree. Vasiliy, can you do it (seems like a small fix) ?

On Tue, Dec 29, 2015 at 11:46 PM, Vasiliy Sisko <[hidden email]> wrote:

> Hello.
>
> I found in IgniteConfiguration incorrectly named pair of getter and setter
> methods:
> Get method is: getMarshallerCacheThreadPoolSize
> Set method is: setMarshallerCachePoolSize
>
> I think we should to deprecate setMarshallerCachePoolSize method and create
> new setMarshallerCacheThreadPoolSize method.
>
> Thoughts?
>
> --
> Vasiliy Sisko
> GridGain Systems
> www.gridgain.com
>
Reply | Threaded
Open this post in threaded view
|

Re: Incorrect setter method

Vasiliy Sisko
Yes. I do.

On Wed, Dec 30, 2015 at 3:00 PM, Dmitriy Setrakyan <[hidden email]>
wrote:

> Agree. Vasiliy, can you do it (seems like a small fix) ?
>
> On Tue, Dec 29, 2015 at 11:46 PM, Vasiliy Sisko <[hidden email]>
> wrote:
>
> > Hello.
> >
> > I found in IgniteConfiguration incorrectly named pair of getter and
> setter
> > methods:
> > Get method is: getMarshallerCacheThreadPoolSize
> > Set method is: setMarshallerCachePoolSize
> >
> > I think we should to deprecate setMarshallerCachePoolSize method and
> create
> > new setMarshallerCacheThreadPoolSize method.
> >
> > Thoughts?
> >
> > --
> > Vasiliy Sisko
> > GridGain Systems
> > www.gridgain.com
> >
>



--
Vasiliy Sisko
GridGain Systems
www.gridgain.com