Ignite Semaphore Bug 7090

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

Ignite Semaphore Bug 7090

Timay
Hey all,

I created a patch and posted to user group, was told feed back would be
left on the jira. I wanted to see if we could get a fix in with 2.4, could
somebody please review.

http://apache-ignite-users.70518.x6.nabble.com/Semaphore-Stuck-when-no-acquirers-to-assign-permit-td18639.html

https://issues.apache.org/jira/browse/IGNITE-7090

https://github.com/apache/ignite/pull/3138

Thanks,
Tim
Reply | Threaded
Open this post in threaded view
|

Re: Ignite Semaphore Bug 7090

yzhdanov
Thanks Tim! I hope Vlad can review your patch. If this does not happen in
2-3 days I will take a look. Can you please let me know on weekend if I
need to?

--Yakov

2018-01-16 23:36 GMT+03:00 Tim Onyschak <[hidden email]>:

> Hey all,
>
> I created a patch and posted to user group, was told feed back would be
> left on the jira. I wanted to see if we could get a fix in with 2.4, could
> somebody please review.
>
> http://apache-ignite-users.70518.x6.nabble.com/Semaphore-
> Stuck-when-no-acquirers-to-assign-permit-td18639.html
>
> https://issues.apache.org/jira/browse/IGNITE-7090
>
> https://github.com/apache/ignite/pull/3138
>
> Thanks,
> Tim
>
Reply | Threaded
Open this post in threaded view
|

Re: Ignite Semaphore Bug 7090

Vladisav Jelisavcic
Hi Tim,

thank you for the contribution!
I'll do the review soon and let you know.



On Wed, Jan 17, 2018 at 8:56 AM, Yakov Zhdanov <[hidden email]> wrote:

> Thanks Tim! I hope Vlad can review your patch. If this does not happen in
> 2-3 days I will take a look. Can you please let me know on weekend if I
> need to?
>
> --Yakov
>
> 2018-01-16 23:36 GMT+03:00 Tim Onyschak <[hidden email]>:
>
> > Hey all,
> >
> > I created a patch and posted to user group, was told feed back would be
> > left on the jira. I wanted to see if we could get a fix in with 2.4,
> could
> > somebody please review.
> >
> > http://apache-ignite-users.70518.x6.nabble.com/Semaphore-
> > Stuck-when-no-acquirers-to-assign-permit-td18639.html
> >
> > https://issues.apache.org/jira/browse/IGNITE-7090
> >
> > https://github.com/apache/ignite/pull/3138
> >
> > Thanks,
> > Tim
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Ignite Semaphore Bug 7090

Vladisav Jelisavcic
Hi Tim,

I reviewed your contribution and left you some comments on the pr.
Thanks!

Vladisav

On Wed, Jan 17, 2018 at 10:14 PM, Vladisav Jelisavcic <[hidden email]>
wrote:

> Hi Tim,
>
> thank you for the contribution!
> I'll do the review soon and let you know.
>
>
>
> On Wed, Jan 17, 2018 at 8:56 AM, Yakov Zhdanov <[hidden email]>
> wrote:
>
>> Thanks Tim! I hope Vlad can review your patch. If this does not happen in
>> 2-3 days I will take a look. Can you please let me know on weekend if I
>> need to?
>>
>> --Yakov
>>
>> 2018-01-16 23:36 GMT+03:00 Tim Onyschak <[hidden email]>:
>>
>> > Hey all,
>> >
>> > I created a patch and posted to user group, was told feed back would be
>> > left on the jira. I wanted to see if we could get a fix in with 2.4,
>> could
>> > somebody please review.
>> >
>> > http://apache-ignite-users.70518.x6.nabble.com/Semaphore-
>> > Stuck-when-no-acquirers-to-assign-permit-td18639.html
>> >
>> > https://issues.apache.org/jira/browse/IGNITE-7090
>> >
>> > https://github.com/apache/ignite/pull/3138
>> >
>> > Thanks,
>> > Tim
>> >
>>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Ignite Semaphore Bug 7090

Timay
Hey Vladisav,

I implemented your requests. Take a look, specifically, i created an
interface to encapsulate the NodeUpdates and let
the DataStructuresProcessor handle the execution by checking for one type
as opposed to multiple if checks. In this case it checks for
GridCacheNodeUpdate
instance and executes onNodeRemoved. Let me know what you think.

Thanks,
Tim



On Sat, Jan 20, 2018 at 8:10 AM, Vladisav Jelisavcic <[hidden email]>
wrote:

> Hi Tim,
>
> I reviewed your contribution and left you some comments on the pr.
> Thanks!
>
> Vladisav
>
> On Wed, Jan 17, 2018 at 10:14 PM, Vladisav Jelisavcic <[hidden email]
> > wrote:
>
>> Hi Tim,
>>
>> thank you for the contribution!
>> I'll do the review soon and let you know.
>>
>>
>>
>> On Wed, Jan 17, 2018 at 8:56 AM, Yakov Zhdanov <[hidden email]>
>> wrote:
>>
>>> Thanks Tim! I hope Vlad can review your patch. If this does not happen in
>>> 2-3 days I will take a look. Can you please let me know on weekend if I
>>> need to?
>>>
>>> --Yakov
>>>
>>> 2018-01-16 23:36 GMT+03:00 Tim Onyschak <[hidden email]>:
>>>
>>> > Hey all,
>>> >
>>> > I created a patch and posted to user group, was told feed back would be
>>> > left on the jira. I wanted to see if we could get a fix in with 2.4,
>>> could
>>> > somebody please review.
>>> >
>>> > http://apache-ignite-users.70518.x6.nabble.com/Semaphore-
>>> > Stuck-when-no-acquirers-to-assign-permit-td18639.html
>>> >
>>> > https://issues.apache.org/jira/browse/IGNITE-7090
>>> >
>>> > https://github.com/apache/ignite/pull/3138
>>> >
>>> > Thanks,
>>> > Tim
>>> >
>>>
>>
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: Ignite Semaphore Bug 7090

Vladisav Jelisavcic
Hi Tim,

thanks for the update! I left you a comment on Jira.

Best regards,
Vladisav

On Mon, Jan 22, 2018 at 6:17 PM, Tim Onyschak <[hidden email]> wrote:

> Hey Vladisav,
>
> I implemented your requests. Take a look, specifically, i created an
> interface to encapsulate the NodeUpdates and let
> the DataStructuresProcessor handle the execution by checking for one type
> as opposed to multiple if checks. In this case it checks for GridCacheNodeUpdate
> instance and executes onNodeRemoved. Let me know what you think.
>
> Thanks,
> Tim
>
>
>
> On Sat, Jan 20, 2018 at 8:10 AM, Vladisav Jelisavcic <[hidden email]>
> wrote:
>
>> Hi Tim,
>>
>> I reviewed your contribution and left you some comments on the pr.
>> Thanks!
>>
>> Vladisav
>>
>> On Wed, Jan 17, 2018 at 10:14 PM, Vladisav Jelisavcic <
>> [hidden email]> wrote:
>>
>>> Hi Tim,
>>>
>>> thank you for the contribution!
>>> I'll do the review soon and let you know.
>>>
>>>
>>>
>>> On Wed, Jan 17, 2018 at 8:56 AM, Yakov Zhdanov <[hidden email]>
>>> wrote:
>>>
>>>> Thanks Tim! I hope Vlad can review your patch. If this does not happen
>>>> in
>>>> 2-3 days I will take a look. Can you please let me know on weekend if I
>>>> need to?
>>>>
>>>> --Yakov
>>>>
>>>> 2018-01-16 23:36 GMT+03:00 Tim Onyschak <[hidden email]>:
>>>>
>>>> > Hey all,
>>>> >
>>>> > I created a patch and posted to user group, was told feed back would
>>>> be
>>>> > left on the jira. I wanted to see if we could get a fix in with 2.4,
>>>> could
>>>> > somebody please review.
>>>> >
>>>> > http://apache-ignite-users.70518.x6.nabble.com/Semaphore-
>>>> > Stuck-when-no-acquirers-to-assign-permit-td18639.html
>>>> >
>>>> > https://issues.apache.org/jira/browse/IGNITE-7090
>>>> >
>>>> > https://github.com/apache/ignite/pull/3138
>>>> >
>>>> > Thanks,
>>>> > Tim
>>>> >
>>>>
>>>
>>>
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: Ignite Semaphore Bug 7090

Vladisav Jelisavcic
Hi Tim,

thank you for delving deeper into the problem,
I left you a comment/question on the JIRA.

Best regards,
Vladisav

On Tue, Jan 23, 2018 at 3:00 PM, Vladisav Jelisavcic <[hidden email]>
wrote:

> Hi Tim,
>
> thanks for the update! I left you a comment on Jira.
>
> Best regards,
> Vladisav
>
> On Mon, Jan 22, 2018 at 6:17 PM, Tim Onyschak <[hidden email]> wrote:
>
>> Hey Vladisav,
>>
>> I implemented your requests. Take a look, specifically, i created an
>> interface to encapsulate the NodeUpdates and let
>> the DataStructuresProcessor handle the execution by checking for one type
>> as opposed to multiple if checks. In this case it checks for GridCacheNodeUpdate
>> instance and executes onNodeRemoved. Let me know what you think.
>>
>> Thanks,
>> Tim
>>
>>
>>
>> On Sat, Jan 20, 2018 at 8:10 AM, Vladisav Jelisavcic <[hidden email]
>> > wrote:
>>
>>> Hi Tim,
>>>
>>> I reviewed your contribution and left you some comments on the pr.
>>> Thanks!
>>>
>>> Vladisav
>>>
>>> On Wed, Jan 17, 2018 at 10:14 PM, Vladisav Jelisavcic <
>>> [hidden email]> wrote:
>>>
>>>> Hi Tim,
>>>>
>>>> thank you for the contribution!
>>>> I'll do the review soon and let you know.
>>>>
>>>>
>>>>
>>>> On Wed, Jan 17, 2018 at 8:56 AM, Yakov Zhdanov <[hidden email]>
>>>> wrote:
>>>>
>>>>> Thanks Tim! I hope Vlad can review your patch. If this does not happen
>>>>> in
>>>>> 2-3 days I will take a look. Can you please let me know on weekend if I
>>>>> need to?
>>>>>
>>>>> --Yakov
>>>>>
>>>>> 2018-01-16 23:36 GMT+03:00 Tim Onyschak <[hidden email]>:
>>>>>
>>>>> > Hey all,
>>>>> >
>>>>> > I created a patch and posted to user group, was told feed back would
>>>>> be
>>>>> > left on the jira. I wanted to see if we could get a fix in with 2.4,
>>>>> could
>>>>> > somebody please review.
>>>>> >
>>>>> > http://apache-ignite-users.70518.x6.nabble.com/Semaphore-
>>>>> > Stuck-when-no-acquirers-to-assign-permit-td18639.html
>>>>> >
>>>>> > https://issues.apache.org/jira/browse/IGNITE-7090
>>>>> >
>>>>> > https://github.com/apache/ignite/pull/3138
>>>>> >
>>>>> > Thanks,
>>>>> > Tim
>>>>> >
>>>>>
>>>>
>>>>
>>>
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: Ignite Semaphore Bug 7090

yzhdanov
Vlad and Tim, thanks for working on this!

Tim, please assign ticket to yourself to follow community process.
Currently I see it is unassigned.

--Yakov

2018-01-25 8:53 GMT-08:00 Vladisav Jelisavcic <[hidden email]>:

> Hi Tim,
>
> thank you for delving deeper into the problem,
> I left you a comment/question on the JIRA.
>
> Best regards,
> Vladisav
>
> On Tue, Jan 23, 2018 at 3:00 PM, Vladisav Jelisavcic <[hidden email]>
> wrote:
>
> > Hi Tim,
> >
> > thanks for the update! I left you a comment on Jira.
> >
> > Best regards,
> > Vladisav
> >
> > On Mon, Jan 22, 2018 at 6:17 PM, Tim Onyschak <[hidden email]>
> wrote:
> >
> >> Hey Vladisav,
> >>
> >> I implemented your requests. Take a look, specifically, i created an
> >> interface to encapsulate the NodeUpdates and let
> >> the DataStructuresProcessor handle the execution by checking for one
> type
> >> as opposed to multiple if checks. In this case it checks for
> GridCacheNodeUpdate
> >> instance and executes onNodeRemoved. Let me know what you think.
> >>
> >> Thanks,
> >> Tim
> >>
> >>
> >>
> >> On Sat, Jan 20, 2018 at 8:10 AM, Vladisav Jelisavcic <
> [hidden email]
> >> > wrote:
> >>
> >>> Hi Tim,
> >>>
> >>> I reviewed your contribution and left you some comments on the pr.
> >>> Thanks!
> >>>
> >>> Vladisav
> >>>
> >>> On Wed, Jan 17, 2018 at 10:14 PM, Vladisav Jelisavcic <
> >>> [hidden email]> wrote:
> >>>
> >>>> Hi Tim,
> >>>>
> >>>> thank you for the contribution!
> >>>> I'll do the review soon and let you know.
> >>>>
> >>>>
> >>>>
> >>>> On Wed, Jan 17, 2018 at 8:56 AM, Yakov Zhdanov <[hidden email]>
> >>>> wrote:
> >>>>
> >>>>> Thanks Tim! I hope Vlad can review your patch. If this does not
> happen
> >>>>> in
> >>>>> 2-3 days I will take a look. Can you please let me know on weekend
> if I
> >>>>> need to?
> >>>>>
> >>>>> --Yakov
> >>>>>
> >>>>> 2018-01-16 23:36 GMT+03:00 Tim Onyschak <[hidden email]>:
> >>>>>
> >>>>> > Hey all,
> >>>>> >
> >>>>> > I created a patch and posted to user group, was told feed back
> would
> >>>>> be
> >>>>> > left on the jira. I wanted to see if we could get a fix in with
> 2.4,
> >>>>> could
> >>>>> > somebody please review.
> >>>>> >
> >>>>> > http://apache-ignite-users.70518.x6.nabble.com/Semaphore-
> >>>>> > Stuck-when-no-acquirers-to-assign-permit-td18639.html
> >>>>> >
> >>>>> > https://issues.apache.org/jira/browse/IGNITE-7090
> >>>>> >
> >>>>> > https://github.com/apache/ignite/pull/3138
> >>>>> >
> >>>>> > Thanks,
> >>>>> > Tim
> >>>>> >
> >>>>>
> >>>>
> >>>>
> >>>
> >>
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Ignite Semaphore Bug 7090

Timay
It does not look like i have permissions to assign tickets. I'll gladly
take it, if somebody can assign it to me.

Also, Vlad i updated the ticket with my comment as well.


On Thu, Jan 25, 2018 at 7:44 PM, Yakov Zhdanov <[hidden email]> wrote:

> Vlad and Tim, thanks for working on this!
>
> Tim, please assign ticket to yourself to follow community process.
> Currently I see it is unassigned.
>
> --Yakov
>
> 2018-01-25 8:53 GMT-08:00 Vladisav Jelisavcic <[hidden email]>:
>
>> Hi Tim,
>>
>> thank you for delving deeper into the problem,
>> I left you a comment/question on the JIRA.
>>
>> Best regards,
>> Vladisav
>>
>> On Tue, Jan 23, 2018 at 3:00 PM, Vladisav Jelisavcic <[hidden email]
>> >
>> wrote:
>>
>> > Hi Tim,
>> >
>> > thanks for the update! I left you a comment on Jira.
>> >
>> > Best regards,
>> > Vladisav
>> >
>> > On Mon, Jan 22, 2018 at 6:17 PM, Tim Onyschak <[hidden email]>
>> wrote:
>> >
>> >> Hey Vladisav,
>> >>
>> >> I implemented your requests. Take a look, specifically, i created an
>> >> interface to encapsulate the NodeUpdates and let
>> >> the DataStructuresProcessor handle the execution by checking for one
>> type
>> >> as opposed to multiple if checks. In this case it checks for
>> GridCacheNodeUpdate
>> >> instance and executes onNodeRemoved. Let me know what you think.
>> >>
>> >> Thanks,
>> >> Tim
>> >>
>> >>
>> >>
>> >> On Sat, Jan 20, 2018 at 8:10 AM, Vladisav Jelisavcic <
>> [hidden email]
>> >> > wrote:
>> >>
>> >>> Hi Tim,
>> >>>
>> >>> I reviewed your contribution and left you some comments on the pr.
>> >>> Thanks!
>> >>>
>> >>> Vladisav
>> >>>
>> >>> On Wed, Jan 17, 2018 at 10:14 PM, Vladisav Jelisavcic <
>> >>> [hidden email]> wrote:
>> >>>
>> >>>> Hi Tim,
>> >>>>
>> >>>> thank you for the contribution!
>> >>>> I'll do the review soon and let you know.
>> >>>>
>> >>>>
>> >>>>
>> >>>> On Wed, Jan 17, 2018 at 8:56 AM, Yakov Zhdanov <[hidden email]>
>> >>>> wrote:
>> >>>>
>> >>>>> Thanks Tim! I hope Vlad can review your patch. If this does not
>> happen
>> >>>>> in
>> >>>>> 2-3 days I will take a look. Can you please let me know on weekend
>> if I
>> >>>>> need to?
>> >>>>>
>> >>>>> --Yakov
>> >>>>>
>> >>>>> 2018-01-16 23:36 GMT+03:00 Tim Onyschak <[hidden email]>:
>> >>>>>
>> >>>>> > Hey all,
>> >>>>> >
>> >>>>> > I created a patch and posted to user group, was told feed back
>> would
>> >>>>> be
>> >>>>> > left on the jira. I wanted to see if we could get a fix in with
>> 2.4,
>> >>>>> could
>> >>>>> > somebody please review.
>> >>>>> >
>> >>>>> > http://apache-ignite-users.70518.x6.nabble.com/Semaphore-
>> >>>>> > Stuck-when-no-acquirers-to-assign-permit-td18639.html
>> >>>>> >
>> >>>>> > https://issues.apache.org/jira/browse/IGNITE-7090
>> >>>>> >
>> >>>>> > https://github.com/apache/ignite/pull/3138
>> >>>>> >
>> >>>>> > Thanks,
>> >>>>> > Tim
>> >>>>> >
>> >>>>>
>> >>>>
>> >>>>
>> >>>
>> >>
>> >
>>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Ignite Semaphore Bug 7090

dsetrakyan
Tim, can you please send your Apache Jira ID here, so I could add you as
Ignite contributor?

On Thu, Jan 25, 2018 at 6:02 PM, Tim Onyschak <[hidden email]> wrote:

> It does not look like i have permissions to assign tickets. I'll gladly
> take it, if somebody can assign it to me.
>
> Also, Vlad i updated the ticket with my comment as well.
>
>
> On Thu, Jan 25, 2018 at 7:44 PM, Yakov Zhdanov <[hidden email]>
> wrote:
>
> > Vlad and Tim, thanks for working on this!
> >
> > Tim, please assign ticket to yourself to follow community process.
> > Currently I see it is unassigned.
> >
> > --Yakov
> >
> > 2018-01-25 8:53 GMT-08:00 Vladisav Jelisavcic <[hidden email]>:
> >
> >> Hi Tim,
> >>
> >> thank you for delving deeper into the problem,
> >> I left you a comment/question on the JIRA.
> >>
> >> Best regards,
> >> Vladisav
> >>
> >> On Tue, Jan 23, 2018 at 3:00 PM, Vladisav Jelisavcic <
> [hidden email]
> >> >
> >> wrote:
> >>
> >> > Hi Tim,
> >> >
> >> > thanks for the update! I left you a comment on Jira.
> >> >
> >> > Best regards,
> >> > Vladisav
> >> >
> >> > On Mon, Jan 22, 2018 at 6:17 PM, Tim Onyschak <[hidden email]>
> >> wrote:
> >> >
> >> >> Hey Vladisav,
> >> >>
> >> >> I implemented your requests. Take a look, specifically, i created an
> >> >> interface to encapsulate the NodeUpdates and let
> >> >> the DataStructuresProcessor handle the execution by checking for one
> >> type
> >> >> as opposed to multiple if checks. In this case it checks for
> >> GridCacheNodeUpdate
> >> >> instance and executes onNodeRemoved. Let me know what you think.
> >> >>
> >> >> Thanks,
> >> >> Tim
> >> >>
> >> >>
> >> >>
> >> >> On Sat, Jan 20, 2018 at 8:10 AM, Vladisav Jelisavcic <
> >> [hidden email]
> >> >> > wrote:
> >> >>
> >> >>> Hi Tim,
> >> >>>
> >> >>> I reviewed your contribution and left you some comments on the pr.
> >> >>> Thanks!
> >> >>>
> >> >>> Vladisav
> >> >>>
> >> >>> On Wed, Jan 17, 2018 at 10:14 PM, Vladisav Jelisavcic <
> >> >>> [hidden email]> wrote:
> >> >>>
> >> >>>> Hi Tim,
> >> >>>>
> >> >>>> thank you for the contribution!
> >> >>>> I'll do the review soon and let you know.
> >> >>>>
> >> >>>>
> >> >>>>
> >> >>>> On Wed, Jan 17, 2018 at 8:56 AM, Yakov Zhdanov <
> [hidden email]>
> >> >>>> wrote:
> >> >>>>
> >> >>>>> Thanks Tim! I hope Vlad can review your patch. If this does not
> >> happen
> >> >>>>> in
> >> >>>>> 2-3 days I will take a look. Can you please let me know on weekend
> >> if I
> >> >>>>> need to?
> >> >>>>>
> >> >>>>> --Yakov
> >> >>>>>
> >> >>>>> 2018-01-16 23:36 GMT+03:00 Tim Onyschak <[hidden email]>:
> >> >>>>>
> >> >>>>> > Hey all,
> >> >>>>> >
> >> >>>>> > I created a patch and posted to user group, was told feed back
> >> would
> >> >>>>> be
> >> >>>>> > left on the jira. I wanted to see if we could get a fix in with
> >> 2.4,
> >> >>>>> could
> >> >>>>> > somebody please review.
> >> >>>>> >
> >> >>>>> > http://apache-ignite-users.70518.x6.nabble.com/Semaphore-
> >> >>>>> > Stuck-when-no-acquirers-to-assign-permit-td18639.html
> >> >>>>> >
> >> >>>>> > https://issues.apache.org/jira/browse/IGNITE-7090
> >> >>>>> >
> >> >>>>> > https://github.com/apache/ignite/pull/3138
> >> >>>>> >
> >> >>>>> > Thanks,
> >> >>>>> > Tim
> >> >>>>> >
> >> >>>>>
> >> >>>>
> >> >>>>
> >> >>>
> >> >>
> >> >
> >>
> >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Ignite Semaphore Bug 7090

Timay
Jira Username: Timay

On Sat, Jan 27, 2018 at 1:43 AM, Dmitriy Setrakyan <[hidden email]>
wrote:

> Tim, can you please send your Apache Jira ID here, so I could add you as
> Ignite contributor?
>
> On Thu, Jan 25, 2018 at 6:02 PM, Tim Onyschak <[hidden email]> wrote:
>
>> It does not look like i have permissions to assign tickets. I'll gladly
>> take it, if somebody can assign it to me.
>>
>> Also, Vlad i updated the ticket with my comment as well.
>>
>>
>> On Thu, Jan 25, 2018 at 7:44 PM, Yakov Zhdanov <[hidden email]>
>> wrote:
>>
>> > Vlad and Tim, thanks for working on this!
>> >
>> > Tim, please assign ticket to yourself to follow community process.
>> > Currently I see it is unassigned.
>> >
>> > --Yakov
>> >
>> > 2018-01-25 8:53 GMT-08:00 Vladisav Jelisavcic <[hidden email]>:
>> >
>> >> Hi Tim,
>> >>
>> >> thank you for delving deeper into the problem,
>> >> I left you a comment/question on the JIRA.
>> >>
>> >> Best regards,
>> >> Vladisav
>> >>
>> >> On Tue, Jan 23, 2018 at 3:00 PM, Vladisav Jelisavcic <
>> [hidden email]
>> >> >
>> >> wrote:
>> >>
>> >> > Hi Tim,
>> >> >
>> >> > thanks for the update! I left you a comment on Jira.
>> >> >
>> >> > Best regards,
>> >> > Vladisav
>> >> >
>> >> > On Mon, Jan 22, 2018 at 6:17 PM, Tim Onyschak <[hidden email]>
>> >> wrote:
>> >> >
>> >> >> Hey Vladisav,
>> >> >>
>> >> >> I implemented your requests. Take a look, specifically, i created an
>> >> >> interface to encapsulate the NodeUpdates and let
>> >> >> the DataStructuresProcessor handle the execution by checking for one
>> >> type
>> >> >> as opposed to multiple if checks. In this case it checks for
>> >> GridCacheNodeUpdate
>> >> >> instance and executes onNodeRemoved. Let me know what you think.
>> >> >>
>> >> >> Thanks,
>> >> >> Tim
>> >> >>
>> >> >>
>> >> >>
>> >> >> On Sat, Jan 20, 2018 at 8:10 AM, Vladisav Jelisavcic <
>> >> [hidden email]
>> >> >> > wrote:
>> >> >>
>> >> >>> Hi Tim,
>> >> >>>
>> >> >>> I reviewed your contribution and left you some comments on the pr.
>> >> >>> Thanks!
>> >> >>>
>> >> >>> Vladisav
>> >> >>>
>> >> >>> On Wed, Jan 17, 2018 at 10:14 PM, Vladisav Jelisavcic <
>> >> >>> [hidden email]> wrote:
>> >> >>>
>> >> >>>> Hi Tim,
>> >> >>>>
>> >> >>>> thank you for the contribution!
>> >> >>>> I'll do the review soon and let you know.
>> >> >>>>
>> >> >>>>
>> >> >>>>
>> >> >>>> On Wed, Jan 17, 2018 at 8:56 AM, Yakov Zhdanov <
>> [hidden email]>
>> >> >>>> wrote:
>> >> >>>>
>> >> >>>>> Thanks Tim! I hope Vlad can review your patch. If this does not
>> >> happen
>> >> >>>>> in
>> >> >>>>> 2-3 days I will take a look. Can you please let me know on
>> weekend
>> >> if I
>> >> >>>>> need to?
>> >> >>>>>
>> >> >>>>> --Yakov
>> >> >>>>>
>> >> >>>>> 2018-01-16 23:36 GMT+03:00 Tim Onyschak <[hidden email]>:
>> >> >>>>>
>> >> >>>>> > Hey all,
>> >> >>>>> >
>> >> >>>>> > I created a patch and posted to user group, was told feed back
>> >> would
>> >> >>>>> be
>> >> >>>>> > left on the jira. I wanted to see if we could get a fix in with
>> >> 2.4,
>> >> >>>>> could
>> >> >>>>> > somebody please review.
>> >> >>>>> >
>> >> >>>>> > http://apache-ignite-users.70518.x6.nabble.com/Semaphore-
>> >> >>>>> > Stuck-when-no-acquirers-to-assign-permit-td18639.html
>> >> >>>>> >
>> >> >>>>> > https://issues.apache.org/jira/browse/IGNITE-7090
>> >> >>>>> >
>> >> >>>>> > https://github.com/apache/ignite/pull/3138
>> >> >>>>> >
>> >> >>>>> > Thanks,
>> >> >>>>> > Tim
>> >> >>>>> >
>> >> >>>>>
>> >> >>>>
>> >> >>>>
>> >> >>>
>> >> >>
>> >> >
>> >>
>> >
>> >
>>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Ignite Semaphore Bug 7090

dsetrakyan
Tim, I added you as Ignite contributor. You can assign tickets to yourself
now.

On Sun, Jan 28, 2018 at 5:24 PM, Tim Onyschak <[hidden email]> wrote:

> Jira Username: Timay
>
> On Sat, Jan 27, 2018 at 1:43 AM, Dmitriy Setrakyan <[hidden email]>
> wrote:
>
>> Tim, can you please send your Apache Jira ID here, so I could add you as
>> Ignite contributor?
>>
>> On Thu, Jan 25, 2018 at 6:02 PM, Tim Onyschak <[hidden email]>
>> wrote:
>>
>>> It does not look like i have permissions to assign tickets. I'll gladly
>>> take it, if somebody can assign it to me.
>>>
>>> Also, Vlad i updated the ticket with my comment as well.
>>>
>>>
>>> On Thu, Jan 25, 2018 at 7:44 PM, Yakov Zhdanov <[hidden email]>
>>> wrote:
>>>
>>> > Vlad and Tim, thanks for working on this!
>>> >
>>> > Tim, please assign ticket to yourself to follow community process.
>>> > Currently I see it is unassigned.
>>> >
>>> > --Yakov
>>> >
>>> > 2018-01-25 8:53 GMT-08:00 Vladisav Jelisavcic <[hidden email]>:
>>> >
>>> >> Hi Tim,
>>> >>
>>> >> thank you for delving deeper into the problem,
>>> >> I left you a comment/question on the JIRA.
>>> >>
>>> >> Best regards,
>>> >> Vladisav
>>> >>
>>> >> On Tue, Jan 23, 2018 at 3:00 PM, Vladisav Jelisavcic <
>>> [hidden email]
>>> >> >
>>> >> wrote:
>>> >>
>>> >> > Hi Tim,
>>> >> >
>>> >> > thanks for the update! I left you a comment on Jira.
>>> >> >
>>> >> > Best regards,
>>> >> > Vladisav
>>> >> >
>>> >> > On Mon, Jan 22, 2018 at 6:17 PM, Tim Onyschak <[hidden email]>
>>> >> wrote:
>>> >> >
>>> >> >> Hey Vladisav,
>>> >> >>
>>> >> >> I implemented your requests. Take a look, specifically, i created
>>> an
>>> >> >> interface to encapsulate the NodeUpdates and let
>>> >> >> the DataStructuresProcessor handle the execution by checking for
>>> one
>>> >> type
>>> >> >> as opposed to multiple if checks. In this case it checks for
>>> >> GridCacheNodeUpdate
>>> >> >> instance and executes onNodeRemoved. Let me know what you think.
>>> >> >>
>>> >> >> Thanks,
>>> >> >> Tim
>>> >> >>
>>> >> >>
>>> >> >>
>>> >> >> On Sat, Jan 20, 2018 at 8:10 AM, Vladisav Jelisavcic <
>>> >> [hidden email]
>>> >> >> > wrote:
>>> >> >>
>>> >> >>> Hi Tim,
>>> >> >>>
>>> >> >>> I reviewed your contribution and left you some comments on the pr.
>>> >> >>> Thanks!
>>> >> >>>
>>> >> >>> Vladisav
>>> >> >>>
>>> >> >>> On Wed, Jan 17, 2018 at 10:14 PM, Vladisav Jelisavcic <
>>> >> >>> [hidden email]> wrote:
>>> >> >>>
>>> >> >>>> Hi Tim,
>>> >> >>>>
>>> >> >>>> thank you for the contribution!
>>> >> >>>> I'll do the review soon and let you know.
>>> >> >>>>
>>> >> >>>>
>>> >> >>>>
>>> >> >>>> On Wed, Jan 17, 2018 at 8:56 AM, Yakov Zhdanov <
>>> [hidden email]>
>>> >> >>>> wrote:
>>> >> >>>>
>>> >> >>>>> Thanks Tim! I hope Vlad can review your patch. If this does not
>>> >> happen
>>> >> >>>>> in
>>> >> >>>>> 2-3 days I will take a look. Can you please let me know on
>>> weekend
>>> >> if I
>>> >> >>>>> need to?
>>> >> >>>>>
>>> >> >>>>> --Yakov
>>> >> >>>>>
>>> >> >>>>> 2018-01-16 23:36 GMT+03:00 Tim Onyschak <[hidden email]>:
>>> >> >>>>>
>>> >> >>>>> > Hey all,
>>> >> >>>>> >
>>> >> >>>>> > I created a patch and posted to user group, was told feed back
>>> >> would
>>> >> >>>>> be
>>> >> >>>>> > left on the jira. I wanted to see if we could get a fix in
>>> with
>>> >> 2.4,
>>> >> >>>>> could
>>> >> >>>>> > somebody please review.
>>> >> >>>>> >
>>> >> >>>>> > http://apache-ignite-users.70518.x6.nabble.com/Semaphore-
>>> >> >>>>> > Stuck-when-no-acquirers-to-assign-permit-td18639.html
>>> >> >>>>> >
>>> >> >>>>> > https://issues.apache.org/jira/browse/IGNITE-7090
>>> >> >>>>> >
>>> >> >>>>> > https://github.com/apache/ignite/pull/3138
>>> >> >>>>> >
>>> >> >>>>> > Thanks,
>>> >> >>>>> > Tim
>>> >> >>>>> >
>>> >> >>>>>
>>> >> >>>>
>>> >> >>>>
>>> >> >>>
>>> >> >>
>>> >> >
>>> >>
>>> >
>>> >
>>>
>>
>>
>