Ignite Maven project version number

classic Classic list List threaded Threaded
22 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: Ignite Maven project version number

Anton Vinogradov
Igor,


> Well, it's all about how to minimize copy-pasting parent version to
> constantly growing amount of module POMs while switching to development of
> new version.

Don't worry about it, currently we use bash script to do that, it based
on release:update-versions, and it will be relocated to Apache Ignite
Teamcity in the nearest future.

I executed tests for my pull request and here are the results:
> http://149.202.210.143:8111/viewLog.html?buildId=301277&
> tab=buildResultsDiv&buildTypeId=IgniteTests_RunAll

I see a lot of new failures with ClassNotFoundException.

Thus the main question is - if there are any specific cases for using "1".
> as a version number in parent POM?

I set it to 1, because we never release it to maven and parent pom located
at same project that other poms. At this moment no reason to change it from
release to release.




On Fri, Aug 19, 2016 at 9:20 AM, Alexey Kuznetsov <[hidden email]>
wrote:

> Igor, Raul and Anton.
>
> As far as I remember we decided to have version in each module pom because
> of some problem with maven release.
>
> So, we ALSO NEED CHECK RELEASE PROCEDURE and see will new approach work or
> not.
>
> --
> Alexey Kuznetsov
> GridGain Systems
> www.gridgain.com
>
Reply | Threaded
Open this post in threaded view
|

Re: Ignite Maven project version number

Sergi
I'm not a Maven expert and do not see all the consequences, but so far
everything worked well. Why change it? Especially if we do not have a
consensus in our community. I think we can't accept this change until
everyone agrees.

Sergi


2016-08-19 10:28 GMT+03:00 Anton Vinogradov <[hidden email]>:

> Igor,
>
>
> > Well, it's all about how to minimize copy-pasting parent version to
> > constantly growing amount of module POMs while switching to development
> of
> > new version.
>
> Don't worry about it, currently we use bash script to do that, it based
> on release:update-versions, and it will be relocated to Apache Ignite
> Teamcity in the nearest future.
>
> I executed tests for my pull request and here are the results:
> > http://149.202.210.143:8111/viewLog.html?buildId=301277&
> > tab=buildResultsDiv&buildTypeId=IgniteTests_RunAll
>
> I see a lot of new failures with ClassNotFoundException.
>
> Thus the main question is - if there are any specific cases for using "1".
> > as a version number in parent POM?
>
> I set it to 1, because we never release it to maven and parent pom located
> at same project that other poms. At this moment no reason to change it from
> release to release.
>
>
>
>
> On Fri, Aug 19, 2016 at 9:20 AM, Alexey Kuznetsov <[hidden email]
> >
> wrote:
>
> > Igor, Raul and Anton.
> >
> > As far as I remember we decided to have version in each module pom
> because
> > of some problem with maven release.
> >
> > So, we ALSO NEED CHECK RELEASE PROCEDURE and see will new approach work
> or
> > not.
> >
> > --
> > Alexey Kuznetsov
> > GridGain Systems
> > www.gridgain.com
> >
>
12