Ignite-4795 - ready for review

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Ignite-4795 - ready for review

Dmitrii Ryabov
Hello, community. Please, review and/or suggest something about javadocs of
transactions.

PR: https://github.com/apache/ignite/pull/1630/files

JIRA: https://issues.apache.org/jira/browse/IGNITE-4795
Reply | Threaded
Open this post in threaded view
|

Re: Ignite-4795 - ready for review

Антон Чураев
Dmitry, thank you!

Could you please also change issue status to "Patch available".

2017-03-20 16:01 GMT+03:00 Дмитрий Рябов <[hidden email]>:

> Hello, community. Please, review and/or suggest something about javadocs of
> transactions.
>
> PR: https://github.com/apache/ignite/pull/1630/files
>
> JIRA: https://issues.apache.org/jira/browse/IGNITE-4795
>



--
С уважением,
Чураев Антон
Reply | Threaded
Open this post in threaded view
|

Re: Ignite-4795 - ready for review

Dmitrii Ryabov
Done.

2017-03-20 16:30 GMT+03:00 Антон Чураев <[hidden email]>:

> Dmitry, thank you!
>
> Could you please also change issue status to "Patch available".
>
> 2017-03-20 16:01 GMT+03:00 Дмитрий Рябов <[hidden email]>:
>
> > Hello, community. Please, review and/or suggest something about javadocs
> of
> > transactions.
> >
> > PR: https://github.com/apache/ignite/pull/1630/files
> >
> > JIRA: https://issues.apache.org/jira/browse/IGNITE-4795
> >
>
>
>
> --
> С уважением,
> Чураев Антон
>
Reply | Threaded
Open this post in threaded view
|

Re: Ignite-4795 - ready for review

Dmitrii Ryabov
Hello, can anyone review this issue?

2017-03-20 16:33 GMT+03:00 Дмитрий Рябов <[hidden email]>:

> Done.
>
> 2017-03-20 16:30 GMT+03:00 Антон Чураев <[hidden email]>:
>
>> Dmitry, thank you!
>>
>> Could you please also change issue status to "Patch available".
>>
>> 2017-03-20 16:01 GMT+03:00 Дмитрий Рябов <[hidden email]>:
>>
>> > Hello, community. Please, review and/or suggest something about
>> javadocs of
>> > transactions.
>> >
>> > PR: https://github.com/apache/ignite/pull/1630/files
>> >
>> > JIRA: https://issues.apache.org/jira/browse/IGNITE-4795
>> >
>>
>>
>>
>> --
>> С уважением,
>> Чураев Антон
>>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Ignite-4795 - ready for review

dmagda
Hello Dmitriy, thanks! Someone will have a look at your changes soon. Sorry for the delay.


Denis

> On Mar 27, 2017, at 3:24 AM, Дмитрий Рябов <[hidden email]> wrote:
>
> Hello, can anyone review this issue?
>
> 2017-03-20 16:33 GMT+03:00 Дмитрий Рябов <[hidden email]>:
>
>> Done.
>>
>> 2017-03-20 16:30 GMT+03:00 Антон Чураев <[hidden email]>:
>>
>>> Dmitry, thank you!
>>>
>>> Could you please also change issue status to "Patch available".
>>>
>>> 2017-03-20 16:01 GMT+03:00 Дмитрий Рябов <[hidden email]>:
>>>
>>>> Hello, community. Please, review and/or suggest something about
>>> javadocs of
>>>> transactions.
>>>>
>>>> PR: https://github.com/apache/ignite/pull/1630/files
>>>>
>>>> JIRA: https://issues.apache.org/jira/browse/IGNITE-4795
>>>>
>>>
>>>
>>>
>>> --
>>> С уважением,
>>> Чураев Антон
>>>
>>
>>

Reply | Threaded
Open this post in threaded view
|

Re: Ignite-4795 - ready for review

agura
Dmitry, see JIRA ticket for review comments.

On Mon, Mar 27, 2017 at 6:13 PM, Denis Magda <[hidden email]> wrote:

> Hello Dmitriy, thanks! Someone will have a look at your changes soon. Sorry for the delay.
>
> —
> Denis
>
>> On Mar 27, 2017, at 3:24 AM, Дмитрий Рябов <[hidden email]> wrote:
>>
>> Hello, can anyone review this issue?
>>
>> 2017-03-20 16:33 GMT+03:00 Дмитрий Рябов <[hidden email]>:
>>
>>> Done.
>>>
>>> 2017-03-20 16:30 GMT+03:00 Антон Чураев <[hidden email]>:
>>>
>>>> Dmitry, thank you!
>>>>
>>>> Could you please also change issue status to "Patch available".
>>>>
>>>> 2017-03-20 16:01 GMT+03:00 Дмитрий Рябов <[hidden email]>:
>>>>
>>>>> Hello, community. Please, review and/or suggest something about
>>>> javadocs of
>>>>> transactions.
>>>>>
>>>>> PR: https://github.com/apache/ignite/pull/1630/files
>>>>>
>>>>> JIRA: https://issues.apache.org/jira/browse/IGNITE-4795
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> С уважением,
>>>> Чураев Антон
>>>>
>>>
>>>
>
Reply | Threaded
Open this post in threaded view
|

Re: Ignite-4795 - ready for review

Dmitrii Ryabov
Andrey, I made fix, can you look it again?

2017-03-28 20:40 GMT+03:00 Andrey Gura <[hidden email]>:

> Dmitry, see JIRA ticket for review comments.
>
> On Mon, Mar 27, 2017 at 6:13 PM, Denis Magda <[hidden email]> wrote:
> > Hello Dmitriy, thanks! Someone will have a look at your changes soon.
> Sorry for the delay.
> >
> > —
> > Denis
> >
> >> On Mar 27, 2017, at 3:24 AM, Дмитрий Рябов <[hidden email]>
> wrote:
> >>
> >> Hello, can anyone review this issue?
> >>
> >> 2017-03-20 16:33 GMT+03:00 Дмитрий Рябов <[hidden email]>:
> >>
> >>> Done.
> >>>
> >>> 2017-03-20 16:30 GMT+03:00 Антон Чураев <[hidden email]>:
> >>>
> >>>> Dmitry, thank you!
> >>>>
> >>>> Could you please also change issue status to "Patch available".
> >>>>
> >>>> 2017-03-20 16:01 GMT+03:00 Дмитрий Рябов <[hidden email]>:
> >>>>
> >>>>> Hello, community. Please, review and/or suggest something about
> >>>> javadocs of
> >>>>> transactions.
> >>>>>
> >>>>> PR: https://github.com/apache/ignite/pull/1630/files
> >>>>>
> >>>>> JIRA: https://issues.apache.org/jira/browse/IGNITE-4795
> >>>>>
> >>>>
> >>>>
> >>>>
> >>>> --
> >>>> С уважением,
> >>>> Чураев Антон
> >>>>
> >>>
> >>>
> >
>