Ignite-4795 - ready for review (Inherit TransactionException and update Javadoc)

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Ignite-4795 - ready for review (Inherit TransactionException and update Javadoc)

Dmitrii Ryabov
Reply | Threaded
Open this post in threaded view
|

Re: Ignite-4795 - ready for review (Inherit TransactionException and update Javadoc)

agura
Dmitry,

this review is in progress. But I'm confused about PR number because
in JIRA ticket we discussed PR 1631. What is actual PR number for
latest changes?

On Mon, Apr 10, 2017 at 11:38 AM, Дмитрий Рябов <[hidden email]> wrote:
> Hello, igniters. Please, review.
>
> PR: https://github.com/apache/ignite/pull/1630/files
>
> JIRA: https://issues.apache.org/jira/browse/IGNITE-4795
Reply | Threaded
Open this post in threaded view
|

Re: Ignite-4795 - ready for review (Inherit TransactionException and update Javadoc)

Dmitrii Ryabov
Andrey, actual PR is 1630. PR 1631 was created by mistake and I closed it
immediately after creating (couse ticket must have only 1 PR, isn't it?).
So ticket has only one attached link to "GitHub Pull Request #1630".

2017-04-10 14:24 GMT+03:00 Andrey Gura <[hidden email]>:

> Dmitry,
>
> this review is in progress. But I'm confused about PR number because
> in JIRA ticket we discussed PR 1631. What is actual PR number for
> latest changes?
>
> On Mon, Apr 10, 2017 at 11:38 AM, Дмитрий Рябов <[hidden email]>
> wrote:
> > Hello, igniters. Please, review.
> >
> > PR: https://github.com/apache/ignite/pull/1630/files
> >
> > JIRA: https://issues.apache.org/jira/browse/IGNITE-4795
>
Reply | Threaded
Open this post in threaded view
|

Re: Ignite-4795 - ready for review (Inherit TransactionException and update Javadoc)

agura
Thanks, Dmitry! I've reviewed your changes again and will merge it
after TC results.

On Mon, Apr 10, 2017 at 3:08 PM, Дмитрий Рябов <[hidden email]> wrote:

> Andrey, actual PR is 1630. PR 1631 was created by mistake and I closed it
> immediately after creating (couse ticket must have only 1 PR, isn't it?).
> So ticket has only one attached link to "GitHub Pull Request #1630".
>
> 2017-04-10 14:24 GMT+03:00 Andrey Gura <[hidden email]>:
>
>> Dmitry,
>>
>> this review is in progress. But I'm confused about PR number because
>> in JIRA ticket we discussed PR 1631. What is actual PR number for
>> latest changes?
>>
>> On Mon, Apr 10, 2017 at 11:38 AM, Дмитрий Рябов <[hidden email]>
>> wrote:
>> > Hello, igniters. Please, review.
>> >
>> > PR: https://github.com/apache/ignite/pull/1630/files
>> >
>> > JIRA: https://issues.apache.org/jira/browse/IGNITE-4795
>>
Reply | Threaded
Open this post in threaded view
|

Re: Ignite-4795 - ready for review (Inherit TransactionException and update Javadoc)

agura
Dmitry,

thanks a lot for your contribution. Changes are merged into master branch.

On Mon, Apr 10, 2017 at 7:07 PM, Andrey Gura <[hidden email]> wrote:

> Thanks, Dmitry! I've reviewed your changes again and will merge it
> after TC results.
>
> On Mon, Apr 10, 2017 at 3:08 PM, Дмитрий Рябов <[hidden email]> wrote:
>> Andrey, actual PR is 1630. PR 1631 was created by mistake and I closed it
>> immediately after creating (couse ticket must have only 1 PR, isn't it?).
>> So ticket has only one attached link to "GitHub Pull Request #1630".
>>
>> 2017-04-10 14:24 GMT+03:00 Andrey Gura <[hidden email]>:
>>
>>> Dmitry,
>>>
>>> this review is in progress. But I'm confused about PR number because
>>> in JIRA ticket we discussed PR 1631. What is actual PR number for
>>> latest changes?
>>>
>>> On Mon, Apr 10, 2017 at 11:38 AM, Дмитрий Рябов <[hidden email]>
>>> wrote:
>>> > Hello, igniters. Please, review.
>>> >
>>> > PR: https://github.com/apache/ignite/pull/1630/files
>>> >
>>> > JIRA: https://issues.apache.org/jira/browse/IGNITE-4795
>>>