Igniters,
Recently we've stumbled across the following two tickets [1], [2] which seem to be very critical from the usability and stability points of view. The [1] results in clients not being able to update persistence-enabled clusters unless the client configuration is identical to the server configuration. The [2] may result in incorrect node state recovery and either corrupted storage or lost updates. I suggest we make an emergency release (to my knowledge, we already had such a practice with Ignite 2.3) and include the fixes for both of the issues to it. Thoughts? [1] https://issues.apache.org/jira/browse/IGNITE-8476 [2] https://issues.apache.org/jira/browse/IGNITE-8685 --AG |
I agree in general. First issue is severe usability issue, while second
one may fail crash recovery and cause data loss. This makes AI 2.5 not recommended for using. Best Regards, Ivan Rakov On 05.06.2018 19:39, Alexey Goncharuk wrote: > Igniters, > > Recently we've stumbled across the following two tickets [1], [2] which > seem to be very critical from the usability and stability points of view. > The [1] results in clients not being able to update persistence-enabled > clusters unless the client configuration is identical to the server > configuration. The [2] may result in incorrect node state recovery and > either corrupted storage or lost updates. > > I suggest we make an emergency release (to my knowledge, we already had > such a practice with Ignite 2.3) and include the fixes for both of the > issues to it. > > Thoughts? > > [1] https://issues.apache.org/jira/browse/IGNITE-8476 > [2] https://issues.apache.org/jira/browse/IGNITE-8685 > > --AG > |
I'd like to add that first issue [1] has a follow-up fix [2]. It should
be backported along with the first fix. [1] - https://issues.apache.org/jira/browse/IGNITE-8476 [2] - https://issues.apache.org/jira/browse/IGNITE-8682 Best Regards, Ivan Rakov On 05.06.2018 20:57, Ivan Rakov wrote: > I agree in general. First issue is severe usability issue, while > second one may fail crash recovery and cause data loss. This makes AI > 2.5 not recommended for using. > > Best Regards, > Ivan Rakov > > On 05.06.2018 19:39, Alexey Goncharuk wrote: >> Igniters, >> >> Recently we've stumbled across the following two tickets [1], [2] which >> seem to be very critical from the usability and stability points of >> view. >> The [1] results in clients not being able to update persistence-enabled >> clusters unless the client configuration is identical to the server >> configuration. The [2] may result in incorrect node state recovery and >> either corrupted storage or lost updates. >> >> I suggest we make an emergency release (to my knowledge, we already had >> such a practice with Ignite 2.3) and include the fixes for both of the >> issues to it. >> >> Thoughts? >> >> [1] https://issues.apache.org/jira/browse/IGNITE-8476 >> [2] https://issues.apache.org/jira/browse/IGNITE-8685 >> >> --AG >> > |
Ignite-2.6 branch is created, all mentioned fixes were pushed. I also
included the fix for [1] because the issue could lead to a hanging PME in some circumstances. Will trigger TC shortly. [1] https://issues.apache.org/jira/browse/IGNITE-8530 вт, 5 июн. 2018 г. в 21:18, Ivan Rakov <[hidden email]>: > I'd like to add that first issue [1] has a follow-up fix [2]. It should > be backported along with the first fix. > > [1] - https://issues.apache.org/jira/browse/IGNITE-8476 > [2] - https://issues.apache.org/jira/browse/IGNITE-8682 > > Best Regards, > Ivan Rakov > > On 05.06.2018 20:57, Ivan Rakov wrote: > > I agree in general. First issue is severe usability issue, while > > second one may fail crash recovery and cause data loss. This makes AI > > 2.5 not recommended for using. > > > > Best Regards, > > Ivan Rakov > > > > On 05.06.2018 19:39, Alexey Goncharuk wrote: > >> Igniters, > >> > >> Recently we've stumbled across the following two tickets [1], [2] which > >> seem to be very critical from the usability and stability points of > >> view. > >> The [1] results in clients not being able to update persistence-enabled > >> clusters unless the client configuration is identical to the server > >> configuration. The [2] may result in incorrect node state recovery and > >> either corrupted storage or lost updates. > >> > >> I suggest we make an emergency release (to my knowledge, we already had > >> such a practice with Ignite 2.3) and include the fixes for both of the > >> issues to it. > >> > >> Thoughts? > >> > >> [1] https://issues.apache.org/jira/browse/IGNITE-8476 > >> [2] https://issues.apache.org/jira/browse/IGNITE-8685 > >> > >> --AG > >> > > > > |
Guys,
I have found an issue which could cause JVM Crash. https://issues.apache.org/jira/browse/IGNITE-8768 (JVM Crash on node stop or deactivate while async evict in progress). Another one could hang node or throw AssertionError when we try to recycle data pages: https://issues.apache.org/jira/browse/IGNITE-8769 I believe, that we should consider to include them. On Sat, Jun 9, 2018 at 11:29 PM, Alexey Goncharuk < [hidden email]> wrote: > Ignite-2.6 branch is created, all mentioned fixes were pushed. I also > included the fix for [1] because the issue could lead to a hanging PME in > some circumstances. > Will trigger TC shortly. > > [1] https://issues.apache.org/jira/browse/IGNITE-8530 > > вт, 5 июн. 2018 г. в 21:18, Ivan Rakov <[hidden email]>: > > > I'd like to add that first issue [1] has a follow-up fix [2]. It should > > be backported along with the first fix. > > > > [1] - https://issues.apache.org/jira/browse/IGNITE-8476 > > [2] - https://issues.apache.org/jira/browse/IGNITE-8682 > > > > Best Regards, > > Ivan Rakov > > > > On 05.06.2018 20:57, Ivan Rakov wrote: > > > I agree in general. First issue is severe usability issue, while > > > second one may fail crash recovery and cause data loss. This makes AI > > > 2.5 not recommended for using. > > > > > > Best Regards, > > > Ivan Rakov > > > > > > On 05.06.2018 19:39, Alexey Goncharuk wrote: > > >> Igniters, > > >> > > >> Recently we've stumbled across the following two tickets [1], [2] > which > > >> seem to be very critical from the usability and stability points of > > >> view. > > >> The [1] results in clients not being able to update > persistence-enabled > > >> clusters unless the client configuration is identical to the server > > >> configuration. The [2] may result in incorrect node state recovery and > > >> either corrupted storage or lost updates. > > >> > > >> I suggest we make an emergency release (to my knowledge, we already > had > > >> such a practice with Ignite 2.3) and include the fixes for both of the > > >> issues to it. > > >> > > >> Thoughts? > > >> > > >> [1] https://issues.apache.org/jira/browse/IGNITE-8476 > > >> [2] https://issues.apache.org/jira/browse/IGNITE-8685 > > >> > > >> --AG > > >> > > > > > > > > |
I agree with Eduard.
вс, 10 июн. 2018 г. в 13:22, Eduard Shangareev <[hidden email] >: > Guys, > > I have found an issue which could cause JVM Crash. > > https://issues.apache.org/jira/browse/IGNITE-8768 > (JVM Crash on node stop or deactivate while async evict in progress). > > Another one could hang node or throw AssertionError when we try to recycle > data pages: > https://issues.apache.org/jira/browse/IGNITE-8769 > > > I believe, that we should consider to include them. > > > > > > On Sat, Jun 9, 2018 at 11:29 PM, Alexey Goncharuk < > [hidden email]> wrote: > > > Ignite-2.6 branch is created, all mentioned fixes were pushed. I also > > included the fix for [1] because the issue could lead to a hanging PME in > > some circumstances. > > Will trigger TC shortly. > > > > [1] https://issues.apache.org/jira/browse/IGNITE-8530 > > > > вт, 5 июн. 2018 г. в 21:18, Ivan Rakov <[hidden email]>: > > > > > I'd like to add that first issue [1] has a follow-up fix [2]. It should > > > be backported along with the first fix. > > > > > > [1] - https://issues.apache.org/jira/browse/IGNITE-8476 > > > [2] - https://issues.apache.org/jira/browse/IGNITE-8682 > > > > > > Best Regards, > > > Ivan Rakov > > > > > > On 05.06.2018 20:57, Ivan Rakov wrote: > > > > I agree in general. First issue is severe usability issue, while > > > > second one may fail crash recovery and cause data loss. This makes AI > > > > 2.5 not recommended for using. > > > > > > > > Best Regards, > > > > Ivan Rakov > > > > > > > > On 05.06.2018 19:39, Alexey Goncharuk wrote: > > > >> Igniters, > > > >> > > > >> Recently we've stumbled across the following two tickets [1], [2] > > which > > > >> seem to be very critical from the usability and stability points of > > > >> view. > > > >> The [1] results in clients not being able to update > > persistence-enabled > > > >> clusters unless the client configuration is identical to the server > > > >> configuration. The [2] may result in incorrect node state recovery > and > > > >> either corrupted storage or lost updates. > > > >> > > > >> I suggest we make an emergency release (to my knowledge, we already > > had > > > >> such a practice with Ignite 2.3) and include the fixes for both of > the > > > >> issues to it. > > > >> > > > >> Thoughts? > > > >> > > > >> [1] https://issues.apache.org/jira/browse/IGNITE-8476 > > > >> [2] https://issues.apache.org/jira/browse/IGNITE-8685 > > > >> > > > >> --AG > > > >> > > > > > > > > > > > > > |
In reply to this post by Alexey Goncharuk
Igniters,
Can you squeeze this ticket into 2.6 scope? https://issues.apache.org/jira/browse/IGNITE-8534 As ignite-spark module is relatively independent module, and there're already two users in the user list trying to use spark 2.3 with Ignite last week only. http://apache-ignite-users.70518.x6.nabble.com/Spark-Ignite-connection-using-Config-file-td21827.html http://apache-ignite-users.70518.x6.nabble.com/Spark-Ignite-standalone-mode-on-Kubernetes-cluster-td21739.html -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ |
Agree with Ray. The ticket has been already reviewed and requires us to run
tests for an isolated module - Spark. Dmitriy Pavlov, Nickolay Izhikov, could you step in as final reviewers and merge the changes? -- Denis On Tue, Jun 12, 2018 at 12:01 AM Ray <[hidden email]> wrote: > Igniters, > > Can you squeeze this ticket into 2.6 scope? > https://issues.apache.org/jira/browse/IGNITE-8534 > > As ignite-spark module is relatively independent module, and there're > already two users in the user list trying to use spark 2.3 with Ignite last > week only. > > > http://apache-ignite-users.70518.x6.nabble.com/Spark-Ignite-connection-using-Config-file-td21827.html > > > http://apache-ignite-users.70518.x6.nabble.com/Spark-Ignite-standalone-mode-on-Kubernetes-cluster-td21739.html > > > > > > -- > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ > |
Hello, guys.
I try my best to do review in a next few days. В Вт, 12/06/2018 в 11:28 -0700, Denis Magda пишет: > Agree with Ray. The ticket has been already reviewed and requires us to run tests for an isolated module - Spark. > > Dmitriy Pavlov, Nickolay Izhikov, could you step in as final reviewers and merge the changes? > > -- > Denis > > On Tue, Jun 12, 2018 at 12:01 AM Ray <[hidden email]> wrote: > > Igniters, > > > > Can you squeeze this ticket into 2.6 scope? > > https://issues.apache.org/jira/browse/IGNITE-8534 > > > > As ignite-spark module is relatively independent module, and there're > > already two users in the user list trying to use spark 2.3 with Ignite last > > week only. > > > > http://apache-ignite-users.70518.x6.nabble.com/Spark-Ignite-connection-using-Config-file-td21827.html > > > > http://apache-ignite-users.70518.x6.nabble.com/Spark-Ignite-standalone-mode-on-Kubernetes-cluster-td21739.html > > > > > > > > > > > > -- > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ |
Hi!
Lets also include fix for https://issues.apache.org/jira/browse/IGNITE-8722 in this release. This bug was introduced in IGNITE-7803 (Ignite 2.5) for data structures that has references to self-type. The fix is simple (remove one "else" key word in IGNITE_BINARY_OBJECT_SERIALIZER) + add test. I will do this today. Please approve. On Wed, Jun 13, 2018 at 2:36 PM, Nikolay Izhikov <[hidden email]> wrote: > Hello, guys. > > I try my best to do review in a next few days. > > В Вт, 12/06/2018 в 11:28 -0700, Denis Magda пишет: > > Agree with Ray. The ticket has been already reviewed and requires us to > run tests for an isolated module - Spark. > > > > Dmitriy Pavlov, Nickolay Izhikov, could you step in as final reviewers > and merge the changes? > > > > -- > > Denis > > > > On Tue, Jun 12, 2018 at 12:01 AM Ray <[hidden email]> wrote: > > > Igniters, > > > > > > Can you squeeze this ticket into 2.6 scope? > > > https://issues.apache.org/jira/browse/IGNITE-8534 > > > > > > As ignite-spark module is relatively independent module, and there're > > > already two users in the user list trying to use spark 2.3 with Ignite > last > > > week only. > > > > > > http://apache-ignite-users.70518.x6.nabble.com/Spark- > Ignite-connection-using-Config-file-td21827.html > > > > > > http://apache-ignite-users.70518.x6.nabble.com/Spark- > Ignite-standalone-mode-on-Kubernetes-cluster-td21739.html > > > > > > > > > > > > > > > > > > -- > > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ > -- Alexey Kuznetsov |
Igniters,
Recently we noticed the issue when we don't completely persist some data on the disk: https://issues.apache.org/jira/browse/IGNITE-8780 . In some cases it can lead node to unrecoverable state. I think this problem should be included to release. ср, 13 июн. 2018 г. в 14:06, Alexey Kuznetsov <[hidden email]>: > Hi! > > Lets also include fix for > https://issues.apache.org/jira/browse/IGNITE-8722 > in this release. > This bug was introduced in IGNITE-7803 (Ignite 2.5) for data structures > that has references to self-type. > > The fix is simple (remove one "else" key word in > IGNITE_BINARY_OBJECT_SERIALIZER) + add test. > I will do this today. > > Please approve. > > > On Wed, Jun 13, 2018 at 2:36 PM, Nikolay Izhikov <[hidden email]> > wrote: > > > Hello, guys. > > > > I try my best to do review in a next few days. > > > > В Вт, 12/06/2018 в 11:28 -0700, Denis Magda пишет: > > > Agree with Ray. The ticket has been already reviewed and requires us to > > run tests for an isolated module - Spark. > > > > > > Dmitriy Pavlov, Nickolay Izhikov, could you step in as final reviewers > > and merge the changes? > > > > > > -- > > > Denis > > > > > > On Tue, Jun 12, 2018 at 12:01 AM Ray <[hidden email]> wrote: > > > > Igniters, > > > > > > > > Can you squeeze this ticket into 2.6 scope? > > > > https://issues.apache.org/jira/browse/IGNITE-8534 > > > > > > > > As ignite-spark module is relatively independent module, and there're > > > > already two users in the user list trying to use spark 2.3 with > Ignite > > last > > > > week only. > > > > > > > > http://apache-ignite-users.70518.x6.nabble.com/Spark- > > Ignite-connection-using-Config-file-td21827.html > > > > > > > > http://apache-ignite-users.70518.x6.nabble.com/Spark- > > Ignite-standalone-mode-on-Kubernetes-cluster-td21739.html > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ > > > > > > -- > Alexey Kuznetsov > |
Hi,
Fix for IGNITE-8722 (https://issues.apache.org/jira/browse/IGNITE-8722) is ready. Diff https://git1-us-west.apache.org/repos/asf?p=ignite.git&a=search&h=refs%2Fheads%2Fignite-8722&st=commit&s=IGNITE-8722 TC looks good for me. https://ci.ignite.apache.org/viewLog.html?buildId=1385195&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_JavaClient I'm ready to merge to master and 2.6 branches. Please approve. -- Alexey Kuznetsov |
Igniters,
I’d like to stage for 2.6 release also this issue [1]. Corresponding PR [2] is ready for review and merge. This is not related to code additional configuration file for enabling support of Windows 10 WSL Environment. [1] https://issues.apache.org/jira/browse/IGNITE-8804 [2] https://github.com/apache/ignite/pull/4194 > On 14 Jun 2018, at 06:59, Alexey Kuznetsov <[hidden email]> wrote: > > Hi, > > Fix for IGNITE-8722 (https://issues.apache.org/jira/browse/IGNITE-8722) is > ready. > > Diff > > https://git1-us-west.apache.org/repos/asf?p=ignite.git&a=search&h=refs%2Fheads%2Fignite-8722&st=commit&s=IGNITE-8722 > > TC looks good for me. > > https://ci.ignite.apache.org/viewLog.html?buildId=1385195&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_JavaClient > > I'm ready to merge to master and 2.6 branches. > Please approve. > > -- > Alexey Kuznetsov |
Hi Petr,
Who will be able to make the review for the suggested patch? I would like to freeze the branch and start preparing the release. пт, 15 июн. 2018 г. в 11:45, Petr Ivanov <[hidden email]>: > Igniters, > > > I’d like to stage for 2.6 release also this issue [1]. Corresponding PR > [2] is ready for review and merge. > This is not related to code additional configuration file for enabling > support of Windows 10 WSL Environment. > > > [1] https://issues.apache.org/jira/browse/IGNITE-8804 > [2] https://github.com/apache/ignite/pull/4194 > > > > > On 14 Jun 2018, at 06:59, Alexey Kuznetsov <[hidden email]> > wrote: > > > > Hi, > > > > Fix for IGNITE-8722 (https://issues.apache.org/jira/browse/IGNITE-8722) > is > > ready. > > > > Diff > > > > > https://git1-us-west.apache.org/repos/asf?p=ignite.git&a=search&h=refs%2Fheads%2Fignite-8722&st=commit&s=IGNITE-8722 > > > > TC looks good for me. > > > > > https://ci.ignite.apache.org/viewLog.html?buildId=1385195&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_JavaClient > > > > I'm ready to merge to master and 2.6 branches. > > Please approve. > > > > -- > > Alexey Kuznetsov > > |
Folks,
This release no longer reminds an emergency one :) Are we done with the scope, who is a release manager? From my side, I'd like us to review and add the fix for broken Spring integration which is a significant regression: https://issues.apache.org/jira/browse/IGNITE-8740 -- Denis On Mon, Jun 18, 2018 at 5:16 AM Alexey Goncharuk <[hidden email]> wrote: > Hi Petr, > > Who will be able to make the review for the suggested patch? I would like > to freeze the branch and start preparing the release. > > пт, 15 июн. 2018 г. в 11:45, Petr Ivanov <[hidden email]>: > > > Igniters, > > > > > > I’d like to stage for 2.6 release also this issue [1]. Corresponding PR > > [2] is ready for review and merge. > > This is not related to code additional configuration file for enabling > > support of Windows 10 WSL Environment. > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-8804 > > [2] https://github.com/apache/ignite/pull/4194 > > > > > > > > > On 14 Jun 2018, at 06:59, Alexey Kuznetsov <[hidden email]> > > wrote: > > > > > > Hi, > > > > > > Fix for IGNITE-8722 (https://issues.apache.org/jira/browse/IGNITE-8722 > ) > > is > > > ready. > > > > > > Diff > > > > > > > > > https://git1-us-west.apache.org/repos/asf?p=ignite.git&a=search&h=refs%2Fheads%2Fignite-8722&st=commit&s=IGNITE-8722 > > > > > > TC looks good for me. > > > > > > > > > https://ci.ignite.apache.org/viewLog.html?buildId=1385195&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_JavaClient > > > > > > I'm ready to merge to master and 2.6 branches. > > > Please approve. > > > > > > -- > > > Alexey Kuznetsov > > > > > |
Denis,
Currently, I am not aware of anybody who can immediately review and sign-off the suggested patch. The original scope of tickets have been resolved, so I suggest to move on with what we have now. I will not be able to continue with the release process until Thursday next week. Dmitriy Pavlov, do you mind taking over and finishing the release? чт, 21 июн. 2018 г. в 23:02, Denis Magda <[hidden email]>: > Folks, > > This release no longer reminds an emergency one :) Are we done with the > scope, who is a release manager? > > From my side, I'd like us to review and add the fix for broken Spring > integration which is a significant regression: > https://issues.apache.org/jira/browse/IGNITE-8740 > > -- > Denis > > On Mon, Jun 18, 2018 at 5:16 AM Alexey Goncharuk < > [hidden email]> > wrote: > > > Hi Petr, > > > > Who will be able to make the review for the suggested patch? I would like > > to freeze the branch and start preparing the release. > > > > пт, 15 июн. 2018 г. в 11:45, Petr Ivanov <[hidden email]>: > > > > > Igniters, > > > > > > > > > I’d like to stage for 2.6 release also this issue [1]. Corresponding PR > > > [2] is ready for review and merge. > > > This is not related to code additional configuration file for enabling > > > support of Windows 10 WSL Environment. > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-8804 > > > [2] https://github.com/apache/ignite/pull/4194 > > > > > > > > > > > > > On 14 Jun 2018, at 06:59, Alexey Kuznetsov <[hidden email]> > > > wrote: > > > > > > > > Hi, > > > > > > > > Fix for IGNITE-8722 ( > https://issues.apache.org/jira/browse/IGNITE-8722 > > ) > > > is > > > > ready. > > > > > > > > Diff > > > > > > > > > > > > > > https://git1-us-west.apache.org/repos/asf?p=ignite.git&a=search&h=refs%2Fheads%2Fignite-8722&st=commit&s=IGNITE-8722 > > > > > > > > TC looks good for me. > > > > > > > > > > > > > > https://ci.ignite.apache.org/viewLog.html?buildId=1385195&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_JavaClient > > > > > > > > I'm ready to merge to master and 2.6 branches. > > > > Please approve. > > > > > > > > -- > > > > Alexey Kuznetsov > > > > > > > > > |
Hi Alexey,
Sure, it will be honor for me. In the same time I relatevely new in this area, so I would highly appreciate any assistance of experienced community members to make this happen. Sincerely, пт, 22 июн. 2018 г. в 12:18, Alexey Goncharuk <[hidden email]>: > Denis, > > Currently, I am not aware of anybody who can immediately review and > sign-off the suggested patch. The original scope of tickets have been > resolved, so I suggest to move on with what we have now. > > I will not be able to continue with the release process until Thursday > next week. > > Dmitriy Pavlov, do you mind taking over and finishing the release? > > чт, 21 июн. 2018 г. в 23:02, Denis Magda <[hidden email]>: > >> Folks, >> >> This release no longer reminds an emergency one :) Are we done with the >> scope, who is a release manager? >> >> From my side, I'd like us to review and add the fix for broken Spring >> integration which is a significant regression: >> https://issues.apache.org/jira/browse/IGNITE-8740 >> >> -- >> Denis >> >> On Mon, Jun 18, 2018 at 5:16 AM Alexey Goncharuk < >> [hidden email]> >> wrote: >> >> > Hi Petr, >> > >> > Who will be able to make the review for the suggested patch? I would >> like >> > to freeze the branch and start preparing the release. >> > >> > пт, 15 июн. 2018 г. в 11:45, Petr Ivanov <[hidden email]>: >> > >> > > Igniters, >> > > >> > > >> > > I’d like to stage for 2.6 release also this issue [1]. Corresponding >> PR >> > > [2] is ready for review and merge. >> > > This is not related to code additional configuration file for enabling >> > > support of Windows 10 WSL Environment. >> > > >> > > >> > > [1] https://issues.apache.org/jira/browse/IGNITE-8804 >> > > [2] https://github.com/apache/ignite/pull/4194 >> > > >> > > >> > > >> > > > On 14 Jun 2018, at 06:59, Alexey Kuznetsov <[hidden email]> >> > > wrote: >> > > > >> > > > Hi, >> > > > >> > > > Fix for IGNITE-8722 ( >> https://issues.apache.org/jira/browse/IGNITE-8722 >> > ) >> > > is >> > > > ready. >> > > > >> > > > Diff >> > > > >> > > > >> > > >> > >> https://git1-us-west.apache.org/repos/asf?p=ignite.git&a=search&h=refs%2Fheads%2Fignite-8722&st=commit&s=IGNITE-8722 >> > > > >> > > > TC looks good for me. >> > > > >> > > > >> > > >> > >> https://ci.ignite.apache.org/viewLog.html?buildId=1385195&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_JavaClient >> > > > >> > > > I'm ready to merge to master and 2.6 branches. >> > > > Please approve. >> > > > >> > > > -- >> > > > Alexey Kuznetsov >> > > >> > > >> > >> > |
Dmitriy,
No, that's an honor for us to see you in this role ;) Both Andrey Gura, Anton Vinogradov are our release-management veterans. Please feel free to contact them directly. Could you take over this ticket review and include it in the release: https://issues.apache.org/jira/browse/IGNITE-8740 It's not good that we have spring integration broken in some places in several releases. I would treat is as a usability blocker and regression. -- Denis On Fri, Jun 22, 2018 at 3:06 AM Dmitry Pavlov <[hidden email]> wrote: > Hi Alexey, > > Sure, it will be honor for me. > > In the same time I relatevely new in this area, so I would highly > appreciate any assistance of experienced community members to make this > happen. > > Sincerely, > > пт, 22 июн. 2018 г. в 12:18, Alexey Goncharuk <[hidden email] > >: > > > Denis, > > > > Currently, I am not aware of anybody who can immediately review and > > sign-off the suggested patch. The original scope of tickets have been > > resolved, so I suggest to move on with what we have now. > > > > I will not be able to continue with the release process until Thursday > > next week. > > > > Dmitriy Pavlov, do you mind taking over and finishing the release? > > > > чт, 21 июн. 2018 г. в 23:02, Denis Magda <[hidden email]>: > > > >> Folks, > >> > >> This release no longer reminds an emergency one :) Are we done with the > >> scope, who is a release manager? > >> > >> From my side, I'd like us to review and add the fix for broken Spring > >> integration which is a significant regression: > >> https://issues.apache.org/jira/browse/IGNITE-8740 > >> > >> -- > >> Denis > >> > >> On Mon, Jun 18, 2018 at 5:16 AM Alexey Goncharuk < > >> [hidden email]> > >> wrote: > >> > >> > Hi Petr, > >> > > >> > Who will be able to make the review for the suggested patch? I would > >> like > >> > to freeze the branch and start preparing the release. > >> > > >> > пт, 15 июн. 2018 г. в 11:45, Petr Ivanov <[hidden email]>: > >> > > >> > > Igniters, > >> > > > >> > > > >> > > I’d like to stage for 2.6 release also this issue [1]. Corresponding > >> PR > >> > > [2] is ready for review and merge. > >> > > This is not related to code additional configuration file for > enabling > >> > > support of Windows 10 WSL Environment. > >> > > > >> > > > >> > > [1] https://issues.apache.org/jira/browse/IGNITE-8804 > >> > > [2] https://github.com/apache/ignite/pull/4194 > >> > > > >> > > > >> > > > >> > > > On 14 Jun 2018, at 06:59, Alexey Kuznetsov <[hidden email] > > > >> > > wrote: > >> > > > > >> > > > Hi, > >> > > > > >> > > > Fix for IGNITE-8722 ( > >> https://issues.apache.org/jira/browse/IGNITE-8722 > >> > ) > >> > > is > >> > > > ready. > >> > > > > >> > > > Diff > >> > > > > >> > > > > >> > > > >> > > >> > https://git1-us-west.apache.org/repos/asf?p=ignite.git&a=search&h=refs%2Fheads%2Fignite-8722&st=commit&s=IGNITE-8722 > >> > > > > >> > > > TC looks good for me. > >> > > > > >> > > > > >> > > > >> > > >> > https://ci.ignite.apache.org/viewLog.html?buildId=1385195&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_JavaClient > >> > > > > >> > > > I'm ready to merge to master and 2.6 branches. > >> > > > Please approve. > >> > > > > >> > > > -- > >> > > > Alexey Kuznetsov > >> > > > >> > > > >> > > >> > > > |
Guys,
I reviewed changes in IGNITE-8740, but I'm not sure the fix is correct. I left a more detailed comment in the ticket. Hopefully, Mair will be able to respond shortly and clarify. -Val On Fri, Jun 22, 2018 at 10:58 AM Denis Magda <[hidden email]> wrote: > Dmitriy, > > No, that's an honor for us to see you in this role ;) Both Andrey Gura, > Anton Vinogradov are our release-management veterans. Please feel free to > contact them directly. > > Could you take over this ticket review and include it in the release: > https://issues.apache.org/jira/browse/IGNITE-8740 > > It's not good that we have spring integration broken in some places in > several releases. I would treat is as a usability blocker and regression. > > -- > Denis > > > > On Fri, Jun 22, 2018 at 3:06 AM Dmitry Pavlov <[hidden email]> > wrote: > > > Hi Alexey, > > > > Sure, it will be honor for me. > > > > In the same time I relatevely new in this area, so I would highly > > appreciate any assistance of experienced community members to make this > > happen. > > > > Sincerely, > > > > пт, 22 июн. 2018 г. в 12:18, Alexey Goncharuk < > [hidden email] > > >: > > > > > Denis, > > > > > > Currently, I am not aware of anybody who can immediately review and > > > sign-off the suggested patch. The original scope of tickets have been > > > resolved, so I suggest to move on with what we have now. > > > > > > I will not be able to continue with the release process until Thursday > > > next week. > > > > > > Dmitriy Pavlov, do you mind taking over and finishing the release? > > > > > > чт, 21 июн. 2018 г. в 23:02, Denis Magda <[hidden email]>: > > > > > >> Folks, > > >> > > >> This release no longer reminds an emergency one :) Are we done with > the > > >> scope, who is a release manager? > > >> > > >> From my side, I'd like us to review and add the fix for broken Spring > > >> integration which is a significant regression: > > >> https://issues.apache.org/jira/browse/IGNITE-8740 > > >> > > >> -- > > >> Denis > > >> > > >> On Mon, Jun 18, 2018 at 5:16 AM Alexey Goncharuk < > > >> [hidden email]> > > >> wrote: > > >> > > >> > Hi Petr, > > >> > > > >> > Who will be able to make the review for the suggested patch? I would > > >> like > > >> > to freeze the branch and start preparing the release. > > >> > > > >> > пт, 15 июн. 2018 г. в 11:45, Petr Ivanov <[hidden email]>: > > >> > > > >> > > Igniters, > > >> > > > > >> > > > > >> > > I’d like to stage for 2.6 release also this issue [1]. > Corresponding > > >> PR > > >> > > [2] is ready for review and merge. > > >> > > This is not related to code additional configuration file for > > enabling > > >> > > support of Windows 10 WSL Environment. > > >> > > > > >> > > > > >> > > [1] https://issues.apache.org/jira/browse/IGNITE-8804 > > >> > > [2] https://github.com/apache/ignite/pull/4194 > > >> > > > > >> > > > > >> > > > > >> > > > On 14 Jun 2018, at 06:59, Alexey Kuznetsov < > [hidden email] > > > > > >> > > wrote: > > >> > > > > > >> > > > Hi, > > >> > > > > > >> > > > Fix for IGNITE-8722 ( > > >> https://issues.apache.org/jira/browse/IGNITE-8722 > > >> > ) > > >> > > is > > >> > > > ready. > > >> > > > > > >> > > > Diff > > >> > > > > > >> > > > > > >> > > > > >> > > > >> > > > https://git1-us-west.apache.org/repos/asf?p=ignite.git&a=search&h=refs%2Fheads%2Fignite-8722&st=commit&s=IGNITE-8722 > > >> > > > > > >> > > > TC looks good for me. > > >> > > > > > >> > > > > > >> > > > > >> > > > >> > > > https://ci.ignite.apache.org/viewLog.html?buildId=1385195&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_JavaClient > > >> > > > > > >> > > > I'm ready to merge to master and 2.6 branches. > > >> > > > Please approve. > > >> > > > > > >> > > > -- > > >> > > > Alexey Kuznetsov > > >> > > > > >> > > > > >> > > > >> > > > > > > |
After a conversation with Amir, IGNITE-8740 is merged to master and 2.6.
-Val On Fri, Jun 22, 2018 at 2:52 PM Valentin Kulichenko < [hidden email]> wrote: > Guys, > > I reviewed changes in IGNITE-8740, but I'm not sure the fix is correct. I > left a more detailed comment in the ticket. Hopefully, Mair will be able to > respond shortly and clarify. > > -Val > > On Fri, Jun 22, 2018 at 10:58 AM Denis Magda <[hidden email]> wrote: > >> Dmitriy, >> >> No, that's an honor for us to see you in this role ;) Both Andrey Gura, >> Anton Vinogradov are our release-management veterans. Please feel free to >> contact them directly. >> >> Could you take over this ticket review and include it in the release: >> https://issues.apache.org/jira/browse/IGNITE-8740 >> >> It's not good that we have spring integration broken in some places in >> several releases. I would treat is as a usability blocker and regression. >> >> -- >> Denis >> >> >> >> On Fri, Jun 22, 2018 at 3:06 AM Dmitry Pavlov <[hidden email]> >> wrote: >> >> > Hi Alexey, >> > >> > Sure, it will be honor for me. >> > >> > In the same time I relatevely new in this area, so I would highly >> > appreciate any assistance of experienced community members to make this >> > happen. >> > >> > Sincerely, >> > >> > пт, 22 июн. 2018 г. в 12:18, Alexey Goncharuk < >> [hidden email] >> > >: >> > >> > > Denis, >> > > >> > > Currently, I am not aware of anybody who can immediately review and >> > > sign-off the suggested patch. The original scope of tickets have been >> > > resolved, so I suggest to move on with what we have now. >> > > >> > > I will not be able to continue with the release process until Thursday >> > > next week. >> > > >> > > Dmitriy Pavlov, do you mind taking over and finishing the release? >> > > >> > > чт, 21 июн. 2018 г. в 23:02, Denis Magda <[hidden email]>: >> > > >> > >> Folks, >> > >> >> > >> This release no longer reminds an emergency one :) Are we done with >> the >> > >> scope, who is a release manager? >> > >> >> > >> From my side, I'd like us to review and add the fix for broken Spring >> > >> integration which is a significant regression: >> > >> https://issues.apache.org/jira/browse/IGNITE-8740 >> > >> >> > >> -- >> > >> Denis >> > >> >> > >> On Mon, Jun 18, 2018 at 5:16 AM Alexey Goncharuk < >> > >> [hidden email]> >> > >> wrote: >> > >> >> > >> > Hi Petr, >> > >> > >> > >> > Who will be able to make the review for the suggested patch? I >> would >> > >> like >> > >> > to freeze the branch and start preparing the release. >> > >> > >> > >> > пт, 15 июн. 2018 г. в 11:45, Petr Ivanov <[hidden email]>: >> > >> > >> > >> > > Igniters, >> > >> > > >> > >> > > >> > >> > > I’d like to stage for 2.6 release also this issue [1]. >> Corresponding >> > >> PR >> > >> > > [2] is ready for review and merge. >> > >> > > This is not related to code additional configuration file for >> > enabling >> > >> > > support of Windows 10 WSL Environment. >> > >> > > >> > >> > > >> > >> > > [1] https://issues.apache.org/jira/browse/IGNITE-8804 >> > >> > > [2] https://github.com/apache/ignite/pull/4194 >> > >> > > >> > >> > > >> > >> > > >> > >> > > > On 14 Jun 2018, at 06:59, Alexey Kuznetsov < >> [hidden email] >> > > >> > >> > > wrote: >> > >> > > > >> > >> > > > Hi, >> > >> > > > >> > >> > > > Fix for IGNITE-8722 ( >> > >> https://issues.apache.org/jira/browse/IGNITE-8722 >> > >> > ) >> > >> > > is >> > >> > > > ready. >> > >> > > > >> > >> > > > Diff >> > >> > > > >> > >> > > > >> > >> > > >> > >> > >> > >> >> > >> https://git1-us-west.apache.org/repos/asf?p=ignite.git&a=search&h=refs%2Fheads%2Fignite-8722&st=commit&s=IGNITE-8722 >> > >> > > > >> > >> > > > TC looks good for me. >> > >> > > > >> > >> > > > >> > >> > > >> > >> > >> > >> >> > >> https://ci.ignite.apache.org/viewLog.html?buildId=1385195&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_JavaClient >> > >> > > > >> > >> > > > I'm ready to merge to master and 2.6 branches. >> > >> > > > Please approve. >> > >> > > > >> > >> > > > -- >> > >> > > > Alexey Kuznetsov >> > >> > > >> > >> > > >> > >> > >> > >> >> > > >> > >> > |
Free forum by Nabble | Edit this page |