IGNITE-8583 - review needed

[Dmitriy Govorukhin]

Igniters,

I fixed DataStorageMetricsMXBean.getOffHeapSize, please review my changes.

https://issues.apache.org/jira/browse/IGNITE-8583

[Dmitriy Pavlov]

Hi Dmitriy,

According to upsource
https://reviews.ignite.apache.org/ignite/review/IGNT-CR-623 review was
already started by Alexey G. and  Alexey K.

Sincerely,
Dmitriy Pavlov



чт, 24 мая 2018 г. в 14:04, Dmitriy Govorukhin <[hidden email]
>:

> Igniters,
>
> I fixed DataStorageMetricsMXBean.getOffHeapSize, please review my changes.
>
> https://issues.apache.org/jira/browse/IGNITE-8583
>

[dsetrakyan]

I continuously ask not to provide naked ticket numbers in the subject.
Please also add titles or descriptions. I doubt anyone in the community can
tell what this is about just by looking at the number.

D.

On Thu, May 24, 2018 at 4:09 AM, Dmitry Pavlov <[hidden email]>
wrote:

> Hi Dmitriy,
>
> According to upsource
> https://reviews.ignite.apache.org/ignite/review/IGNT-CR-623 review was
> already started by Alexey G. and  Alexey K.
>
> Sincerely,
> Dmitriy Pavlov
>
>
>
> чт, 24 мая 2018 г. в 14:04, Dmitriy Govorukhin <
> [hidden email]
> >:
>
> > Igniters,
> >
> > I fixed DataStorageMetricsMXBean.getOffHeapSize, please review my
> changes.
> >
> > https://issues.apache.org/jira/browse/IGNITE-8583
> >
>

[Dmitriy Pavlov]

Reasonable proposal and I hope most Igniters will follow it.

In the same time I've just clicked to the link
https://issues.apache.org/jira/browse/IGNITE-8583 provided by Dmitriy to
check ticket name, and then I've clicked to review link
https://reviews.ignite.apache.org/ignite/review/IGNT-CR-623 to find out
review status. So I'm OK if contributor will provide just link to ticket.

чт, 24 мая 2018 г. в 20:47, Dmitriy Setrakyan <[hidden email]>:

> I continuously ask not to provide naked ticket numbers in the subject.
> Please also add titles or descriptions. I doubt anyone in the community can
> tell what this is about just by looking at the number.
>
> D.
>
> On Thu, May 24, 2018 at 4:09 AM, Dmitry Pavlov <[hidden email]>
> wrote:
>
> > Hi Dmitriy,
> >
> > According to upsource
> > https://reviews.ignite.apache.org/ignite/review/IGNT-CR-623 review was
> > already started by Alexey G. and  Alexey K.
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> >
> >
> > чт, 24 мая 2018 г. в 14:04, Dmitriy Govorukhin <
> > [hidden email]
> > >:
> >
> > > Igniters,
> > >
> > > I fixed DataStorageMetricsMXBean.getOffHeapSize, please review my
> > changes.
> > >
> > > https://issues.apache.org/jira/browse/IGNITE-8583
> > >
> >
>