IGNITE-7135 needs review

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

IGNITE-7135 needs review

Alexandr Kuramshin
Hello community!

I've implemented IGNITE-7135 doing two improvements:

1) control remote node startup (successful or not) through
IgniteCluster.startNodes();

2) keep the first Java principle working "Compile once, run everywhere" -
from now running remotely on Windows also supported.

Committers, please review.

--
Thanks,
Alexandr Kuramshin
Reply | Threaded
Open this post in threaded view
|

Re: IGNITE-7135 needs review

dsetrakyan
Here is the link to the ticket:
https://issues.apache.org/jira/browse/IGNITE-7135

For some odd reason, the ticket is in unassigned state. Alexander,
shouldn't it be assigned to you?

D.

On Mon, Dec 25, 2017 at 11:58 PM, Alexandr Kuramshin <[hidden email]>
wrote:

> Hello community!
>
> I've implemented IGNITE-7135 doing two improvements:
>
> 1) control remote node startup (successful or not) through
> IgniteCluster.startNodes();
>
> 2) keep the first Java principle working "Compile once, run everywhere" -
> from now running remotely on Windows also supported.
>
> Committers, please review.
>
> --
> Thanks,
> Alexandr Kuramshin
>
Reply | Threaded
Open this post in threaded view
|

Re: IGNITE-7135 needs review

Alexandr Kuramshin
Ticket was assigned to me until the patch available state has been reached.

Till now no one committer take responsibility to review and merge the PR.

2017-12-26 21:08 GMT+07:00 Dmitriy Setrakyan <[hidden email]>:

> Here is the link to the ticket:
> https://issues.apache.org/jira/browse/IGNITE-7135
>
> For some odd reason, the ticket is in unassigned state. Alexander,
> shouldn't it be assigned to you?
>
> D.
>
> On Mon, Dec 25, 2017 at 11:58 PM, Alexandr Kuramshin <[hidden email]
> >
> wrote:
>
> > Hello community!
> >
> > I've implemented IGNITE-7135 doing two improvements:
> >
> > 1) control remote node startup (successful or not) through
> > IgniteCluster.startNodes();
> >
> > 2) keep the first Java principle working "Compile once, run everywhere" -
> > from now running remotely on Windows also supported.
> >
> > Committers, please review.
> >
> > --
> > Thanks,
> > Alexandr Kuramshin
> >
>



--
Thanks,
Alexandr Kuramshin
Reply | Threaded
Open this post in threaded view
|

Re: IGNITE-7135 needs review

agura
Alexandr,

I've merged your changes to master branch. Thanks for contribution!

On Wed, Dec 27, 2017 at 9:50 PM, Alexandr Kuramshin
<[hidden email]> wrote:

> Ticket was assigned to me until the patch available state has been reached.
>
> Till now no one committer take responsibility to review and merge the PR.
>
> 2017-12-26 21:08 GMT+07:00 Dmitriy Setrakyan <[hidden email]>:
>
>> Here is the link to the ticket:
>> https://issues.apache.org/jira/browse/IGNITE-7135
>>
>> For some odd reason, the ticket is in unassigned state. Alexander,
>> shouldn't it be assigned to you?
>>
>> D.
>>
>> On Mon, Dec 25, 2017 at 11:58 PM, Alexandr Kuramshin <[hidden email]
>> >
>> wrote:
>>
>> > Hello community!
>> >
>> > I've implemented IGNITE-7135 doing two improvements:
>> >
>> > 1) control remote node startup (successful or not) through
>> > IgniteCluster.startNodes();
>> >
>> > 2) keep the first Java principle working "Compile once, run everywhere" -
>> > from now running remotely on Windows also supported.
>> >
>> > Committers, please review.
>> >
>> > --
>> > Thanks,
>> > Alexandr Kuramshin
>> >
>>
>
>
>
> --
> Thanks,
> Alexandr Kuramshin