Hi,
I have fixed problem with the test CacheGroupsMetricsRebalanceTest.testRebalanceEstimateFinishTime. Please review and merge if okay. P.S. Aleksey Plekhanov already approved it (see Jira). JIRA: https://issues.apache.org/jira/browse/IGNITE-6430 PR: https://github.com/apache/ignite/pull/3914 TC (with 120 passes): https://ci.ignite.apache.org/viewLog.html?buildId=1246058&buildTypeId=IgniteTests24Java8_Cache3&tab=testsInfo TC: https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_BuildApacheIgnite&branch_IgniteTests24Java8=pull%2F3914%2Fhead&tab=buildTypeStatusDiv |
Hi Dmitriy G,
could you please pick up this review? Sincerely, Dmitriy Pavlov чт, 10 мая 2018 г. в 15:50, Александр Меньшиков <[hidden email]>: > Hi, > > I have fixed problem with the test > CacheGroupsMetricsRebalanceTest.testRebalanceEstimateFinishTime. > > Please review and merge if okay. > > P.S. > Aleksey Plekhanov already approved it (see Jira). > > > JIRA: https://issues.apache.org/jira/browse/IGNITE-6430 > PR: https://github.com/apache/ignite/pull/3914 > TC (with 120 passes): > > https://ci.ignite.apache.org/viewLog.html?buildId=1246058&buildTypeId=IgniteTests24Java8_Cache3&tab=testsInfo > TC: > > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_BuildApacheIgnite&branch_IgniteTests24Java8=pull%2F3914%2Fhead&tab=buildTypeStatusDiv > |
Dmitriy,
Ok, I will do it soon. On Mon, May 14, 2018 at 8:41 PM, Dmitry Pavlov <[hidden email]> wrote: > Hi Dmitriy G, > > could you please pick up this review? > > Sincerely, > Dmitriy Pavlov > > чт, 10 мая 2018 г. в 15:50, Александр Меньшиков <[hidden email]>: > >> Hi, >> >> I have fixed problem with the test >> CacheGroupsMetricsRebalanceTest.testRebalanceEstimateFinishTime. >> >> Please review and merge if okay. >> >> P.S. >> Aleksey Plekhanov already approved it (see Jira). >> >> >> JIRA: https://issues.apache.org/jira/browse/IGNITE-6430 >> PR: https://github.com/apache/ignite/pull/3914 >> TC (with 120 passes): >> https://ci.ignite.apache.org/viewLog.html?buildId=1246058&buildTypeId= >> IgniteTests24Java8_Cache3&tab=testsInfo >> TC: >> https://ci.ignite.apache.org/viewType.html?buildTypeId= >> IgniteTests24Java8_BuildApacheIgnite&branch_IgniteTests24Java8=pull% >> 2F3914%2Fhead&tab=buildTypeStatusDiv >> > |
Dmitriy,
Looks good for me please merge. On Tue, May 15, 2018 at 11:20 AM, Dmitriy Govorukhin < [hidden email]> wrote: > Dmitriy, > > Ok, I will do it soon. > > On Mon, May 14, 2018 at 8:41 PM, Dmitry Pavlov <[hidden email]> > wrote: > >> Hi Dmitriy G, >> >> could you please pick up this review? >> >> Sincerely, >> Dmitriy Pavlov >> >> чт, 10 мая 2018 г. в 15:50, Александр Меньшиков <[hidden email]>: >> >>> Hi, >>> >>> I have fixed problem with the test >>> CacheGroupsMetricsRebalanceTest.testRebalanceEstimateFinishTime. >>> >>> Please review and merge if okay. >>> >>> P.S. >>> Aleksey Plekhanov already approved it (see Jira). >>> >>> >>> JIRA: https://issues.apache.org/jira/browse/IGNITE-6430 >>> PR: https://github.com/apache/ignite/pull/3914 >>> TC (with 120 passes): >>> https://ci.ignite.apache.org/viewLog.html?buildId=1246058&bu >>> ildTypeId=IgniteTests24Java8_Cache3&tab=testsInfo >>> TC: >>> https://ci.ignite.apache.org/viewType.html?buildTypeId=Ignit >>> eTests24Java8_BuildApacheIgnite&branch_IgniteTests24Java8= >>> pull%2F3914%2Fhead&tab=buildTypeStatusDiv >>> >> > |
Done. Alexander, Alexey, Dmitriy, thank you.
вт, 15 мая 2018 г. в 13:29, Dmitriy Govorukhin <[hidden email] >: > Dmitriy, > > Looks good for me please merge. > > On Tue, May 15, 2018 at 11:20 AM, Dmitriy Govorukhin < > [hidden email]> wrote: > >> Dmitriy, >> >> Ok, I will do it soon. >> >> On Mon, May 14, 2018 at 8:41 PM, Dmitry Pavlov <[hidden email]> >> wrote: >> >>> Hi Dmitriy G, >>> >>> could you please pick up this review? >>> >>> Sincerely, >>> Dmitriy Pavlov >>> >>> чт, 10 мая 2018 г. в 15:50, Александр Меньшиков <[hidden email]>: >>> >>>> Hi, >>>> >>>> I have fixed problem with the test >>>> CacheGroupsMetricsRebalanceTest.testRebalanceEstimateFinishTime. >>>> >>>> Please review and merge if okay. >>>> >>>> P.S. >>>> Aleksey Plekhanov already approved it (see Jira). >>>> >>>> >>>> JIRA: https://issues.apache.org/jira/browse/IGNITE-6430 >>>> PR: https://github.com/apache/ignite/pull/3914 >>>> TC (with 120 passes): >>>> >>>> https://ci.ignite.apache.org/viewLog.html?buildId=1246058&buildTypeId=IgniteTests24Java8_Cache3&tab=testsInfo >>>> TC: >>>> >>>> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_BuildApacheIgnite&branch_IgniteTests24Java8=pull%2F3914%2Fhead&tab=buildTypeStatusDiv >>>> >>> >> > |
Free forum by Nabble | Edit this page |