IGNITE-4404 long running test refactoring - how to refactor?

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

IGNITE-4404 long running test refactoring - how to refactor?

Dmitrii Ryabov
Hello, community. Ticket description:

in testTransform

final int THREADS = 5;
final int ITERATIONS_PER_THREAD = 10_000;

So, what should I change?
Other methods have

final int THREADS = 5;
final int ITERATIONS_PER_THREAD = iterations();

where iterations() {return 10_000;}

Should I use iterations() and create same method for threads? Or may be
replace all local finals to class finals?

Should I do something else? Couse the only way to make test shorter is to
reduce number of iterations, but purpose of this test is long concurrent
actions.
Reply | Threaded
Open this post in threaded view
|

Re: IGNITE-4404 long running test refactoring - how to refactor?

yzhdanov
Konstantin Dudkov, you created ticket some time ago. Can you please clarify?

--Yakov
Reply | Threaded
Open this post in threaded view
|

Re: IGNITE-4404 long running test refactoring - how to refactor?

Константин Дудков
Answered to ticket. It's more about testing process than real refactoring so I think we need to discuss it further.

21.02.2017, 17:54, "Yakov Zhdanov" <[hidden email]>:
> Konstantin Dudkov, you created ticket some time ago. Can you please clarify?
>
> --Yakov

--
С уважением,
Константин Дудков
[hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: IGNITE-4404 long running test refactoring - how to refactor?

Dmitrii Ryabov
I think we can keep this numbers for atomic behavior and decrease for
transactional.

But which tests can be replaced with mocks if they all use node's cache?

2017-02-22 12:47 GMT+03:00 Константин Дудков <[hidden email]>:

> Answered to ticket. It's more about testing process than real refactoring
> so I think we need to discuss it further.
>
> 21.02.2017, 17:54, "Yakov Zhdanov" <[hidden email]>:
> > Konstantin Dudkov, you created ticket some time ago. Can you please
> clarify?
> >
> > --Yakov
>
> --
> С уважением,
> Константин Дудков
> [hidden email]
>