IGNITE-4052 ready for review

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

IGNITE-4052 ready for review

vadopolski
Hello everybody!

Nikolay, the properties for mesos role and JUnit test were added.

Review please the pull request - https://github.com/apache/ignite/pull/1662

Vadim Opolski

2017-03-24 18:41 GMT+03:00 Nikolai Tikhonov <[hidden email]>:

> Great! Looking forward to the contribution.
>
> On Fri, Mar 24, 2017 at 3:54 PM, Вадим Опольский <[hidden email]>
> wrote:
>
>> Nikolay, I will add properties for mesos role and unit test next week.
>>
>> ---------- Forwarded message ----------
>> From: Вадим Опольский <[hidden email]>
>> Date: 2017-03-22 15:53 GMT+03:00
>> Subject: Re: IGNITE-4052 ready for review
>> To: [hidden email]
>>
>>
>> Nikolay, just changed status to "path available".
>>
>> 2017-03-22 15:44 GMT+03:00 Nikolai Tikhonov <[hidden email]>:
>>
>>> Hi Вадим!
>>>
>>> Thank you for your contribution!
>>> Please change status of the ticket to "path available". I'll review your
>>> changes.
>>>
>>> Thanks,
>>> Nikolay
>>>
>>> On Wed, Mar 22, 2017 at 3:36 PM, Вадим Опольский <[hidden email]>
>>> wrote:
>>>
>>> > Hello everybody!
>>> >
>>> > Nikolay,
>>> >  review please https://github.com/apache/ignite/pull/1662 .
>>> >
>>> > Added ability to configure current user parameters via system env
>>> > properties - "MESOS_USER".
>>> >
>>> > Vadim Opolski
>>> >
>>> >
>>> > ---------- Forwarded message ----------
>>> > From: Вадим Опольский <[hidden email]>
>>> > Date: 2017-03-21 14:40 GMT+03:00
>>> > Subject: Assignee IGNITE-4052
>>> > To: [hidden email]
>>> >
>>> >
>>> > Dear sirs !
>>> >
>>> > I want to resolve issue IGNITE-4052.
>>> >
>>> > https://issues.apache.org/jira/browse/IGNITE-4052
>>> >
>>> > Is it actual ?
>>> >
>>> > Vadim Opolski
>>> >
>>> >
>>>
>>
>>
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: IGNITE-4052 ready for review

Nikolai Tikhonov
Thank you for your contribution! Please, don't forget to move ticket in
"path available" state.

On Wed, Mar 29, 2017 at 10:46 AM, Вадим Опольский <[hidden email]>
wrote:

> Hello everybody!
>
> Nikolay, the properties for mesos role and JUnit test were added.
>
> Review please the pull request - https://github.com/apache/igni
> te/pull/1662
>
> Vadim Opolski
>
> 2017-03-24 18:41 GMT+03:00 Nikolai Tikhonov <[hidden email]>:
>
>> Great! Looking forward to the contribution.
>>
>> On Fri, Mar 24, 2017 at 3:54 PM, Вадим Опольский <[hidden email]>
>> wrote:
>>
>>> Nikolay, I will add properties for mesos role and unit test next week.
>>>
>>> ---------- Forwarded message ----------
>>> From: Вадим Опольский <[hidden email]>
>>> Date: 2017-03-22 15:53 GMT+03:00
>>> Subject: Re: IGNITE-4052 ready for review
>>> To: [hidden email]
>>>
>>>
>>> Nikolay, just changed status to "path available".
>>>
>>> 2017-03-22 15:44 GMT+03:00 Nikolai Tikhonov <[hidden email]>:
>>>
>>>> Hi Вадим!
>>>>
>>>> Thank you for your contribution!
>>>> Please change status of the ticket to "path available". I'll review your
>>>> changes.
>>>>
>>>> Thanks,
>>>> Nikolay
>>>>
>>>> On Wed, Mar 22, 2017 at 3:36 PM, Вадим Опольский <[hidden email]>
>>>> wrote:
>>>>
>>>> > Hello everybody!
>>>> >
>>>> > Nikolay,
>>>> >  review please https://github.com/apache/ignite/pull/1662 .
>>>> >
>>>> > Added ability to configure current user parameters via system env
>>>> > properties - "MESOS_USER".
>>>> >
>>>> > Vadim Opolski
>>>> >
>>>> >
>>>> > ---------- Forwarded message ----------
>>>> > From: Вадим Опольский <[hidden email]>
>>>> > Date: 2017-03-21 14:40 GMT+03:00
>>>> > Subject: Assignee IGNITE-4052
>>>> > To: [hidden email]
>>>> >
>>>> >
>>>> > Dear sirs !
>>>> >
>>>> > I want to resolve issue IGNITE-4052.
>>>> >
>>>> > https://issues.apache.org/jira/browse/IGNITE-4052
>>>> >
>>>> > Is it actual ?
>>>> >
>>>> > Vadim Opolski
>>>> >
>>>> >
>>>>
>>>
>>>
>>>
>>
>