IGNITE-3904 - Add an option to serialize specific type(s) with OptimizedMarshaller when binary format is used

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

IGNITE-3904 - Add an option to serialize specific type(s) with OptimizedMarshaller when binary format is used

Nikita Amelchev
hello everyone.
Is IGNITE-3904 still relevant?

I'd like to take it.
Can you add me to contributor list?
Username: NSAmelchev
Full Name: Amelchev Nikita

--
Best wishes,
Amelchev Nikita
Reply | Threaded
Open this post in threaded view
|

Re: IGNITE-3904 - Add an option to serialize specific type(s) with OptimizedMarshaller when binary format is used

dmagda
Hi Nikita,

Yes, looks like the ticket is waiting to be picked up. I’ve added you to the contributors list. Go ahead an assign it on yourself.

In the meanwhile, Val, could you remind me what was the main reason this ticket was created? There was some issue related to hashCode calculation for some Hibernate objects, right? Now we should get over this issue using BinaryIdentityResolver [1].

[1] https://apacheignite.readme.io/docs/binary-marshaller#handling-hash-code-generation-and-equals-execution <https://apacheignite.readme.io/docs/binary-marshaller#handling-hash-code-generation-and-equals-execution>


Denis

> On Jan 6, 2017, at 8:01 AM, Nikita Amelchev <[hidden email]> wrote:
>
> hello everyone.
> Is IGNITE-3904 still relevant?
>
> I'd like to take it.
> Can you add me to contributor list?
> Username: NSAmelchev
> Full Name: Amelchev Nikita
>
> --
> Best wishes,
> Amelchev Nikita

Reply | Threaded
Open this post in threaded view
|

Re: IGNITE-3904 - Add an option to serialize specific type(s) with OptimizedMarshaller when binary format is used

dmagda
+ dev list

Nikita, if this is not the feature that is needed then we can close the ticket and I would suggest you picking up another one.


Denis

> On Jan 6, 2017, at 10:18 AM, Valentin Kulichenko <[hidden email]> wrote:
>
> Denis,
>
> Yes, this was the original motivation and with BinaryIdentityResolver there is no issue anymore. I don't think there is much sense to make this change now, it will only pollute the configuration with another not very intuitive property.
>
> Nikita, do you have any specific case where you need this change?
>
> -Val
>
> On Fri, Jan 6, 2017 at 9:42 AM, Denis Magda <[hidden email] <mailto:[hidden email]>> wrote:
> Hi Nikita,
>
> Yes, looks like the ticket is waiting to be picked up. I’ve added you to the contributors list. Go ahead an assign it on yourself.
>
> In the meanwhile, Val, could you remind me what was the main reason this ticket was created? There was some issue related to hashCode calculation for some Hibernate objects, right? Now we should get over this issue using BinaryIdentityResolver [1].
>
> [1] https://apacheignite.readme.io/docs/binary-marshaller#handling-hash-code-generation-and-equals-execution <https://apacheignite.readme.io/docs/binary-marshaller#handling-hash-code-generation-and-equals-execution>
>
> —
> Denis
>
>> On Jan 6, 2017, at 8:01 AM, Nikita Amelchev <[hidden email] <mailto:[hidden email]>> wrote:
>>
>> hello everyone.
>> Is IGNITE-3904 still relevant?
>>
>> I'd like to take it.
>> Can you add me to contributor list?
>> Username: NSAmelchev
>> Full Name: Amelchev Nikita
>>
>> --
>> Best wishes,
>> Amelchev Nikita
>
>

Reply | Threaded
Open this post in threaded view
|

Re: IGNITE-3904 - Add an option to serialize specific type(s) with OptimizedMarshaller when binary format is used

Nikita Amelchev
We dont have any specific case. You can close this ticket.

2017-01-06 21:26 GMT+03:00 Denis Magda <[hidden email]>:

> + dev list
>
> Nikita, if this is not the feature that is needed then we can close the
> ticket and I would suggest you picking up another one.
>
> —
> Denis
>
> > On Jan 6, 2017, at 10:18 AM, Valentin Kulichenko <
> [hidden email]> wrote:
> >
> > Denis,
> >
> > Yes, this was the original motivation and with BinaryIdentityResolver
> there is no issue anymore. I don't think there is much sense to make this
> change now, it will only pollute the configuration with another not very
> intuitive property.
> >
> > Nikita, do you have any specific case where you need this change?
> >
> > -Val
> >
> > On Fri, Jan 6, 2017 at 9:42 AM, Denis Magda <[hidden email] <mailto:
> [hidden email]>> wrote:
> > Hi Nikita,
> >
> > Yes, looks like the ticket is waiting to be picked up. I’ve added you to
> the contributors list. Go ahead an assign it on yourself.
> >
> > In the meanwhile, Val, could you remind me what was the main reason this
> ticket was created? There was some issue related to hashCode calculation
> for some Hibernate objects, right? Now we should get over this issue using
> BinaryIdentityResolver [1].
> >
> > [1] https://apacheignite.readme.io/docs/binary-marshaller#
> handling-hash-code-generation-and-equals-execution <
> https://apacheignite.readme.io/docs/binary-marshaller#
> handling-hash-code-generation-and-equals-execution>
> >
> > —
> > Denis
> >
> >> On Jan 6, 2017, at 8:01 AM, Nikita Amelchev <[hidden email]
> <mailto:[hidden email]>> wrote:
> >>
> >> hello everyone.
> >> Is IGNITE-3904 still relevant?
> >>
> >> I'd like to take it.
> >> Can you add me to contributor list?
> >> Username: NSAmelchev
> >> Full Name: Amelchev Nikita
> >>
> >> --
> >> Best wishes,
> >> Amelchev Nikita
> >
> >
>
>


--
Best wishes,
Amelchev Nikita