Apache Ignite Developers - Legacy Mail Archive

IGNITE-3727： why did not merge into the 1.8 version?

Classic

List

Threaded

8 messages Options

李玉珏@163

IGNITE-3727： why did not merge into the 1.8 version?

Hi：

IGNITE-3727,this issue has been fixed and tested in september，why did
not merge into the 1.8 version?

dmagda

Re: IGNITE-3727： why did not merge into the 1.8 version?

Hi,

It was released in 1.8. I’ve just checked git logs.

How did you come up with such a conclusion? Something doesn't work on your side?

—
Denis

> On Dec 10, 2016, at 5:39 AM, 李玉珏@163 <[hidden email]> wrote:
>
> Hi：
>
>
> IGNITE-3727,this issue has been fixed and tested in september，why did not merge into the 1.8 version?
>
>

李玉珏@163

Re: IGNITE-3727： why did not merge into the 1.8 version?

Denis，

I found the branch 3727:

https://github.com/gridgain/apache-ignite/tree/ignite-3727-2

But it appear that the code is not merged into the master?

for example, IgniteMessagingImpl.java,the related code is still an old
version,8 months ago.

在 2016/12/10 22:56, Denis Magda 写道:

> Hi,
>
> It was released in 1.8. I’ve just checked git logs.
>
> How did you come up with such a conclusion? Something doesn't work on your side?
>
> —
> Denis
>
>> On Dec 10, 2016, at 5:39 AM, 李玉珏@163 <[hidden email]> wrote:
>>
>> Hi：
>>
>>
>> IGNITE-3727,this issue has been fixed and tested in september，why did not merge into the 1.8 version?
>>
>>

dmagda

Re: IGNITE-3727： why did not merge into the 1.8 version?

Alright, looks like I confused it with some other task initially.

The ticket you’re talking about is still under review and looks abandoned
https://issues.apache.org/jira/browse/IGNITE-3727 <https://issues.apache.org/jira/browse/IGNITE-3727>

Dmitriy G., Sam, is the ticket ready for the merge?

—
Denis

> On Dec 10, 2016, at 6:29 PM, 李玉珏@163 <[hidden email]> wrote:
>
> Denis，
>
> I found the branch 3727:
>
> https://github.com/gridgain/apache-ignite/tree/ignite-3727-2
>
> But it appear that the code is not merged into the master?
>
> for example, IgniteMessagingImpl.java,the related code is still an old version,8 months ago.
>
>
> 在 2016/12/10 22:56, Denis Magda 写道:
>> Hi,
>>
>> It was released in 1.8. I’ve just checked git logs.
>>
>> How did you come up with such a conclusion? Something doesn't work on your side?
>>
>> —
>> Denis
>>
>>> On Dec 10, 2016, at 5:39 AM, 李玉珏@163 <[hidden email]> wrote:
>>>
>>> Hi：
>>>
>>>
>>> IGNITE-3727,this issue has been fixed and tested in september，why did not merge into the 1.8 version?
>>>
>>>
>

Semyon Boikov

Re: IGNITE-3727： why did not merge into the 1.8 version?

Hi,

We had a lot of more priority issues so I somehow missed IGNITE-3732. As a
workaround it is possible to create special thread pool and when message is
sent to local node execute message listener there instead of
IgniteMessaging usage.

Thanks

On Sun, Dec 11, 2016 at 5:56 AM, Denis Magda <[hidden email]> wrote:

> Alright, looks like I confused it with some other task initially.
>
> The ticket you’re talking about is still under review and looks abandoned
> https://issues.apache.org/jira/browse/IGNITE-3727 <
> https://issues.apache.org/jira/browse/IGNITE-3727>
>
> Dmitriy G., Sam, is the ticket ready for the merge?
>
> —
> Denis
>
> > On Dec 10, 2016, at 6:29 PM, 李玉珏@163 <[hidden email]> wrote:
> >
> > Denis，
> >
> > I found the branch 3727:
> >
> > https://github.com/gridgain/apache-ignite/tree/ignite-3727-2
> >
> > But it appear that the code is not merged into the master?
> >
> > for example, IgniteMessagingImpl.java,the related code is still an old
> version,8 months ago.
> >
> >
> > 在 2016/12/10 22:56, Denis Magda 写道:
> >> Hi,
> >>
> >> It was released in 1.8. I’ve just checked git logs.
> >>
> >> How did you come up with such a conclusion? Something doesn't work on
> your side?
> >>
> >> —
> >> Denis
> >>
> >>> On Dec 10, 2016, at 5:39 AM, 李玉珏@163 <[hidden email]> wrote:
> >>>
> >>> Hi：
> >>>
> >>>
> >>> IGNITE-3727,this issue has been fixed and tested in september，why did
> not merge into the 1.8 version?
> >>>
> >>>
> >
>
>

李玉珏@163

Re: IGNITE-3727： why did not merge into the 1.8 version?

Semen Boikov,

This issue is very important to our development environment, we have now
used other techniques to replace.
I very much hope that this patch can be merged into the next version,
very grateful!

在 2016/12/13 16:18, Semyon Boikov 写道:

> Hi,
>
> We had a lot of more priority issues so I somehow missed IGNITE-3732. As a
> workaround it is possible to create special thread pool and when message is
> sent to local node execute message listener there instead of
> IgniteMessaging usage.
>
> Thanks
>
> On Sun, Dec 11, 2016 at 5:56 AM, Denis Magda <[hidden email]> wrote:
>
>> Alright, looks like I confused it with some other task initially.
>>
>> The ticket you’re talking about is still under review and looks abandoned
>> https://issues.apache.org/jira/browse/IGNITE-3727 <
>> https://issues.apache.org/jira/browse/IGNITE-3727>
>>
>> Dmitriy G., Sam, is the ticket ready for the merge?
>>
>> —
>> Denis
>>
>>> On Dec 10, 2016, at 6:29 PM, 李玉珏@163 <[hidden email]> wrote:
>>>
>>> Denis，
>>>
>>> I found the branch 3727:
>>>
>>> https://github.com/gridgain/apache-ignite/tree/ignite-3727-2
>>>
>>> But it appear that the code is not merged into the master?
>>>
>>> for example, IgniteMessagingImpl.java,the related code is still an old
>> version,8 months ago.
>>>
>>> 在 2016/12/10 22:56, Denis Magda 写道:
>>>> Hi,
>>>>
>>>> It was released in 1.8. I’ve just checked git logs.
>>>>
>>>> How did you come up with such a conclusion? Something doesn't work on
>> your side?
>>>> —
>>>> Denis
>>>>
>>>>> On Dec 10, 2016, at 5:39 AM, 李玉珏@163 <[hidden email]> wrote:
>>>>>
>>>>> Hi：
>>>>>
>>>>>
>>>>> IGNITE-3727,this issue has been fixed and tested in september，why did
>> not merge into the 1.8 version?
>>>>>
>>

李玉珏@163

Re: IGNITE-3727： why did not merge into the 1.8 version?

In reply to this post by Semyon Boikov

Semen,

Can this issue be merged into version 1.9?

在 2016/12/13 16:18, Semyon Boikov 写道:

Semyon Boikov

Re: IGNITE-3727： why did not merge into the 1.8 version?

OK, I'll try to review/merge it today.

Thanks!

On Tue, Feb 14, 2017 at 3:20 PM, 李玉珏@163 <[hidden email]> wrote:

> Semen,
>
>
> Can this issue be merged into version 1.9?
>
>
> 在 2016/12/13 16:18, Semyon Boikov 写道:
>
>> Hi,
>>
>> We had a lot of more priority issues so I somehow missed IGNITE-3732. As a
>> workaround it is possible to create special thread pool and when message
>> is
>> sent to local node execute message listener there instead of
>> IgniteMessaging usage.
>>
>> Thanks
>>
>> On Sun, Dec 11, 2016 at 5:56 AM, Denis Magda <[hidden email]> wrote:
>>
>> Alright, looks like I confused it with some other task initially.
>>>
>>> The ticket you’re talking about is still under review and looks abandoned
>>> https://issues.apache.org/jira/browse/IGNITE-3727 <
>>> https://issues.apache.org/jira/browse/IGNITE-3727>
>>>
>>> Dmitriy G., Sam, is the ticket ready for the merge?
>>>
>>> —
>>> Denis
>>>
>>> On Dec 10, 2016, at 6:29 PM, 李玉珏@163 <[hidden email]> wrote:
>>>>
>>>> Denis，
>>>>
>>>> I found the branch 3727:
>>>>
>>>> https://github.com/gridgain/apache-ignite/tree/ignite-3727-2
>>>>
>>>> But it appear that the code is not merged into the master?
>>>>
>>>> for example, IgniteMessagingImpl.java,the related code is still an old
>>>>
>>> version,8 months ago.
>>>
>>>>
>>>> 在 2016/12/10 22:56, Denis Magda 写道:
>>>>
>>>>> Hi,
>>>>>
>>>>> It was released in 1.8. I’ve just checked git logs.
>>>>>
>>>>> How did you come up with such a conclusion? Something doesn't work on
>>>>>
>>>> your side?
>>>
>>>> —
>>>>> Denis
>>>>>
>>>>> On Dec 10, 2016, at 5:39 AM, 李玉珏@163 <[hidden email]> wrote:
>>>>>>
>>>>>> Hi：
>>>>>>
>>>>>>
>>>>>> IGNITE-3727,this issue has been fixed and tested in september，why did
>>>>>>
>>>>> not merge into the 1.8 version?
>>>
>>>>
>>>>>>
>>>
>
>