IGNITE-3263 Affinity function must check for null keys

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

IGNITE-3263 Affinity function must check for null keys

Saikat Maitra
Hi,

I have raised PR[1] for the following jira ticket[2].

Please review and let me know if any changes required.

I have added an example to demonstrate the change is working fine and
tested but was not able to reproduce the exception scenario using unit
tests.


Regards,
Saikat

[1] https://github.com/apache/ignite/pull/926
[2] https://issues.apache.org/jira/browse/IGNITE-3263
Reply | Threaded
Open this post in threaded view
|

Re: IGNITE-3263 Affinity function must check for null keys

Denis Magda
Hi Saikat,

Thanks for keep contributing! I’ve reviewed your changes and left comments in JIRA.


Denis

> On Aug 7, 2016, at 2:11 AM, Saikat Maitra <[hidden email]> wrote:
>
> Hi,
>
> I have raised PR[1] for the following jira ticket[2].
>
> Please review and let me know if any changes required.
>
> I have added an example to demonstrate the change is working fine and
> tested but was not able to reproduce the exception scenario using unit
> tests.
>
>
> Regards,
> Saikat
>
> [1] https://github.com/apache/ignite/pull/926
> [2] https://issues.apache.org/jira/browse/IGNITE-3263

Reply | Threaded
Open this post in threaded view
|

Re: IGNITE-3263 Affinity function must check for null keys

Saikat Maitra
Thank you Denis. I will update the PR accordingly.

Regards
Saikat

On Tue, Aug 9, 2016 at 3:39 AM, Denis Magda <[hidden email]> wrote:

> Hi Saikat,
>
> Thanks for keep contributing! I’ve reviewed your changes and left comments
> in JIRA.
>
> —
> Denis
>
> > On Aug 7, 2016, at 2:11 AM, Saikat Maitra <[hidden email]>
> wrote:
> >
> > Hi,
> >
> > I have raised PR[1] for the following jira ticket[2].
> >
> > Please review and let me know if any changes required.
> >
> > I have added an example to demonstrate the change is working fine and
> > tested but was not able to reproduce the exception scenario using unit
> > tests.
> >
> >
> > Regards,
> > Saikat
> >
> > [1] https://github.com/apache/ignite/pull/926
> > [2] https://issues.apache.org/jira/browse/IGNITE-3263
>
>