IGNITE-2313 - ready for review

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

IGNITE-2313 - ready for review

Dmitrii Ryabov
Reply | Threaded
Open this post in threaded view
|

Re: IGNITE-2313 - ready for review

dmagda
Dmitriy R., may I ask you to make a title and description of review request more meaningful? Looking at email's subject and body neither me nor anyone else have an idea what you ask to review. As a result most of community members will simply ignore your review request skipping the message. Don’t force people to go to JIRA ;)

Igniters,

This is the ticket to be reviewed: "Need to add a mode to fail atomic operations within a transaction”. Please review it.

Dmitriy R., there was a relevant discussion around the ticket. Would you paste a link to it there?


Denis


> On Apr 5, 2017, at 4:12 AM, Дмитрий Рябов <[hidden email]> wrote:
>
> Hello, please review.
>
> PR: https://github.com/apache/ignite/pull/1709/files
> JIRA: https://issues.apache.org/jira/browse/IGNITE-2313
> CI:
> http://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests_RatJavadoc&branch_IgniteTests=pull%2F1709%2Fhead&tab=buildTypeStatusDiv

Reply | Threaded
Open this post in threaded view
|

Re: IGNITE-2313 - ready for review

Dmitrii Ryabov
Em... sorry, always forgot about meaningful title(

Discussion? Yeah, I'll do it.

2017-04-05 22:15 GMT+03:00 Denis Magda <[hidden email]>:

> Dmitriy R., may I ask you to make a title and description of review
> request more meaningful? Looking at email's subject and body neither me nor
> anyone else have an idea what you ask to review. As a result most of
> community members will simply ignore your review request skipping the
> message. Don’t force people to go to JIRA ;)
>
> Igniters,
>
> This is the ticket to be reviewed: "Need to add a mode to fail atomic
> operations within a transaction”. Please review it.
>
> Dmitriy R., there was a relevant discussion around the ticket. Would you
> paste a link to it there?
>
> —
> Denis
>
>
> > On Apr 5, 2017, at 4:12 AM, Дмитрий Рябов <[hidden email]> wrote:
> >
> > Hello, please review.
> >
> > PR: https://github.com/apache/ignite/pull/1709/files
> > JIRA: https://issues.apache.org/jira/browse/IGNITE-2313
> > CI:
> > http://ci.ignite.apache.org/viewType.html?buildTypeId=
> IgniteTests_RatJavadoc&branch_IgniteTests=pull%2F1709%
> 2Fhead&tab=buildTypeStatusDiv
>
>