Apache Ignite Developers - Legacy Mail Archive

IGNITE-12951 Update documents for migrated extensions

Classic

List

Threaded

6 messages Options

Saikat Maitra

IGNITE-12951 Update documents for migrated extensions

Hi,

I have raised a PR for the below jira issue.

https://issues.apache.org/jira/browse/IGNITE-12951 - Update documents for
migrated extensions

PR : https://github.com/apache/ignite-website/pull/85

Please review and share feedback.

Regards,
Saikat

Никита Сафонов

Re: IGNITE-12951 Update documents for migrated extensions

Hi Saikat,

I have reviewed the changes in the PR and left a couple of suggested
changes.
You can apply them directly in the PR:
https://github.com/apache/ignite-website/pull/85

The rest looks good to me, thanks for your work!

Regards,
Nikita

пн, 22 мар. 2021 г. в 01:02, Saikat Maitra <[hidden email]>:

> Hi,
>
> I have raised a PR for the below jira issue.
>
> https://issues.apache.org/jira/browse/IGNITE-12951 - Update documents for
> migrated extensions
>
> PR : https://github.com/apache/ignite-website/pull/85
>
> Please review and share feedback.
>
> Regards,
> Saikat
>

Saikat Maitra

Re: IGNITE-12951 Update documents for migrated extensions

Hi Nikita,

Thank you for the review and suggestions on the changes. I will apply them
in the PR.

Quick question on the merge process, I think we are directly merging PR for
ignite-website in github using the UI, is it correct?

I still follow apply pull request script for ignite repo as mentioned here
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-Informationforcommitters

Regards,
Saikat

On Mon, Mar 22, 2021 at 9:59 AM Никита Сафонов <[hidden email]>
wrote:

> Hi Saikat,
>
> I have reviewed the changes in the PR and left a couple of suggested
> changes.
> You can apply them directly in the PR:
> https://github.com/apache/ignite-website/pull/85
>
> The rest looks good to me, thanks for your work!
>
> Regards,
> Nikita
>
> пн, 22 мар. 2021 г. в 01:02, Saikat Maitra <[hidden email]>:
>
> > Hi,
> >
> > I have raised a PR for the below jira issue.
> >
> > https://issues.apache.org/jira/browse/IGNITE-12951 - Update documents
> for
> > migrated extensions
> >
> > PR : https://github.com/apache/ignite-website/pull/85
> >
> > Please review and share feedback.
> >
> > Regards,
> > Saikat
> >
>

Saikat Maitra

Re: IGNITE-12951 Update documents for migrated extensions

Hi Nikita,

I have taken all your suggested changes. It seems I do not have merge
access for ignite-website repo. Can you please help merge the PR?

https://github.com/apache/ignite-website/pull/85

Regards,
Saikat

On Mon, Mar 22, 2021 at 7:22 PM Saikat Maitra <[hidden email]>
wrote:

> Hi Nikita,
>
> Thank you for the review and suggestions on the changes. I will apply them
> in the PR.
>
> Quick question on the merge process, I think we are directly merging PR
> for ignite-website in github using the UI, is it correct?
>
> I still follow apply pull request script for ignite repo as mentioned here
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-Informationforcommitters
>
> Regards,
> Saikat
>
>
> On Mon, Mar 22, 2021 at 9:59 AM Никита Сафонов <[hidden email]>
> wrote:
>
>> Hi Saikat,
>>
>> I have reviewed the changes in the PR and left a couple of suggested
>> changes.
>> You can apply them directly in the PR:
>> https://github.com/apache/ignite-website/pull/85
>>
>> The rest looks good to me, thanks for your work!
>>
>> Regards,
>> Nikita
>>
>> пн, 22 мар. 2021 г. в 01:02, Saikat Maitra <[hidden email]>:
>>
>> > Hi,
>> >
>> > I have raised a PR for the below jira issue.
>> >
>> > https://issues.apache.org/jira/browse/IGNITE-12951 - Update documents
>> for
>> > migrated extensions
>> >
>> > PR : https://github.com/apache/ignite-website/pull/85
>> >
>> > Please review and share feedback.
>> >
>> > Regards,
>> > Saikat
>> >
>>
>

dmagda

Re: IGNITE-12951 Update documents for migrated extensions

Hey Saikat,

I merged the PR. As a committer, you should have access to the repo. Are
you on the committers list of the ASF org? https://github.com/apache

-
Denis

On Mon, Mar 22, 2021 at 8:42 PM Saikat Maitra <[hidden email]>
wrote:

> Hi Nikita,
>
> I have taken all your suggested changes. It seems I do not have merge
> access for ignite-website repo. Can you please help merge the PR?
>
> https://github.com/apache/ignite-website/pull/85
>
> Regards,
> Saikat
>
> On Mon, Mar 22, 2021 at 7:22 PM Saikat Maitra <[hidden email]>
> wrote:
>
> > Hi Nikita,
> >
> > Thank you for the review and suggestions on the changes. I will apply
> them
> > in the PR.
> >
> > Quick question on the merge process, I think we are directly merging PR
> > for ignite-website in github using the UI, is it correct?
> >
> > I still follow apply pull request script for ignite repo as mentioned
> here
> >
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-Informationforcommitters
> >
> > Regards,
> > Saikat
> >
> >
> > On Mon, Mar 22, 2021 at 9:59 AM Никита Сафонов <
> [hidden email]>
> > wrote:
> >
> >> Hi Saikat,
> >>
> >> I have reviewed the changes in the PR and left a couple of suggested
> >> changes.
> >> You can apply them directly in the PR:
> >> https://github.com/apache/ignite-website/pull/85
> >>
> >> The rest looks good to me, thanks for your work!
> >>
> >> Regards,
> >> Nikita
> >>
> >> пн, 22 мар. 2021 г. в 01:02, Saikat Maitra <[hidden email]>:
> >>
> >> > Hi,
> >> >
> >> > I have raised a PR for the below jira issue.
> >> >
> >> > https://issues.apache.org/jira/browse/IGNITE-12951 - Update documents
> >> for
> >> > migrated extensions
> >> >
> >> > PR : https://github.com/apache/ignite-website/pull/85
> >> >
> >> > Please review and share feedback.
> >> >
> >> > Regards,
> >> > Saikat
> >> >
> >>
> >
>

Saikat Maitra

Re: IGNITE-12951 Update documents for migrated extensions

Hi Denis,

Thank you so much for merging the changes, yes I am part of committers list
of the ASF org.

I will again check my access with another PR.

Regards,
Saikat

On Mon, Mar 22, 2021 at 7:49 PM Denis Magda <[hidden email]> wrote:

> Hey Saikat,
>
> I merged the PR. As a committer, you should have access to the repo. Are
> you on the committers list of the ASF org? https://github.com/apache
>
> -
> Denis
>
>
> On Mon, Mar 22, 2021 at 8:42 PM Saikat Maitra <[hidden email]>
> wrote:
>
> > Hi Nikita,
> >
> > I have taken all your suggested changes. It seems I do not have merge
> > access for ignite-website repo. Can you please help merge the PR?
> >
> > https://github.com/apache/ignite-website/pull/85
> >
> > Regards,
> > Saikat
> >
> > On Mon, Mar 22, 2021 at 7:22 PM Saikat Maitra <[hidden email]>
> > wrote:
> >
> > > Hi Nikita,
> > >
> > > Thank you for the review and suggestions on the changes. I will apply
> > them
> > > in the PR.
> > >
> > > Quick question on the merge process, I think we are directly merging PR
> > > for ignite-website in github using the UI, is it correct?
> > >
> > > I still follow apply pull request script for ignite repo as mentioned
> > here
> > >
> >
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-Informationforcommitters
> > >
> > > Regards,
> > > Saikat
> > >
> > >
> > > On Mon, Mar 22, 2021 at 9:59 AM Никита Сафонов <
> > [hidden email]>
> > > wrote:
> > >
> > >> Hi Saikat,
> > >>
> > >> I have reviewed the changes in the PR and left a couple of suggested
> > >> changes.
> > >> You can apply them directly in the PR:
> > >> https://github.com/apache/ignite-website/pull/85
> > >>
> > >> The rest looks good to me, thanks for your work!
> > >>
> > >> Regards,
> > >> Nikita
> > >>
> > >> пн, 22 мар. 2021 г. в 01:02, Saikat Maitra <[hidden email]>:
> > >>
> > >> > Hi,
> > >> >
> > >> > I have raised a PR for the below jira issue.
> > >> >
> > >> > https://issues.apache.org/jira/browse/IGNITE-12951 - Update
> documents
> > >> for
> > >> > migrated extensions
> > >> >
> > >> > PR : https://github.com/apache/ignite-website/pull/85
> > >> >
> > >> > Please review and share feedback.
> > >> >
> > >> > Regards,
> > >> > Saikat
> > >> >
> > >>
> > >
> >
>