Hi,
I have raised PR for Ignite Flume migration to Ignite Extensions repo. Jira https://issues.apache.org/jira/browse/IGNITE-12361 PR https://github.com/apache/ignite-extensions/pull/4 https://github.com/apache/ignite/pull/7227 Please review and share feedback. This is part of our Modularization effort for Streamer modules https://issues.apache.org/jira/browse/IGNITE-12355 Regards, Saikat |
Hello,
These PRs are part of Modularization effort https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations If the changes looks good, I can go ahead and merge the changes. Regards, Saikat On Sun, Jan 5, 2020 at 1:08 PM Saikat Maitra <[hidden email]> wrote: > Hi, > > I have raised PR for Ignite Flume migration to Ignite Extensions repo. > > Jira https://issues.apache.org/jira/browse/IGNITE-12361 > > PR https://github.com/apache/ignite-extensions/pull/4 > https://github.com/apache/ignite/pull/7227 > > Please review and share feedback. > > This is part of our Modularization effort for Streamer modules > > https://issues.apache.org/jira/browse/IGNITE-12355 > > Regards, > Saikat > |
Alex Goncharuk, Nikolay Izhikov,
Could you possibly check the changes or suggest any other committer/contributor for that? - Denis On Sun, Jan 12, 2020 at 9:31 AM Saikat Maitra <[hidden email]> wrote: > Hello, > > These PRs are part of Modularization effort > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations > > If the changes looks good, I can go ahead and merge the changes. > > Regards, > Saikat > > On Sun, Jan 5, 2020 at 1:08 PM Saikat Maitra <[hidden email]> > wrote: > > > Hi, > > > > I have raised PR for Ignite Flume migration to Ignite Extensions repo. > > > > Jira https://issues.apache.org/jira/browse/IGNITE-12361 > > > > PR https://github.com/apache/ignite-extensions/pull/4 > > https://github.com/apache/ignite/pull/7227 > > > > Please review and share feedback. > > > > This is part of our Modularization effort for Streamer modules > > > > https://issues.apache.org/jira/browse/IGNITE-12355 > > > > Regards, > > Saikat > > > |
Saikat,
Thanks for working on this! I'll do my best to take a look at it this week. --AG пн, 13 янв. 2020 г. в 21:37, Denis Magda <[hidden email]>: > Alex Goncharuk, Nikolay Izhikov, > > Could you possibly check the changes or suggest any other > committer/contributor for that? > > - > Denis > > > On Sun, Jan 12, 2020 at 9:31 AM Saikat Maitra <[hidden email]> > wrote: > >> Hello, >> >> These PRs are part of Modularization effort >> >> https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations >> >> If the changes looks good, I can go ahead and merge the changes. >> >> Regards, >> Saikat >> >> On Sun, Jan 5, 2020 at 1:08 PM Saikat Maitra <[hidden email]> >> wrote: >> >> > Hi, >> > >> > I have raised PR for Ignite Flume migration to Ignite Extensions repo. >> > >> > Jira https://issues.apache.org/jira/browse/IGNITE-12361 >> > >> > PR https://github.com/apache/ignite-extensions/pull/4 >> > https://github.com/apache/ignite/pull/7227 >> > >> > Please review and share feedback. >> > >> > This is part of our Modularization effort for Streamer modules >> > >> > https://issues.apache.org/jira/browse/IGNITE-12355 >> > >> > Regards, >> > Saikat >> > >> > |
Hi Denis, Alexey
Thank you so much for your email. I really appreciate it. Regards, Saikat On Wed, Jan 15, 2020 at 4:11 AM Alexey Goncharuk <[hidden email]> wrote: > Saikat, > > Thanks for working on this! I'll do my best to take a look at it this week. > > --AG > > пн, 13 янв. 2020 г. в 21:37, Denis Magda <[hidden email]>: > > > Alex Goncharuk, Nikolay Izhikov, > > > > Could you possibly check the changes or suggest any other > > committer/contributor for that? > > > > - > > Denis > > > > > > On Sun, Jan 12, 2020 at 9:31 AM Saikat Maitra <[hidden email]> > > wrote: > > > >> Hello, > >> > >> These PRs are part of Modularization effort > >> > >> > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations > >> > >> If the changes looks good, I can go ahead and merge the changes. > >> > >> Regards, > >> Saikat > >> > >> On Sun, Jan 5, 2020 at 1:08 PM Saikat Maitra <[hidden email]> > >> wrote: > >> > >> > Hi, > >> > > >> > I have raised PR for Ignite Flume migration to Ignite Extensions repo. > >> > > >> > Jira https://issues.apache.org/jira/browse/IGNITE-12361 > >> > > >> > PR https://github.com/apache/ignite-extensions/pull/4 > >> > https://github.com/apache/ignite/pull/7227 > >> > > >> > Please review and share feedback. > >> > > >> > This is part of our Modularization effort for Streamer modules > >> > > >> > https://issues.apache.org/jira/browse/IGNITE-12355 > >> > > >> > Regards, > >> > Saikat > >> > > >> > > > |
Saikat,
Code-wise the PR looks ok because it basically moves the module to another repo. I have some infrastructure/process questions though before we merge the PRs * I see that there are some objections from Alexey Zinoviev [1] on whether the streaming modules should be placed in extensions or in a separate streaming project. Sorry if I missed the corresponding discussion on the dev-list. If there is one, we need to edit the IEP page, if not, I think we should come to a consensus before making this change * When are we planning to release the extensions? Are we going to release them one-by-one incrementally or do we want to release them in one batch? * Now that the release lifecycle of Ignite and extensions is split, we need to understand how this is going to be tested. Will we run a candidate Ignite build against already released extensions? What if we make changes to both Ignite and an extension? Is it even allowed, or do we need to wait for an Ignite release before making any changes in an extension? * I think there should be some sort of compatibility matrix now that releases of Ignite and extensions are separated I would not delete the extension from Ignite codebase until we agree on the points above. Would you mind taking care of the discussion about it and formalizing it on the wiki? чт, 16 янв. 2020 г. в 06:27, Saikat Maitra <[hidden email]>: > Hi Denis, Alexey > > Thank you so much for your email. I really appreciate it. > > Regards, > Saikat > > On Wed, Jan 15, 2020 at 4:11 AM Alexey Goncharuk < > [hidden email]> > wrote: > > > Saikat, > > > > Thanks for working on this! I'll do my best to take a look at it this > week. > > > > --AG > > > > пн, 13 янв. 2020 г. в 21:37, Denis Magda <[hidden email]>: > > > > > Alex Goncharuk, Nikolay Izhikov, > > > > > > Could you possibly check the changes or suggest any other > > > committer/contributor for that? > > > > > > - > > > Denis > > > > > > > > > On Sun, Jan 12, 2020 at 9:31 AM Saikat Maitra <[hidden email] > > > > > wrote: > > > > > >> Hello, > > >> > > >> These PRs are part of Modularization effort > > >> > > >> > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations > > >> > > >> If the changes looks good, I can go ahead and merge the changes. > > >> > > >> Regards, > > >> Saikat > > >> > > >> On Sun, Jan 5, 2020 at 1:08 PM Saikat Maitra <[hidden email] > > > > >> wrote: > > >> > > >> > Hi, > > >> > > > >> > I have raised PR for Ignite Flume migration to Ignite Extensions > repo. > > >> > > > >> > Jira https://issues.apache.org/jira/browse/IGNITE-12361 > > >> > > > >> > PR https://github.com/apache/ignite-extensions/pull/4 > > >> > https://github.com/apache/ignite/pull/7227 > > >> > > > >> > Please review and share feedback. > > >> > > > >> > This is part of our Modularization effort for Streamer modules > > >> > > > >> > https://issues.apache.org/jira/browse/IGNITE-12355 > > >> > > > >> > Regards, > > >> > Saikat > > >> > > > >> > > > > > > |
Hello Alexey,
Thank you for your email. 1. Yes, we discussed in dev list and agreed on creating a new repository for hosting our Ignite integrations. Please find the discussion thread below. I will update the wiki page as well and share updates. http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSS-Proposal-for-Ignite-Extensions-as-a-separate-Bahir-module-or-Incubator-project-td44064.html 2. I was hoping to complete migration of the following modules before we go ahead with release. I am tracking the jira story here https://issues.apache.org/jira/browse/IGNITE-12355 - Flink - Storm - ZeroMQ - RocketMQ - Flume - MQTT - Camel - JMS 3. The dependencies for modules are pointing to latest snapshot of ignite project and if there are changes in ignite master branch then related affected Ignite extensions module also need to be modified. We will verify all the extensions for upcoming release but release only the one that are impacted. We will plan to avoid publishing any extension unless there are changes. Here is the discussion thread on release process: http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSS-dependencies-and-release-process-for-Ignite-Extensions-td44478.html 4. Sounds good, we can maintain a compatibility matrix to ensure we can share Ignite Core and related Ignite Extensions. I have seen something similar in Apache Beam and we can also create a similar wiki page to maintain Ignite Core and Ignite Extensions dependencies https://beam.apache.org/documentation/runners/capability-matrix/ Regards, Saikat On Fri, Jan 17, 2020 at 6:27 AM Alexey Goncharuk <[hidden email]> wrote: > Saikat, > > Code-wise the PR looks ok because it basically moves the module to another > repo. I have some infrastructure/process questions though before we merge > the PRs > * I see that there are some objections from Alexey Zinoviev [1] on whether > the streaming modules should be placed in extensions or in a separate > streaming project. Sorry if I missed the corresponding discussion on the > dev-list. If there is one, we need to edit the IEP page, if not, I think we > should come to a consensus before making this change > * When are we planning to release the extensions? Are we going to release > them one-by-one incrementally or do we want to release them in one batch? > * Now that the release lifecycle of Ignite and extensions is split, we > need to understand how this is going to be tested. Will we run a candidate > Ignite build against already released extensions? What if we make changes > to both Ignite and an extension? Is it even allowed, or do we need to wait > for an Ignite release before making any changes in an extension? > * I think there should be some sort of compatibility matrix now that > releases of Ignite and extensions are separated > > I would not delete the extension from Ignite codebase until we agree on the > points above. > > Would you mind taking care of the discussion about it and formalizing it on > the wiki? > > чт, 16 янв. 2020 г. в 06:27, Saikat Maitra <[hidden email]>: > > > Hi Denis, Alexey > > > > Thank you so much for your email. I really appreciate it. > > > > Regards, > > Saikat > > > > On Wed, Jan 15, 2020 at 4:11 AM Alexey Goncharuk < > > [hidden email]> > > wrote: > > > > > Saikat, > > > > > > Thanks for working on this! I'll do my best to take a look at it this > > week. > > > > > > --AG > > > > > > пн, 13 янв. 2020 г. в 21:37, Denis Magda <[hidden email]>: > > > > > > > Alex Goncharuk, Nikolay Izhikov, > > > > > > > > Could you possibly check the changes or suggest any other > > > > committer/contributor for that? > > > > > > > > - > > > > Denis > > > > > > > > > > > > On Sun, Jan 12, 2020 at 9:31 AM Saikat Maitra < > [hidden email] > > > > > > > wrote: > > > > > > > >> Hello, > > > >> > > > >> These PRs are part of Modularization effort > > > >> > > > >> > > > > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations > > > >> > > > >> If the changes looks good, I can go ahead and merge the changes. > > > >> > > > >> Regards, > > > >> Saikat > > > >> > > > >> On Sun, Jan 5, 2020 at 1:08 PM Saikat Maitra < > [hidden email] > > > > > > >> wrote: > > > >> > > > >> > Hi, > > > >> > > > > >> > I have raised PR for Ignite Flume migration to Ignite Extensions > > repo. > > > >> > > > > >> > Jira https://issues.apache.org/jira/browse/IGNITE-12361 > > > >> > > > > >> > PR https://github.com/apache/ignite-extensions/pull/4 > > > >> > https://github.com/apache/ignite/pull/7227 > > > >> > > > > >> > Please review and share feedback. > > > >> > > > > >> > This is part of our Modularization effort for Streamer modules > > > >> > > > > >> > https://issues.apache.org/jira/browse/IGNITE-12355 > > > >> > > > > >> > Regards, > > > >> > Saikat > > > >> > > > > >> > > > > > > > > > > |
Hi Alexey,
As discussed I have updated the wiki with agreed solution. Independent Integrations: https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations Discussion Links: https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-DiscussionLinks Tickets: https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-Tickets Please let me know if I can share more information. Regards, Saikat On Fri, Jan 17, 2020 at 9:16 PM Saikat Maitra <[hidden email]> wrote: > Hello Alexey, > > Thank you for your email. > > 1. Yes, we discussed in dev list and agreed on creating a new repository > for hosting our Ignite integrations. Please find the discussion thread > below. I will update the wiki page as well and share updates. > > > http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSS-Proposal-for-Ignite-Extensions-as-a-separate-Bahir-module-or-Incubator-project-td44064.html > > 2. I was hoping to complete migration of the following modules before we > go ahead with release. I am tracking the jira story here > https://issues.apache.org/jira/browse/IGNITE-12355 > > - Flink > - Storm > - ZeroMQ > - RocketMQ > - Flume > - MQTT > - Camel > - JMS > > 3. The dependencies for modules are pointing to latest snapshot of ignite > project and if there are changes in ignite master branch then related > affected Ignite extensions module also need to be modified. We will verify > all the extensions for upcoming release but release only the one that are > impacted. We will plan to avoid publishing any extension unless there are > changes. Here is the discussion thread on release process: > > > http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSS-dependencies-and-release-process-for-Ignite-Extensions-td44478.html > > 4. Sounds good, we can maintain a compatibility matrix to ensure we can > share Ignite Core and related Ignite Extensions. I have seen something > similar in Apache Beam and we can also create a similar wiki page to > maintain Ignite Core and Ignite Extensions dependencies > > https://beam.apache.org/documentation/runners/capability-matrix/ > > Regards, > Saikat > > > > On Fri, Jan 17, 2020 at 6:27 AM Alexey Goncharuk < > [hidden email]> wrote: > >> Saikat, >> >> Code-wise the PR looks ok because it basically moves the module to another >> repo. I have some infrastructure/process questions though before we merge >> the PRs >> * I see that there are some objections from Alexey Zinoviev [1] on >> whether >> the streaming modules should be placed in extensions or in a separate >> streaming project. Sorry if I missed the corresponding discussion on the >> dev-list. If there is one, we need to edit the IEP page, if not, I think >> we >> should come to a consensus before making this change >> * When are we planning to release the extensions? Are we going to release >> them one-by-one incrementally or do we want to release them in one batch? >> * Now that the release lifecycle of Ignite and extensions is split, we >> need to understand how this is going to be tested. Will we run a candidate >> Ignite build against already released extensions? What if we make changes >> to both Ignite and an extension? Is it even allowed, or do we need to wait >> for an Ignite release before making any changes in an extension? >> * I think there should be some sort of compatibility matrix now that >> releases of Ignite and extensions are separated >> >> I would not delete the extension from Ignite codebase until we agree on >> the >> points above. >> >> Would you mind taking care of the discussion about it and formalizing it >> on >> the wiki? >> >> чт, 16 янв. 2020 г. в 06:27, Saikat Maitra <[hidden email]>: >> >> > Hi Denis, Alexey >> > >> > Thank you so much for your email. I really appreciate it. >> > >> > Regards, >> > Saikat >> > >> > On Wed, Jan 15, 2020 at 4:11 AM Alexey Goncharuk < >> > [hidden email]> >> > wrote: >> > >> > > Saikat, >> > > >> > > Thanks for working on this! I'll do my best to take a look at it this >> > week. >> > > >> > > --AG >> > > >> > > пн, 13 янв. 2020 г. в 21:37, Denis Magda <[hidden email]>: >> > > >> > > > Alex Goncharuk, Nikolay Izhikov, >> > > > >> > > > Could you possibly check the changes or suggest any other >> > > > committer/contributor for that? >> > > > >> > > > - >> > > > Denis >> > > > >> > > > >> > > > On Sun, Jan 12, 2020 at 9:31 AM Saikat Maitra < >> [hidden email] >> > > >> > > > wrote: >> > > > >> > > >> Hello, >> > > >> >> > > >> These PRs are part of Modularization effort >> > > >> >> > > >> >> > > >> > >> https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations >> > > >> >> > > >> If the changes looks good, I can go ahead and merge the changes. >> > > >> >> > > >> Regards, >> > > >> Saikat >> > > >> >> > > >> On Sun, Jan 5, 2020 at 1:08 PM Saikat Maitra < >> [hidden email] >> > > >> > > >> wrote: >> > > >> >> > > >> > Hi, >> > > >> > >> > > >> > I have raised PR for Ignite Flume migration to Ignite Extensions >> > repo. >> > > >> > >> > > >> > Jira https://issues.apache.org/jira/browse/IGNITE-12361 >> > > >> > >> > > >> > PR https://github.com/apache/ignite-extensions/pull/4 >> > > >> > https://github.com/apache/ignite/pull/7227 >> > > >> > >> > > >> > Please review and share feedback. >> > > >> > >> > > >> > This is part of our Modularization effort for Streamer modules >> > > >> > >> > > >> > https://issues.apache.org/jira/browse/IGNITE-12355 >> > > >> > >> > > >> > Regards, >> > > >> > Saikat >> > > >> > >> > > >> >> > > > >> > > >> > >> > |
Hi Alexey,
Please let me know if I can share more info on the release process. I have updated the issue confluence page on discussed approach for Ignite Extensions. Do you think the open PRs can be merged in Ignite Extensions repo? Independent Integrations: https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations Discussion Links: https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-DiscussionLinks Tickets: https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-Tickets Regards, Saikat On Sun, Jan 26, 2020 at 3:11 PM Saikat Maitra <[hidden email]> wrote: > Hi Alexey, > > As discussed I have updated the wiki with agreed solution. > > Independent Integrations: > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations > > Discussion Links: > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-DiscussionLinks > > Tickets: > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-Tickets > > Please let me know if I can share more information. > > Regards, > Saikat > > > On Fri, Jan 17, 2020 at 9:16 PM Saikat Maitra <[hidden email]> > wrote: > >> Hello Alexey, >> >> Thank you for your email. >> >> 1. Yes, we discussed in dev list and agreed on creating a new repository >> for hosting our Ignite integrations. Please find the discussion thread >> below. I will update the wiki page as well and share updates. >> >> >> http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSS-Proposal-for-Ignite-Extensions-as-a-separate-Bahir-module-or-Incubator-project-td44064.html >> >> 2. I was hoping to complete migration of the following modules before we >> go ahead with release. I am tracking the jira story here >> https://issues.apache.org/jira/browse/IGNITE-12355 >> >> - Flink >> - Storm >> - ZeroMQ >> - RocketMQ >> - Flume >> - MQTT >> - Camel >> - JMS >> >> 3. The dependencies for modules are pointing to latest snapshot of >> ignite project and if there are changes in ignite master branch then >> related affected Ignite extensions module also need to be modified. We will >> verify all the extensions for upcoming release but release only the one >> that are impacted. We will plan to avoid publishing any extension unless >> there are changes. Here is the discussion thread on release process: >> >> >> http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSS-dependencies-and-release-process-for-Ignite-Extensions-td44478.html >> >> 4. Sounds good, we can maintain a compatibility matrix to ensure we can >> share Ignite Core and related Ignite Extensions. I have seen something >> similar in Apache Beam and we can also create a similar wiki page to >> maintain Ignite Core and Ignite Extensions dependencies >> >> https://beam.apache.org/documentation/runners/capability-matrix/ >> >> Regards, >> Saikat >> >> >> >> On Fri, Jan 17, 2020 at 6:27 AM Alexey Goncharuk < >> [hidden email]> wrote: >> >>> Saikat, >>> >>> Code-wise the PR looks ok because it basically moves the module to >>> another >>> repo. I have some infrastructure/process questions though before we merge >>> the PRs >>> * I see that there are some objections from Alexey Zinoviev [1] on >>> whether >>> the streaming modules should be placed in extensions or in a separate >>> streaming project. Sorry if I missed the corresponding discussion on the >>> dev-list. If there is one, we need to edit the IEP page, if not, I think >>> we >>> should come to a consensus before making this change >>> * When are we planning to release the extensions? Are we going to >>> release >>> them one-by-one incrementally or do we want to release them in one batch? >>> * Now that the release lifecycle of Ignite and extensions is split, we >>> need to understand how this is going to be tested. Will we run a >>> candidate >>> Ignite build against already released extensions? What if we make changes >>> to both Ignite and an extension? Is it even allowed, or do we need to >>> wait >>> for an Ignite release before making any changes in an extension? >>> * I think there should be some sort of compatibility matrix now that >>> releases of Ignite and extensions are separated >>> >>> I would not delete the extension from Ignite codebase until we agree on >>> the >>> points above. >>> >>> Would you mind taking care of the discussion about it and formalizing it >>> on >>> the wiki? >>> >>> чт, 16 янв. 2020 г. в 06:27, Saikat Maitra <[hidden email]>: >>> >>> > Hi Denis, Alexey >>> > >>> > Thank you so much for your email. I really appreciate it. >>> > >>> > Regards, >>> > Saikat >>> > >>> > On Wed, Jan 15, 2020 at 4:11 AM Alexey Goncharuk < >>> > [hidden email]> >>> > wrote: >>> > >>> > > Saikat, >>> > > >>> > > Thanks for working on this! I'll do my best to take a look at it this >>> > week. >>> > > >>> > > --AG >>> > > >>> > > пн, 13 янв. 2020 г. в 21:37, Denis Magda <[hidden email]>: >>> > > >>> > > > Alex Goncharuk, Nikolay Izhikov, >>> > > > >>> > > > Could you possibly check the changes or suggest any other >>> > > > committer/contributor for that? >>> > > > >>> > > > - >>> > > > Denis >>> > > > >>> > > > >>> > > > On Sun, Jan 12, 2020 at 9:31 AM Saikat Maitra < >>> [hidden email] >>> > > >>> > > > wrote: >>> > > > >>> > > >> Hello, >>> > > >> >>> > > >> These PRs are part of Modularization effort >>> > > >> >>> > > >> >>> > > >>> > >>> https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations >>> > > >> >>> > > >> If the changes looks good, I can go ahead and merge the changes. >>> > > >> >>> > > >> Regards, >>> > > >> Saikat >>> > > >> >>> > > >> On Sun, Jan 5, 2020 at 1:08 PM Saikat Maitra < >>> [hidden email] >>> > > >>> > > >> wrote: >>> > > >> >>> > > >> > Hi, >>> > > >> > >>> > > >> > I have raised PR for Ignite Flume migration to Ignite Extensions >>> > repo. >>> > > >> > >>> > > >> > Jira https://issues.apache.org/jira/browse/IGNITE-12361 >>> > > >> > >>> > > >> > PR https://github.com/apache/ignite-extensions/pull/4 >>> > > >> > https://github.com/apache/ignite/pull/7227 >>> > > >> > >>> > > >> > Please review and share feedback. >>> > > >> > >>> > > >> > This is part of our Modularization effort for Streamer modules >>> > > >> > >>> > > >> > https://issues.apache.org/jira/browse/IGNITE-12355 >>> > > >> > >>> > > >> > Regards, >>> > > >> > Saikat >>> > > >> > >>> > > >> >>> > > > >>> > > >>> > >>> >> |
Saikat,
Yes, I think we can go ahead with the modules PRs as long as reviewers are ok with the changes. Given that there is an activity around the spring module, which modules do you think will get to the first release? сб, 1 февр. 2020 г. в 21:37, Saikat Maitra <[hidden email]>: > Hi Alexey, > > Please let me know if I can share more info on the release process. I have > updated the issue confluence page on discussed approach for Ignite > Extensions. Do you think the open PRs can be merged in Ignite Extensions > repo? > > Independent Integrations: > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations > Discussion Links: > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-DiscussionLinks > Tickets: > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-Tickets > > Regards, > Saikat > > On Sun, Jan 26, 2020 at 3:11 PM Saikat Maitra <[hidden email]> > wrote: > > > Hi Alexey, > > > > As discussed I have updated the wiki with agreed solution. > > > > Independent Integrations: > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations > > > > Discussion Links: > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-DiscussionLinks > > > > Tickets: > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-Tickets > > > > Please let me know if I can share more information. > > > > Regards, > > Saikat > > > > > > On Fri, Jan 17, 2020 at 9:16 PM Saikat Maitra <[hidden email]> > > wrote: > > > >> Hello Alexey, > >> > >> Thank you for your email. > >> > >> 1. Yes, we discussed in dev list and agreed on creating a new repository > >> for hosting our Ignite integrations. Please find the discussion thread > >> below. I will update the wiki page as well and share updates. > >> > >> > >> > http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSS-Proposal-for-Ignite-Extensions-as-a-separate-Bahir-module-or-Incubator-project-td44064.html > >> > >> 2. I was hoping to complete migration of the following modules before we > >> go ahead with release. I am tracking the jira story here > >> https://issues.apache.org/jira/browse/IGNITE-12355 > >> > >> - Flink > >> - Storm > >> - ZeroMQ > >> - RocketMQ > >> - Flume > >> - MQTT > >> - Camel > >> - JMS > >> > >> 3. The dependencies for modules are pointing to latest snapshot of > >> ignite project and if there are changes in ignite master branch then > >> related affected Ignite extensions module also need to be modified. We > will > >> verify all the extensions for upcoming release but release only the one > >> that are impacted. We will plan to avoid publishing any extension unless > >> there are changes. Here is the discussion thread on release process: > >> > >> > >> > http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSS-dependencies-and-release-process-for-Ignite-Extensions-td44478.html > >> > >> 4. Sounds good, we can maintain a compatibility matrix to ensure we can > >> share Ignite Core and related Ignite Extensions. I have seen something > >> similar in Apache Beam and we can also create a similar wiki page to > >> maintain Ignite Core and Ignite Extensions dependencies > >> > >> https://beam.apache.org/documentation/runners/capability-matrix/ > >> > >> Regards, > >> Saikat > >> > >> > >> > >> On Fri, Jan 17, 2020 at 6:27 AM Alexey Goncharuk < > >> [hidden email]> wrote: > >> > >>> Saikat, > >>> > >>> Code-wise the PR looks ok because it basically moves the module to > >>> another > >>> repo. I have some infrastructure/process questions though before we > merge > >>> the PRs > >>> * I see that there are some objections from Alexey Zinoviev [1] on > >>> whether > >>> the streaming modules should be placed in extensions or in a separate > >>> streaming project. Sorry if I missed the corresponding discussion on > the > >>> dev-list. If there is one, we need to edit the IEP page, if not, I > think > >>> we > >>> should come to a consensus before making this change > >>> * When are we planning to release the extensions? Are we going to > >>> release > >>> them one-by-one incrementally or do we want to release them in one > batch? > >>> * Now that the release lifecycle of Ignite and extensions is split, we > >>> need to understand how this is going to be tested. Will we run a > >>> candidate > >>> Ignite build against already released extensions? What if we make > changes > >>> to both Ignite and an extension? Is it even allowed, or do we need to > >>> wait > >>> for an Ignite release before making any changes in an extension? > >>> * I think there should be some sort of compatibility matrix now that > >>> releases of Ignite and extensions are separated > >>> > >>> I would not delete the extension from Ignite codebase until we agree on > >>> the > >>> points above. > >>> > >>> Would you mind taking care of the discussion about it and formalizing > it > >>> on > >>> the wiki? > >>> > >>> чт, 16 янв. 2020 г. в 06:27, Saikat Maitra <[hidden email]>: > >>> > >>> > Hi Denis, Alexey > >>> > > >>> > Thank you so much for your email. I really appreciate it. > >>> > > >>> > Regards, > >>> > Saikat > >>> > > >>> > On Wed, Jan 15, 2020 at 4:11 AM Alexey Goncharuk < > >>> > [hidden email]> > >>> > wrote: > >>> > > >>> > > Saikat, > >>> > > > >>> > > Thanks for working on this! I'll do my best to take a look at it > this > >>> > week. > >>> > > > >>> > > --AG > >>> > > > >>> > > пн, 13 янв. 2020 г. в 21:37, Denis Magda <[hidden email]>: > >>> > > > >>> > > > Alex Goncharuk, Nikolay Izhikov, > >>> > > > > >>> > > > Could you possibly check the changes or suggest any other > >>> > > > committer/contributor for that? > >>> > > > > >>> > > > - > >>> > > > Denis > >>> > > > > >>> > > > > >>> > > > On Sun, Jan 12, 2020 at 9:31 AM Saikat Maitra < > >>> [hidden email] > >>> > > > >>> > > > wrote: > >>> > > > > >>> > > >> Hello, > >>> > > >> > >>> > > >> These PRs are part of Modularization effort > >>> > > >> > >>> > > >> > >>> > > > >>> > > >>> > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations > >>> > > >> > >>> > > >> If the changes looks good, I can go ahead and merge the changes. > >>> > > >> > >>> > > >> Regards, > >>> > > >> Saikat > >>> > > >> > >>> > > >> On Sun, Jan 5, 2020 at 1:08 PM Saikat Maitra < > >>> [hidden email] > >>> > > > >>> > > >> wrote: > >>> > > >> > >>> > > >> > Hi, > >>> > > >> > > >>> > > >> > I have raised PR for Ignite Flume migration to Ignite > Extensions > >>> > repo. > >>> > > >> > > >>> > > >> > Jira https://issues.apache.org/jira/browse/IGNITE-12361 > >>> > > >> > > >>> > > >> > PR https://github.com/apache/ignite-extensions/pull/4 > >>> > > >> > https://github.com/apache/ignite/pull/7227 > >>> > > >> > > >>> > > >> > Please review and share feedback. > >>> > > >> > > >>> > > >> > This is part of our Modularization effort for Streamer modules > >>> > > >> > > >>> > > >> > https://issues.apache.org/jira/browse/IGNITE-12355 > >>> > > >> > > >>> > > >> > Regards, > >>> > > >> > Saikat > >>> > > >> > > >>> > > >> > >>> > > > > >>> > > > >>> > > >>> > >> > |
Hi Alexey,
I think we can release for spring boot autoconfigure module. Nikolay - Do you have tentative timeline when you are planning for release of spring boot autoconfigure module. After that we are planning to make release for flink ext. Since, each module are independent so they will be released independently. Regards, Saikat On Mon, 10 Feb 2020 at 7:33 AM, Alexey Goncharuk <[hidden email]> wrote: > Saikat, > > Yes, I think we can go ahead with the modules PRs as long as reviewers are > ok with the changes. Given that there is an activity around the spring > module, which modules do you think will get to the first release? > > сб, 1 февр. 2020 г. в 21:37, Saikat Maitra <[hidden email]>: > > > Hi Alexey, > > > > Please let me know if I can share more info on the release process. I > have > > updated the issue confluence page on discussed approach for Ignite > > Extensions. Do you think the open PRs can be merged in Ignite Extensions > > repo? > > > > Independent Integrations: > > > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations > > Discussion Links: > > > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-DiscussionLinks > > Tickets: > > > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-Tickets > > > > Regards, > > Saikat > > > > On Sun, Jan 26, 2020 at 3:11 PM Saikat Maitra <[hidden email]> > > wrote: > > > > > Hi Alexey, > > > > > > As discussed I have updated the wiki with agreed solution. > > > > > > Independent Integrations: > > > > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations > > > > > > Discussion Links: > > > > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-DiscussionLinks > > > > > > Tickets: > > > > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-Tickets > > > > > > Please let me know if I can share more information. > > > > > > Regards, > > > Saikat > > > > > > > > > On Fri, Jan 17, 2020 at 9:16 PM Saikat Maitra <[hidden email] > > > > > wrote: > > > > > >> Hello Alexey, > > >> > > >> Thank you for your email. > > >> > > >> 1. Yes, we discussed in dev list and agreed on creating a new > repository > > >> for hosting our Ignite integrations. Please find the discussion thread > > >> below. I will update the wiki page as well and share updates. > > >> > > >> > > >> > > > http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSS-Proposal-for-Ignite-Extensions-as-a-separate-Bahir-module-or-Incubator-project-td44064.html > > >> > > >> 2. I was hoping to complete migration of the following modules before > we > > >> go ahead with release. I am tracking the jira story here > > >> https://issues.apache.org/jira/browse/IGNITE-12355 > > >> > > >> - Flink > > >> - Storm > > >> - ZeroMQ > > >> - RocketMQ > > >> - Flume > > >> - MQTT > > >> - Camel > > >> - JMS > > >> > > >> 3. The dependencies for modules are pointing to latest snapshot of > > >> ignite project and if there are changes in ignite master branch then > > >> related affected Ignite extensions module also need to be modified. We > > will > > >> verify all the extensions for upcoming release but release only the > one > > >> that are impacted. We will plan to avoid publishing any extension > unless > > >> there are changes. Here is the discussion thread on release process: > > >> > > >> > > >> > > > http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSS-dependencies-and-release-process-for-Ignite-Extensions-td44478.html > > >> > > >> 4. Sounds good, we can maintain a compatibility matrix to ensure we > can > > >> share Ignite Core and related Ignite Extensions. I have seen something > > >> similar in Apache Beam and we can also create a similar wiki page to > > >> maintain Ignite Core and Ignite Extensions dependencies > > >> > > >> https://beam.apache.org/documentation/runners/capability-matrix/ > > >> > > >> Regards, > > >> Saikat > > >> > > >> > > >> > > >> On Fri, Jan 17, 2020 at 6:27 AM Alexey Goncharuk < > > >> [hidden email]> wrote: > > >> > > >>> Saikat, > > >>> > > >>> Code-wise the PR looks ok because it basically moves the module to > > >>> another > > >>> repo. I have some infrastructure/process questions though before we > > merge > > >>> the PRs > > >>> * I see that there are some objections from Alexey Zinoviev [1] on > > >>> whether > > >>> the streaming modules should be placed in extensions or in a separate > > >>> streaming project. Sorry if I missed the corresponding discussion on > > the > > >>> dev-list. If there is one, we need to edit the IEP page, if not, I > > think > > >>> we > > >>> should come to a consensus before making this change > > >>> * When are we planning to release the extensions? Are we going to > > >>> release > > >>> them one-by-one incrementally or do we want to release them in one > > batch? > > >>> * Now that the release lifecycle of Ignite and extensions is split, > we > > >>> need to understand how this is going to be tested. Will we run a > > >>> candidate > > >>> Ignite build against already released extensions? What if we make > > changes > > >>> to both Ignite and an extension? Is it even allowed, or do we need to > > >>> wait > > >>> for an Ignite release before making any changes in an extension? > > >>> * I think there should be some sort of compatibility matrix now that > > >>> releases of Ignite and extensions are separated > > >>> > > >>> I would not delete the extension from Ignite codebase until we agree > on > > >>> the > > >>> points above. > > >>> > > >>> Would you mind taking care of the discussion about it and formalizing > > it > > >>> on > > >>> the wiki? > > >>> > > >>> чт, 16 янв. 2020 г. в 06:27, Saikat Maitra <[hidden email] > >: > > >>> > > >>> > Hi Denis, Alexey > > >>> > > > >>> > Thank you so much for your email. I really appreciate it. > > >>> > > > >>> > Regards, > > >>> > Saikat > > >>> > > > >>> > On Wed, Jan 15, 2020 at 4:11 AM Alexey Goncharuk < > > >>> > [hidden email]> > > >>> > wrote: > > >>> > > > >>> > > Saikat, > > >>> > > > > >>> > > Thanks for working on this! I'll do my best to take a look at it > > this > > >>> > week. > > >>> > > > > >>> > > --AG > > >>> > > > > >>> > > пн, 13 янв. 2020 г. в 21:37, Denis Magda <[hidden email]>: > > >>> > > > > >>> > > > Alex Goncharuk, Nikolay Izhikov, > > >>> > > > > > >>> > > > Could you possibly check the changes or suggest any other > > >>> > > > committer/contributor for that? > > >>> > > > > > >>> > > > - > > >>> > > > Denis > > >>> > > > > > >>> > > > > > >>> > > > On Sun, Jan 12, 2020 at 9:31 AM Saikat Maitra < > > >>> [hidden email] > > >>> > > > > >>> > > > wrote: > > >>> > > > > > >>> > > >> Hello, > > >>> > > >> > > >>> > > >> These PRs are part of Modularization effort > > >>> > > >> > > >>> > > >> > > >>> > > > > >>> > > > >>> > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations > > >>> > > >> > > >>> > > >> If the changes looks good, I can go ahead and merge the > changes. > > >>> > > >> > > >>> > > >> Regards, > > >>> > > >> Saikat > > >>> > > >> > > >>> > > >> On Sun, Jan 5, 2020 at 1:08 PM Saikat Maitra < > > >>> [hidden email] > > >>> > > > > >>> > > >> wrote: > > >>> > > >> > > >>> > > >> > Hi, > > >>> > > >> > > > >>> > > >> > I have raised PR for Ignite Flume migration to Ignite > > Extensions > > >>> > repo. > > >>> > > >> > > > >>> > > >> > Jira https://issues.apache.org/jira/browse/IGNITE-12361 > > >>> > > >> > > > >>> > > >> > PR https://github.com/apache/ignite-extensions/pull/4 > > >>> > > >> > https://github.com/apache/ignite/pull/7227 > > >>> > > >> > > > >>> > > >> > Please review and share feedback. > > >>> > > >> > > > >>> > > >> > This is part of our Modularization effort for Streamer > modules > > >>> > > >> > > > >>> > > >> > https://issues.apache.org/jira/browse/IGNITE-12355 > > >>> > > >> > > > >>> > > >> > Regards, > > >>> > > >> > Saikat > > >>> > > >> > > > >>> > > >> > > >>> > > > > > >>> > > > > >>> > > > >>> > > >> > > > |
Hi,
Can someone please help in review for these following PRs. I have received approval for release process from Alexey and would need a code review approval for following PR. Jira https://issues.apache.org/jira/browse/IGNITE-12361 PR https://github.com/apache/ignite-extensions/pull/4 https://github.com/apache/ignite/pull/7227 Regards, Saikat On Tue, Feb 11, 2020 at 6:47 PM Saikat Maitra <[hidden email]> wrote: > Hi Alexey, > > > I think we can release for spring boot autoconfigure module. > > Nikolay - Do you have tentative timeline when you are planning for release > of spring boot autoconfigure module. > > > After that we are planning to make release for flink ext. > > > Since, each module are independent so they will be released independently. > > > Regards, > Saikat > > On Mon, 10 Feb 2020 at 7:33 AM, Alexey Goncharuk < > [hidden email]> wrote: > >> Saikat, >> >> Yes, I think we can go ahead with the modules PRs as long as reviewers are >> ok with the changes. Given that there is an activity around the spring >> module, which modules do you think will get to the first release? >> >> сб, 1 февр. 2020 г. в 21:37, Saikat Maitra <[hidden email]>: >> >> > Hi Alexey, >> > >> > Please let me know if I can share more info on the release process. I >> have >> > updated the issue confluence page on discussed approach for Ignite >> > Extensions. Do you think the open PRs can be merged in Ignite Extensions >> > repo? >> > >> > Independent Integrations: >> > >> > >> https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations >> > Discussion Links: >> > >> > >> https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-DiscussionLinks >> > Tickets: >> > >> > >> https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-Tickets >> > >> > Regards, >> > Saikat >> > >> > On Sun, Jan 26, 2020 at 3:11 PM Saikat Maitra <[hidden email]> >> > wrote: >> > >> > > Hi Alexey, >> > > >> > > As discussed I have updated the wiki with agreed solution. >> > > >> > > Independent Integrations: >> > > >> > >> https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations >> > > >> > > Discussion Links: >> > > >> > >> https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-DiscussionLinks >> > > >> > > Tickets: >> > > >> > >> https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-Tickets >> > > >> > > Please let me know if I can share more information. >> > > >> > > Regards, >> > > Saikat >> > > >> > > >> > > On Fri, Jan 17, 2020 at 9:16 PM Saikat Maitra < >> [hidden email]> >> > > wrote: >> > > >> > >> Hello Alexey, >> > >> >> > >> Thank you for your email. >> > >> >> > >> 1. Yes, we discussed in dev list and agreed on creating a new >> repository >> > >> for hosting our Ignite integrations. Please find the discussion >> thread >> > >> below. I will update the wiki page as well and share updates. >> > >> >> > >> >> > >> >> > >> http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSS-Proposal-for-Ignite-Extensions-as-a-separate-Bahir-module-or-Incubator-project-td44064.html >> > >> >> > >> 2. I was hoping to complete migration of the following modules >> before we >> > >> go ahead with release. I am tracking the jira story here >> > >> https://issues.apache.org/jira/browse/IGNITE-12355 >> > >> >> > >> - Flink >> > >> - Storm >> > >> - ZeroMQ >> > >> - RocketMQ >> > >> - Flume >> > >> - MQTT >> > >> - Camel >> > >> - JMS >> > >> >> > >> 3. The dependencies for modules are pointing to latest snapshot of >> > >> ignite project and if there are changes in ignite master branch then >> > >> related affected Ignite extensions module also need to be modified. >> We >> > will >> > >> verify all the extensions for upcoming release but release only the >> one >> > >> that are impacted. We will plan to avoid publishing any extension >> unless >> > >> there are changes. Here is the discussion thread on release process: >> > >> >> > >> >> > >> >> > >> http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSS-dependencies-and-release-process-for-Ignite-Extensions-td44478.html >> > >> >> > >> 4. Sounds good, we can maintain a compatibility matrix to ensure we >> can >> > >> share Ignite Core and related Ignite Extensions. I have seen >> something >> > >> similar in Apache Beam and we can also create a similar wiki page to >> > >> maintain Ignite Core and Ignite Extensions dependencies >> > >> >> > >> https://beam.apache.org/documentation/runners/capability-matrix/ >> > >> >> > >> Regards, >> > >> Saikat >> > >> >> > >> >> > >> >> > >> On Fri, Jan 17, 2020 at 6:27 AM Alexey Goncharuk < >> > >> [hidden email]> wrote: >> > >> >> > >>> Saikat, >> > >>> >> > >>> Code-wise the PR looks ok because it basically moves the module to >> > >>> another >> > >>> repo. I have some infrastructure/process questions though before we >> > merge >> > >>> the PRs >> > >>> * I see that there are some objections from Alexey Zinoviev [1] on >> > >>> whether >> > >>> the streaming modules should be placed in extensions or in a >> separate >> > >>> streaming project. Sorry if I missed the corresponding discussion on >> > the >> > >>> dev-list. If there is one, we need to edit the IEP page, if not, I >> > think >> > >>> we >> > >>> should come to a consensus before making this change >> > >>> * When are we planning to release the extensions? Are we going to >> > >>> release >> > >>> them one-by-one incrementally or do we want to release them in one >> > batch? >> > >>> * Now that the release lifecycle of Ignite and extensions is >> split, we >> > >>> need to understand how this is going to be tested. Will we run a >> > >>> candidate >> > >>> Ignite build against already released extensions? What if we make >> > changes >> > >>> to both Ignite and an extension? Is it even allowed, or do we need >> to >> > >>> wait >> > >>> for an Ignite release before making any changes in an extension? >> > >>> * I think there should be some sort of compatibility matrix now >> that >> > >>> releases of Ignite and extensions are separated >> > >>> >> > >>> I would not delete the extension from Ignite codebase until we >> agree on >> > >>> the >> > >>> points above. >> > >>> >> > >>> Would you mind taking care of the discussion about it and >> formalizing >> > it >> > >>> on >> > >>> the wiki? >> > >>> >> > >>> чт, 16 янв. 2020 г. в 06:27, Saikat Maitra <[hidden email] >> >: >> > >>> >> > >>> > Hi Denis, Alexey >> > >>> > >> > >>> > Thank you so much for your email. I really appreciate it. >> > >>> > >> > >>> > Regards, >> > >>> > Saikat >> > >>> > >> > >>> > On Wed, Jan 15, 2020 at 4:11 AM Alexey Goncharuk < >> > >>> > [hidden email]> >> > >>> > wrote: >> > >>> > >> > >>> > > Saikat, >> > >>> > > >> > >>> > > Thanks for working on this! I'll do my best to take a look at it >> > this >> > >>> > week. >> > >>> > > >> > >>> > > --AG >> > >>> > > >> > >>> > > пн, 13 янв. 2020 г. в 21:37, Denis Magda <[hidden email]>: >> > >>> > > >> > >>> > > > Alex Goncharuk, Nikolay Izhikov, >> > >>> > > > >> > >>> > > > Could you possibly check the changes or suggest any other >> > >>> > > > committer/contributor for that? >> > >>> > > > >> > >>> > > > - >> > >>> > > > Denis >> > >>> > > > >> > >>> > > > >> > >>> > > > On Sun, Jan 12, 2020 at 9:31 AM Saikat Maitra < >> > >>> [hidden email] >> > >>> > > >> > >>> > > > wrote: >> > >>> > > > >> > >>> > > >> Hello, >> > >>> > > >> >> > >>> > > >> These PRs are part of Modularization effort >> > >>> > > >> >> > >>> > > >> >> > >>> > > >> > >>> > >> > >>> >> > >> https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations >> > >>> > > >> >> > >>> > > >> If the changes looks good, I can go ahead and merge the >> changes. >> > >>> > > >> >> > >>> > > >> Regards, >> > >>> > > >> Saikat >> > >>> > > >> >> > >>> > > >> On Sun, Jan 5, 2020 at 1:08 PM Saikat Maitra < >> > >>> [hidden email] >> > >>> > > >> > >>> > > >> wrote: >> > >>> > > >> >> > >>> > > >> > Hi, >> > >>> > > >> > >> > >>> > > >> > I have raised PR for Ignite Flume migration to Ignite >> > Extensions >> > >>> > repo. >> > >>> > > >> > >> > >>> > > >> > Jira https://issues.apache.org/jira/browse/IGNITE-12361 >> > >>> > > >> > >> > >>> > > >> > PR https://github.com/apache/ignite-extensions/pull/4 >> > >>> > > >> > https://github.com/apache/ignite/pull/7227 >> > >>> > > >> > >> > >>> > > >> > Please review and share feedback. >> > >>> > > >> > >> > >>> > > >> > This is part of our Modularization effort for Streamer >> modules >> > >>> > > >> > >> > >>> > > >> > https://issues.apache.org/jira/browse/IGNITE-12355 >> > >>> > > >> > >> > >>> > > >> > Regards, >> > >>> > > >> > Saikat >> > >>> > > >> > >> > >>> > > >> >> > >>> > > > >> > >>> > > >> > >>> > >> > >>> >> > >> >> > >> > |
Hi Saikat,
I left a couple of comments in pr: https://github.com/apache/ignite-extensions/pull/4#pullrequestreview-357891629. Please tell me what do you think about it. Best Regards, Evgenii вт, 11 февр. 2020 г. в 17:15, Saikat Maitra <[hidden email]>: > Hi, > > Can someone please help in review for these following PRs. I have > received approval for release process from Alexey and would need a code > review approval for following PR. > > Jira https://issues.apache.org/jira/browse/IGNITE-12361 > > PR https://github.com/apache/ignite-extensions/pull/4 > https://github.com/apache/ignite/pull/7227 > > Regards, > Saikat > > On Tue, Feb 11, 2020 at 6:47 PM Saikat Maitra <[hidden email]> > wrote: > > > Hi Alexey, > > > > > > I think we can release for spring boot autoconfigure module. > > > > Nikolay - Do you have tentative timeline when you are planning for > release > > of spring boot autoconfigure module. > > > > > > After that we are planning to make release for flink ext. > > > > > > Since, each module are independent so they will be released > independently. > > > > > > Regards, > > Saikat > > > > On Mon, 10 Feb 2020 at 7:33 AM, Alexey Goncharuk < > > [hidden email]> wrote: > > > >> Saikat, > >> > >> Yes, I think we can go ahead with the modules PRs as long as reviewers > are > >> ok with the changes. Given that there is an activity around the spring > >> module, which modules do you think will get to the first release? > >> > >> сб, 1 февр. 2020 г. в 21:37, Saikat Maitra <[hidden email]>: > >> > >> > Hi Alexey, > >> > > >> > Please let me know if I can share more info on the release process. I > >> have > >> > updated the issue confluence page on discussed approach for Ignite > >> > Extensions. Do you think the open PRs can be merged in Ignite > Extensions > >> > repo? > >> > > >> > Independent Integrations: > >> > > >> > > >> > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations > >> > Discussion Links: > >> > > >> > > >> > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-DiscussionLinks > >> > Tickets: > >> > > >> > > >> > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-Tickets > >> > > >> > Regards, > >> > Saikat > >> > > >> > On Sun, Jan 26, 2020 at 3:11 PM Saikat Maitra < > [hidden email]> > >> > wrote: > >> > > >> > > Hi Alexey, > >> > > > >> > > As discussed I have updated the wiki with agreed solution. > >> > > > >> > > Independent Integrations: > >> > > > >> > > >> > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations > >> > > > >> > > Discussion Links: > >> > > > >> > > >> > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-DiscussionLinks > >> > > > >> > > Tickets: > >> > > > >> > > >> > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-Tickets > >> > > > >> > > Please let me know if I can share more information. > >> > > > >> > > Regards, > >> > > Saikat > >> > > > >> > > > >> > > On Fri, Jan 17, 2020 at 9:16 PM Saikat Maitra < > >> [hidden email]> > >> > > wrote: > >> > > > >> > >> Hello Alexey, > >> > >> > >> > >> Thank you for your email. > >> > >> > >> > >> 1. Yes, we discussed in dev list and agreed on creating a new > >> repository > >> > >> for hosting our Ignite integrations. Please find the discussion > >> thread > >> > >> below. I will update the wiki page as well and share updates. > >> > >> > >> > >> > >> > >> > >> > > >> > http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSS-Proposal-for-Ignite-Extensions-as-a-separate-Bahir-module-or-Incubator-project-td44064.html > >> > >> > >> > >> 2. I was hoping to complete migration of the following modules > >> before we > >> > >> go ahead with release. I am tracking the jira story here > >> > >> https://issues.apache.org/jira/browse/IGNITE-12355 > >> > >> > >> > >> - Flink > >> > >> - Storm > >> > >> - ZeroMQ > >> > >> - RocketMQ > >> > >> - Flume > >> > >> - MQTT > >> > >> - Camel > >> > >> - JMS > >> > >> > >> > >> 3. The dependencies for modules are pointing to latest snapshot of > >> > >> ignite project and if there are changes in ignite master branch > then > >> > >> related affected Ignite extensions module also need to be modified. > >> We > >> > will > >> > >> verify all the extensions for upcoming release but release only the > >> one > >> > >> that are impacted. We will plan to avoid publishing any extension > >> unless > >> > >> there are changes. Here is the discussion thread on release > process: > >> > >> > >> > >> > >> > >> > >> > > >> > http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSS-dependencies-and-release-process-for-Ignite-Extensions-td44478.html > >> > >> > >> > >> 4. Sounds good, we can maintain a compatibility matrix to ensure we > >> can > >> > >> share Ignite Core and related Ignite Extensions. I have seen > >> something > >> > >> similar in Apache Beam and we can also create a similar wiki page > to > >> > >> maintain Ignite Core and Ignite Extensions dependencies > >> > >> > >> > >> https://beam.apache.org/documentation/runners/capability-matrix/ > >> > >> > >> > >> Regards, > >> > >> Saikat > >> > >> > >> > >> > >> > >> > >> > >> On Fri, Jan 17, 2020 at 6:27 AM Alexey Goncharuk < > >> > >> [hidden email]> wrote: > >> > >> > >> > >>> Saikat, > >> > >>> > >> > >>> Code-wise the PR looks ok because it basically moves the module to > >> > >>> another > >> > >>> repo. I have some infrastructure/process questions though before > we > >> > merge > >> > >>> the PRs > >> > >>> * I see that there are some objections from Alexey Zinoviev [1] > on > >> > >>> whether > >> > >>> the streaming modules should be placed in extensions or in a > >> separate > >> > >>> streaming project. Sorry if I missed the corresponding discussion > on > >> > the > >> > >>> dev-list. If there is one, we need to edit the IEP page, if not, I > >> > think > >> > >>> we > >> > >>> should come to a consensus before making this change > >> > >>> * When are we planning to release the extensions? Are we going to > >> > >>> release > >> > >>> them one-by-one incrementally or do we want to release them in one > >> > batch? > >> > >>> * Now that the release lifecycle of Ignite and extensions is > >> split, we > >> > >>> need to understand how this is going to be tested. Will we run a > >> > >>> candidate > >> > >>> Ignite build against already released extensions? What if we make > >> > changes > >> > >>> to both Ignite and an extension? Is it even allowed, or do we need > >> to > >> > >>> wait > >> > >>> for an Ignite release before making any changes in an extension? > >> > >>> * I think there should be some sort of compatibility matrix now > >> that > >> > >>> releases of Ignite and extensions are separated > >> > >>> > >> > >>> I would not delete the extension from Ignite codebase until we > >> agree on > >> > >>> the > >> > >>> points above. > >> > >>> > >> > >>> Would you mind taking care of the discussion about it and > >> formalizing > >> > it > >> > >>> on > >> > >>> the wiki? > >> > >>> > >> > >>> чт, 16 янв. 2020 г. в 06:27, Saikat Maitra < > [hidden email] > >> >: > >> > >>> > >> > >>> > Hi Denis, Alexey > >> > >>> > > >> > >>> > Thank you so much for your email. I really appreciate it. > >> > >>> > > >> > >>> > Regards, > >> > >>> > Saikat > >> > >>> > > >> > >>> > On Wed, Jan 15, 2020 at 4:11 AM Alexey Goncharuk < > >> > >>> > [hidden email]> > >> > >>> > wrote: > >> > >>> > > >> > >>> > > Saikat, > >> > >>> > > > >> > >>> > > Thanks for working on this! I'll do my best to take a look at > it > >> > this > >> > >>> > week. > >> > >>> > > > >> > >>> > > --AG > >> > >>> > > > >> > >>> > > пн, 13 янв. 2020 г. в 21:37, Denis Magda <[hidden email]>: > >> > >>> > > > >> > >>> > > > Alex Goncharuk, Nikolay Izhikov, > >> > >>> > > > > >> > >>> > > > Could you possibly check the changes or suggest any other > >> > >>> > > > committer/contributor for that? > >> > >>> > > > > >> > >>> > > > - > >> > >>> > > > Denis > >> > >>> > > > > >> > >>> > > > > >> > >>> > > > On Sun, Jan 12, 2020 at 9:31 AM Saikat Maitra < > >> > >>> [hidden email] > >> > >>> > > > >> > >>> > > > wrote: > >> > >>> > > > > >> > >>> > > >> Hello, > >> > >>> > > >> > >> > >>> > > >> These PRs are part of Modularization effort > >> > >>> > > >> > >> > >>> > > >> > >> > >>> > > > >> > >>> > > >> > >>> > >> > > >> > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations > >> > >>> > > >> > >> > >>> > > >> If the changes looks good, I can go ahead and merge the > >> changes. > >> > >>> > > >> > >> > >>> > > >> Regards, > >> > >>> > > >> Saikat > >> > >>> > > >> > >> > >>> > > >> On Sun, Jan 5, 2020 at 1:08 PM Saikat Maitra < > >> > >>> [hidden email] > >> > >>> > > > >> > >>> > > >> wrote: > >> > >>> > > >> > >> > >>> > > >> > Hi, > >> > >>> > > >> > > >> > >>> > > >> > I have raised PR for Ignite Flume migration to Ignite > >> > Extensions > >> > >>> > repo. > >> > >>> > > >> > > >> > >>> > > >> > Jira https://issues.apache.org/jira/browse/IGNITE-12361 > >> > >>> > > >> > > >> > >>> > > >> > PR https://github.com/apache/ignite-extensions/pull/4 > >> > >>> > > >> > https://github.com/apache/ignite/pull/7227 > >> > >>> > > >> > > >> > >>> > > >> > Please review and share feedback. > >> > >>> > > >> > > >> > >>> > > >> > This is part of our Modularization effort for Streamer > >> modules > >> > >>> > > >> > > >> > >>> > > >> > https://issues.apache.org/jira/browse/IGNITE-12355 > >> > >>> > > >> > > >> > >>> > > >> > Regards, > >> > >>> > > >> > Saikat > >> > >>> > > >> > > >> > >>> > > >> > >> > >>> > > > > >> > >>> > > > >> > >>> > > >> > >>> > >> > >> > >> > > >> > > > |
Hi Evgenii,
I have responded to your questions and comments. Please take a look and share your thoughts. Regards, Saikat On Wed, Feb 12, 2020 at 7:04 PM Evgenii Zhuravlev <[hidden email]> wrote: > Hi Saikat, > > I left a couple of comments in pr: > > https://github.com/apache/ignite-extensions/pull/4#pullrequestreview-357891629 > . > Please tell me what do you think about it. > > Best Regards, > Evgenii > > вт, 11 февр. 2020 г. в 17:15, Saikat Maitra <[hidden email]>: > > > Hi, > > > > Can someone please help in review for these following PRs. I have > > received approval for release process from Alexey and would need a code > > review approval for following PR. > > > > Jira https://issues.apache.org/jira/browse/IGNITE-12361 > > > > PR https://github.com/apache/ignite-extensions/pull/4 > > https://github.com/apache/ignite/pull/7227 > > > > Regards, > > Saikat > > > > On Tue, Feb 11, 2020 at 6:47 PM Saikat Maitra <[hidden email]> > > wrote: > > > > > Hi Alexey, > > > > > > > > > I think we can release for spring boot autoconfigure module. > > > > > > Nikolay - Do you have tentative timeline when you are planning for > > release > > > of spring boot autoconfigure module. > > > > > > > > > After that we are planning to make release for flink ext. > > > > > > > > > Since, each module are independent so they will be released > > independently. > > > > > > > > > Regards, > > > Saikat > > > > > > On Mon, 10 Feb 2020 at 7:33 AM, Alexey Goncharuk < > > > [hidden email]> wrote: > > > > > >> Saikat, > > >> > > >> Yes, I think we can go ahead with the modules PRs as long as reviewers > > are > > >> ok with the changes. Given that there is an activity around the spring > > >> module, which modules do you think will get to the first release? > > >> > > >> сб, 1 февр. 2020 г. в 21:37, Saikat Maitra <[hidden email]>: > > >> > > >> > Hi Alexey, > > >> > > > >> > Please let me know if I can share more info on the release process. > I > > >> have > > >> > updated the issue confluence page on discussed approach for Ignite > > >> > Extensions. Do you think the open PRs can be merged in Ignite > > Extensions > > >> > repo? > > >> > > > >> > Independent Integrations: > > >> > > > >> > > > >> > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations > > >> > Discussion Links: > > >> > > > >> > > > >> > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-DiscussionLinks > > >> > Tickets: > > >> > > > >> > > > >> > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-Tickets > > >> > > > >> > Regards, > > >> > Saikat > > >> > > > >> > On Sun, Jan 26, 2020 at 3:11 PM Saikat Maitra < > > [hidden email]> > > >> > wrote: > > >> > > > >> > > Hi Alexey, > > >> > > > > >> > > As discussed I have updated the wiki with agreed solution. > > >> > > > > >> > > Independent Integrations: > > >> > > > > >> > > > >> > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations > > >> > > > > >> > > Discussion Links: > > >> > > > > >> > > > >> > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-DiscussionLinks > > >> > > > > >> > > Tickets: > > >> > > > > >> > > > >> > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-Tickets > > >> > > > > >> > > Please let me know if I can share more information. > > >> > > > > >> > > Regards, > > >> > > Saikat > > >> > > > > >> > > > > >> > > On Fri, Jan 17, 2020 at 9:16 PM Saikat Maitra < > > >> [hidden email]> > > >> > > wrote: > > >> > > > > >> > >> Hello Alexey, > > >> > >> > > >> > >> Thank you for your email. > > >> > >> > > >> > >> 1. Yes, we discussed in dev list and agreed on creating a new > > >> repository > > >> > >> for hosting our Ignite integrations. Please find the discussion > > >> thread > > >> > >> below. I will update the wiki page as well and share updates. > > >> > >> > > >> > >> > > >> > >> > > >> > > > >> > > > http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSS-Proposal-for-Ignite-Extensions-as-a-separate-Bahir-module-or-Incubator-project-td44064.html > > >> > >> > > >> > >> 2. I was hoping to complete migration of the following modules > > >> before we > > >> > >> go ahead with release. I am tracking the jira story here > > >> > >> https://issues.apache.org/jira/browse/IGNITE-12355 > > >> > >> > > >> > >> - Flink > > >> > >> - Storm > > >> > >> - ZeroMQ > > >> > >> - RocketMQ > > >> > >> - Flume > > >> > >> - MQTT > > >> > >> - Camel > > >> > >> - JMS > > >> > >> > > >> > >> 3. The dependencies for modules are pointing to latest snapshot > of > > >> > >> ignite project and if there are changes in ignite master branch > > then > > >> > >> related affected Ignite extensions module also need to be > modified. > > >> We > > >> > will > > >> > >> verify all the extensions for upcoming release but release only > the > > >> one > > >> > >> that are impacted. We will plan to avoid publishing any extension > > >> unless > > >> > >> there are changes. Here is the discussion thread on release > > process: > > >> > >> > > >> > >> > > >> > >> > > >> > > > >> > > > http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSS-dependencies-and-release-process-for-Ignite-Extensions-td44478.html > > >> > >> > > >> > >> 4. Sounds good, we can maintain a compatibility matrix to ensure > we > > >> can > > >> > >> share Ignite Core and related Ignite Extensions. I have seen > > >> something > > >> > >> similar in Apache Beam and we can also create a similar wiki page > > to > > >> > >> maintain Ignite Core and Ignite Extensions dependencies > > >> > >> > > >> > >> https://beam.apache.org/documentation/runners/capability-matrix/ > > >> > >> > > >> > >> Regards, > > >> > >> Saikat > > >> > >> > > >> > >> > > >> > >> > > >> > >> On Fri, Jan 17, 2020 at 6:27 AM Alexey Goncharuk < > > >> > >> [hidden email]> wrote: > > >> > >> > > >> > >>> Saikat, > > >> > >>> > > >> > >>> Code-wise the PR looks ok because it basically moves the module > to > > >> > >>> another > > >> > >>> repo. I have some infrastructure/process questions though before > > we > > >> > merge > > >> > >>> the PRs > > >> > >>> * I see that there are some objections from Alexey Zinoviev [1] > > on > > >> > >>> whether > > >> > >>> the streaming modules should be placed in extensions or in a > > >> separate > > >> > >>> streaming project. Sorry if I missed the corresponding > discussion > > on > > >> > the > > >> > >>> dev-list. If there is one, we need to edit the IEP page, if > not, I > > >> > think > > >> > >>> we > > >> > >>> should come to a consensus before making this change > > >> > >>> * When are we planning to release the extensions? Are we going > to > > >> > >>> release > > >> > >>> them one-by-one incrementally or do we want to release them in > one > > >> > batch? > > >> > >>> * Now that the release lifecycle of Ignite and extensions is > > >> split, we > > >> > >>> need to understand how this is going to be tested. Will we run a > > >> > >>> candidate > > >> > >>> Ignite build against already released extensions? What if we > make > > >> > changes > > >> > >>> to both Ignite and an extension? Is it even allowed, or do we > need > > >> to > > >> > >>> wait > > >> > >>> for an Ignite release before making any changes in an extension? > > >> > >>> * I think there should be some sort of compatibility matrix now > > >> that > > >> > >>> releases of Ignite and extensions are separated > > >> > >>> > > >> > >>> I would not delete the extension from Ignite codebase until we > > >> agree on > > >> > >>> the > > >> > >>> points above. > > >> > >>> > > >> > >>> Would you mind taking care of the discussion about it and > > >> formalizing > > >> > it > > >> > >>> on > > >> > >>> the wiki? > > >> > >>> > > >> > >>> чт, 16 янв. 2020 г. в 06:27, Saikat Maitra < > > [hidden email] > > >> >: > > >> > >>> > > >> > >>> > Hi Denis, Alexey > > >> > >>> > > > >> > >>> > Thank you so much for your email. I really appreciate it. > > >> > >>> > > > >> > >>> > Regards, > > >> > >>> > Saikat > > >> > >>> > > > >> > >>> > On Wed, Jan 15, 2020 at 4:11 AM Alexey Goncharuk < > > >> > >>> > [hidden email]> > > >> > >>> > wrote: > > >> > >>> > > > >> > >>> > > Saikat, > > >> > >>> > > > > >> > >>> > > Thanks for working on this! I'll do my best to take a look > at > > it > > >> > this > > >> > >>> > week. > > >> > >>> > > > > >> > >>> > > --AG > > >> > >>> > > > > >> > >>> > > пн, 13 янв. 2020 г. в 21:37, Denis Magda <[hidden email] > >: > > >> > >>> > > > > >> > >>> > > > Alex Goncharuk, Nikolay Izhikov, > > >> > >>> > > > > > >> > >>> > > > Could you possibly check the changes or suggest any other > > >> > >>> > > > committer/contributor for that? > > >> > >>> > > > > > >> > >>> > > > - > > >> > >>> > > > Denis > > >> > >>> > > > > > >> > >>> > > > > > >> > >>> > > > On Sun, Jan 12, 2020 at 9:31 AM Saikat Maitra < > > >> > >>> [hidden email] > > >> > >>> > > > > >> > >>> > > > wrote: > > >> > >>> > > > > > >> > >>> > > >> Hello, > > >> > >>> > > >> > > >> > >>> > > >> These PRs are part of Modularization effort > > >> > >>> > > >> > > >> > >>> > > >> > > >> > >>> > > > > >> > >>> > > > >> > >>> > > >> > > > >> > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations > > >> > >>> > > >> > > >> > >>> > > >> If the changes looks good, I can go ahead and merge the > > >> changes. > > >> > >>> > > >> > > >> > >>> > > >> Regards, > > >> > >>> > > >> Saikat > > >> > >>> > > >> > > >> > >>> > > >> On Sun, Jan 5, 2020 at 1:08 PM Saikat Maitra < > > >> > >>> [hidden email] > > >> > >>> > > > > >> > >>> > > >> wrote: > > >> > >>> > > >> > > >> > >>> > > >> > Hi, > > >> > >>> > > >> > > > >> > >>> > > >> > I have raised PR for Ignite Flume migration to Ignite > > >> > Extensions > > >> > >>> > repo. > > >> > >>> > > >> > > > >> > >>> > > >> > Jira > https://issues.apache.org/jira/browse/IGNITE-12361 > > >> > >>> > > >> > > > >> > >>> > > >> > PR https://github.com/apache/ignite-extensions/pull/4 > > >> > >>> > > >> > https://github.com/apache/ignite/pull/7227 > > >> > >>> > > >> > > > >> > >>> > > >> > Please review and share feedback. > > >> > >>> > > >> > > > >> > >>> > > >> > This is part of our Modularization effort for Streamer > > >> modules > > >> > >>> > > >> > > > >> > >>> > > >> > https://issues.apache.org/jira/browse/IGNITE-12355 > > >> > >>> > > >> > > > >> > >>> > > >> > Regards, > > >> > >>> > > >> > Saikat > > >> > >>> > > >> > > > >> > >>> > > >> > > >> > >>> > > > > > >> > >>> > > > > >> > >>> > > > >> > >>> > > >> > >> > > >> > > > >> > > > > > > |
Hi,
I have updated the PR as per review feedback. Please take a look and share your feedback. Regards, Saikat On Sat, Mar 7, 2020 at 2:08 PM Saikat Maitra <[hidden email]> wrote: > Hi Evgenii, > > I have responded to your questions and comments. > > Please take a look and share your thoughts. > > Regards, > Saikat > > > On Wed, Feb 12, 2020 at 7:04 PM Evgenii Zhuravlev < > [hidden email]> wrote: > >> Hi Saikat, >> >> I left a couple of comments in pr: >> >> https://github.com/apache/ignite-extensions/pull/4#pullrequestreview-357891629 >> . >> Please tell me what do you think about it. >> >> Best Regards, >> Evgenii >> >> вт, 11 февр. 2020 г. в 17:15, Saikat Maitra <[hidden email]>: >> >> > Hi, >> > >> > Can someone please help in review for these following PRs. I have >> > received approval for release process from Alexey and would need a code >> > review approval for following PR. >> > >> > Jira https://issues.apache.org/jira/browse/IGNITE-12361 >> > >> > PR https://github.com/apache/ignite-extensions/pull/4 >> > https://github.com/apache/ignite/pull/7227 >> > >> > Regards, >> > Saikat >> > >> > On Tue, Feb 11, 2020 at 6:47 PM Saikat Maitra <[hidden email]> >> > wrote: >> > >> > > Hi Alexey, >> > > >> > > >> > > I think we can release for spring boot autoconfigure module. >> > > >> > > Nikolay - Do you have tentative timeline when you are planning for >> > release >> > > of spring boot autoconfigure module. >> > > >> > > >> > > After that we are planning to make release for flink ext. >> > > >> > > >> > > Since, each module are independent so they will be released >> > independently. >> > > >> > > >> > > Regards, >> > > Saikat >> > > >> > > On Mon, 10 Feb 2020 at 7:33 AM, Alexey Goncharuk < >> > > [hidden email]> wrote: >> > > >> > >> Saikat, >> > >> >> > >> Yes, I think we can go ahead with the modules PRs as long as >> reviewers >> > are >> > >> ok with the changes. Given that there is an activity around the >> spring >> > >> module, which modules do you think will get to the first release? >> > >> >> > >> сб, 1 февр. 2020 г. в 21:37, Saikat Maitra <[hidden email] >> >: >> > >> >> > >> > Hi Alexey, >> > >> > >> > >> > Please let me know if I can share more info on the release >> process. I >> > >> have >> > >> > updated the issue confluence page on discussed approach for Ignite >> > >> > Extensions. Do you think the open PRs can be merged in Ignite >> > Extensions >> > >> > repo? >> > >> > >> > >> > Independent Integrations: >> > >> > >> > >> > >> > >> >> > >> https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations >> > >> > Discussion Links: >> > >> > >> > >> > >> > >> >> > >> https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-DiscussionLinks >> > >> > Tickets: >> > >> > >> > >> > >> > >> >> > >> https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-Tickets >> > >> > >> > >> > Regards, >> > >> > Saikat >> > >> > >> > >> > On Sun, Jan 26, 2020 at 3:11 PM Saikat Maitra < >> > [hidden email]> >> > >> > wrote: >> > >> > >> > >> > > Hi Alexey, >> > >> > > >> > >> > > As discussed I have updated the wiki with agreed solution. >> > >> > > >> > >> > > Independent Integrations: >> > >> > > >> > >> > >> > >> >> > >> https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations >> > >> > > >> > >> > > Discussion Links: >> > >> > > >> > >> > >> > >> >> > >> https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-DiscussionLinks >> > >> > > >> > >> > > Tickets: >> > >> > > >> > >> > >> > >> >> > >> https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-Tickets >> > >> > > >> > >> > > Please let me know if I can share more information. >> > >> > > >> > >> > > Regards, >> > >> > > Saikat >> > >> > > >> > >> > > >> > >> > > On Fri, Jan 17, 2020 at 9:16 PM Saikat Maitra < >> > >> [hidden email]> >> > >> > > wrote: >> > >> > > >> > >> > >> Hello Alexey, >> > >> > >> >> > >> > >> Thank you for your email. >> > >> > >> >> > >> > >> 1. Yes, we discussed in dev list and agreed on creating a new >> > >> repository >> > >> > >> for hosting our Ignite integrations. Please find the discussion >> > >> thread >> > >> > >> below. I will update the wiki page as well and share updates. >> > >> > >> >> > >> > >> >> > >> > >> >> > >> > >> > >> >> > >> http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSS-Proposal-for-Ignite-Extensions-as-a-separate-Bahir-module-or-Incubator-project-td44064.html >> > >> > >> >> > >> > >> 2. I was hoping to complete migration of the following modules >> > >> before we >> > >> > >> go ahead with release. I am tracking the jira story here >> > >> > >> https://issues.apache.org/jira/browse/IGNITE-12355 >> > >> > >> >> > >> > >> - Flink >> > >> > >> - Storm >> > >> > >> - ZeroMQ >> > >> > >> - RocketMQ >> > >> > >> - Flume >> > >> > >> - MQTT >> > >> > >> - Camel >> > >> > >> - JMS >> > >> > >> >> > >> > >> 3. The dependencies for modules are pointing to latest >> snapshot of >> > >> > >> ignite project and if there are changes in ignite master branch >> > then >> > >> > >> related affected Ignite extensions module also need to be >> modified. >> > >> We >> > >> > will >> > >> > >> verify all the extensions for upcoming release but release only >> the >> > >> one >> > >> > >> that are impacted. We will plan to avoid publishing any >> extension >> > >> unless >> > >> > >> there are changes. Here is the discussion thread on release >> > process: >> > >> > >> >> > >> > >> >> > >> > >> >> > >> > >> > >> >> > >> http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSS-dependencies-and-release-process-for-Ignite-Extensions-td44478.html >> > >> > >> >> > >> > >> 4. Sounds good, we can maintain a compatibility matrix to >> ensure we >> > >> can >> > >> > >> share Ignite Core and related Ignite Extensions. I have seen >> > >> something >> > >> > >> similar in Apache Beam and we can also create a similar wiki >> page >> > to >> > >> > >> maintain Ignite Core and Ignite Extensions dependencies >> > >> > >> >> > >> > >> >> https://beam.apache.org/documentation/runners/capability-matrix/ >> > >> > >> >> > >> > >> Regards, >> > >> > >> Saikat >> > >> > >> >> > >> > >> >> > >> > >> >> > >> > >> On Fri, Jan 17, 2020 at 6:27 AM Alexey Goncharuk < >> > >> > >> [hidden email]> wrote: >> > >> > >> >> > >> > >>> Saikat, >> > >> > >>> >> > >> > >>> Code-wise the PR looks ok because it basically moves the >> module to >> > >> > >>> another >> > >> > >>> repo. I have some infrastructure/process questions though >> before >> > we >> > >> > merge >> > >> > >>> the PRs >> > >> > >>> * I see that there are some objections from Alexey Zinoviev >> [1] >> > on >> > >> > >>> whether >> > >> > >>> the streaming modules should be placed in extensions or in a >> > >> separate >> > >> > >>> streaming project. Sorry if I missed the corresponding >> discussion >> > on >> > >> > the >> > >> > >>> dev-list. If there is one, we need to edit the IEP page, if >> not, I >> > >> > think >> > >> > >>> we >> > >> > >>> should come to a consensus before making this change >> > >> > >>> * When are we planning to release the extensions? Are we >> going to >> > >> > >>> release >> > >> > >>> them one-by-one incrementally or do we want to release them in >> one >> > >> > batch? >> > >> > >>> * Now that the release lifecycle of Ignite and extensions is >> > >> split, we >> > >> > >>> need to understand how this is going to be tested. Will we run >> a >> > >> > >>> candidate >> > >> > >>> Ignite build against already released extensions? What if we >> make >> > >> > changes >> > >> > >>> to both Ignite and an extension? Is it even allowed, or do we >> need >> > >> to >> > >> > >>> wait >> > >> > >>> for an Ignite release before making any changes in an >> extension? >> > >> > >>> * I think there should be some sort of compatibility matrix >> now >> > >> that >> > >> > >>> releases of Ignite and extensions are separated >> > >> > >>> >> > >> > >>> I would not delete the extension from Ignite codebase until we >> > >> agree on >> > >> > >>> the >> > >> > >>> points above. >> > >> > >>> >> > >> > >>> Would you mind taking care of the discussion about it and >> > >> formalizing >> > >> > it >> > >> > >>> on >> > >> > >>> the wiki? >> > >> > >>> >> > >> > >>> чт, 16 янв. 2020 г. в 06:27, Saikat Maitra < >> > [hidden email] >> > >> >: >> > >> > >>> >> > >> > >>> > Hi Denis, Alexey >> > >> > >>> > >> > >> > >>> > Thank you so much for your email. I really appreciate it. >> > >> > >>> > >> > >> > >>> > Regards, >> > >> > >>> > Saikat >> > >> > >>> > >> > >> > >>> > On Wed, Jan 15, 2020 at 4:11 AM Alexey Goncharuk < >> > >> > >>> > [hidden email]> >> > >> > >>> > wrote: >> > >> > >>> > >> > >> > >>> > > Saikat, >> > >> > >>> > > >> > >> > >>> > > Thanks for working on this! I'll do my best to take a look >> at >> > it >> > >> > this >> > >> > >>> > week. >> > >> > >>> > > >> > >> > >>> > > --AG >> > >> > >>> > > >> > >> > >>> > > пн, 13 янв. 2020 г. в 21:37, Denis Magda < >> [hidden email]>: >> > >> > >>> > > >> > >> > >>> > > > Alex Goncharuk, Nikolay Izhikov, >> > >> > >>> > > > >> > >> > >>> > > > Could you possibly check the changes or suggest any other >> > >> > >>> > > > committer/contributor for that? >> > >> > >>> > > > >> > >> > >>> > > > - >> > >> > >>> > > > Denis >> > >> > >>> > > > >> > >> > >>> > > > >> > >> > >>> > > > On Sun, Jan 12, 2020 at 9:31 AM Saikat Maitra < >> > >> > >>> [hidden email] >> > >> > >>> > > >> > >> > >>> > > > wrote: >> > >> > >>> > > > >> > >> > >>> > > >> Hello, >> > >> > >>> > > >> >> > >> > >>> > > >> These PRs are part of Modularization effort >> > >> > >>> > > >> >> > >> > >>> > > >> >> > >> > >>> > > >> > >> > >>> > >> > >> > >>> >> > >> > >> > >> >> > >> https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations >> > >> > >>> > > >> >> > >> > >>> > > >> If the changes looks good, I can go ahead and merge the >> > >> changes. >> > >> > >>> > > >> >> > >> > >>> > > >> Regards, >> > >> > >>> > > >> Saikat >> > >> > >>> > > >> >> > >> > >>> > > >> On Sun, Jan 5, 2020 at 1:08 PM Saikat Maitra < >> > >> > >>> [hidden email] >> > >> > >>> > > >> > >> > >>> > > >> wrote: >> > >> > >>> > > >> >> > >> > >>> > > >> > Hi, >> > >> > >>> > > >> > >> > >> > >>> > > >> > I have raised PR for Ignite Flume migration to Ignite >> > >> > Extensions >> > >> > >>> > repo. >> > >> > >>> > > >> > >> > >> > >>> > > >> > Jira >> https://issues.apache.org/jira/browse/IGNITE-12361 >> > >> > >>> > > >> > >> > >> > >>> > > >> > PR https://github.com/apache/ignite-extensions/pull/4 >> > >> > >>> > > >> > https://github.com/apache/ignite/pull/7227 >> > >> > >>> > > >> > >> > >> > >>> > > >> > Please review and share feedback. >> > >> > >>> > > >> > >> > >> > >>> > > >> > This is part of our Modularization effort for Streamer >> > >> modules >> > >> > >>> > > >> > >> > >> > >>> > > >> > https://issues.apache.org/jira/browse/IGNITE-12355 >> > >> > >>> > > >> > >> > >> > >>> > > >> > Regards, >> > >> > >>> > > >> > Saikat >> > >> > >>> > > >> > >> > >> > >>> > > >> >> > >> > >>> > > > >> > >> > >>> > > >> > >> > >>> > >> > >> > >>> >> > >> > >> >> > >> > >> > >> >> > > >> > >> > |
Free forum by Nabble | Edit this page |