IGNITE-12359 Migrate RocketMQ module to ignite-extensions

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

IGNITE-12359 Migrate RocketMQ module to ignite-extensions

Saikat Maitra
Hi,

I have raised PRs for the following issue:

IGNITE-12359 Migrate RocketMQ module to ignite-extensions

https://issues.apache.org/jira/browse/IGNITE-12359

PR
https://github.com/apache/ignite-extensions/pull/14
https://github.com/apache/ignite/pull/7809

Please take a look and share feedback.

Regards,
Saikat
Reply | Threaded
Open this post in threaded view
|

Re: IGNITE-12359 Migrate RocketMQ module to ignite-extensions

Saikat Maitra
Hi Ilya,

Thank you for reviewing the changes.

I have updated the PR.

Please review and share your feedback.

Regards,
Saikat

On Sat, May 16, 2020 at 7:30 PM Saikat Maitra <[hidden email]>
wrote:

> Hi,
>
> I have raised PRs for the following issue:
>
> IGNITE-12359 Migrate RocketMQ module to ignite-extensions
>
> https://issues.apache.org/jira/browse/IGNITE-12359
>
> PR
> https://github.com/apache/ignite-extensions/pull/14
> https://github.com/apache/ignite/pull/7809
>
> Please take a look and share feedback.
>
> Regards,
> Saikat
>
Reply | Threaded
Open this post in threaded view
|

Re: IGNITE-12359 Migrate RocketMQ module to ignite-extensions

Ilya Kasnacheev
Hello!

We still have a mention of it in assembly/libs/README.txt - I think we
should remove it alongside with some others. I'm not sure where this file
goes to.

Otherwise, LGTM.

Regards,
--
Ilya Kasnacheev


пн, 25 мая 2020 г. в 20:13, Saikat Maitra <[hidden email]>:

> Hi Ilya,
>
> Thank you for reviewing the changes.
>
> I have updated the PR.
>
> Please review and share your feedback.
>
> Regards,
> Saikat
>
> On Sat, May 16, 2020 at 7:30 PM Saikat Maitra <[hidden email]>
> wrote:
>
> > Hi,
> >
> > I have raised PRs for the following issue:
> >
> > IGNITE-12359 Migrate RocketMQ module to ignite-extensions
> >
> > https://issues.apache.org/jira/browse/IGNITE-12359
> >
> > PR
> > https://github.com/apache/ignite-extensions/pull/14
> > https://github.com/apache/ignite/pull/7809
> >
> > Please take a look and share feedback.
> >
> > Regards,
> > Saikat
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: IGNITE-12359 Migrate RocketMQ module to ignite-extensions

Saikat Maitra
Hi Ilya,

Thank you for reviewing the changes. I have updated the PR and merged the
changes.

Regards,
Saikat



On Tue, May 26, 2020 at 10:07 AM Ilya Kasnacheev <[hidden email]>
wrote:

> Hello!
>
> We still have a mention of it in assembly/libs/README.txt - I think we
> should remove it alongside with some others. I'm not sure where this file
> goes to.
>
> Otherwise, LGTM.
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> пн, 25 мая 2020 г. в 20:13, Saikat Maitra <[hidden email]>:
>
> > Hi Ilya,
> >
> > Thank you for reviewing the changes.
> >
> > I have updated the PR.
> >
> > Please review and share your feedback.
> >
> > Regards,
> > Saikat
> >
> > On Sat, May 16, 2020 at 7:30 PM Saikat Maitra <[hidden email]>
> > wrote:
> >
> > > Hi,
> > >
> > > I have raised PRs for the following issue:
> > >
> > > IGNITE-12359 Migrate RocketMQ module to ignite-extensions
> > >
> > > https://issues.apache.org/jira/browse/IGNITE-12359
> > >
> > > PR
> > > https://github.com/apache/ignite-extensions/pull/14
> > > https://github.com/apache/ignite/pull/7809
> > >
> > > Please take a look and share feedback.
> > >
> > > Regards,
> > > Saikat
> > >
> >
>