IGNITE-1084 and IGNITE-4760 are ready for review

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

IGNITE-1084 and IGNITE-4760 are ready for review

vadopolski
Hi Semyon!

I added AccessType parameter in 'threadLocalForCache'.
Merged HibernateL2CacheNonStrictReadWriteSelfTest and
HibernateL2CacheReadWriteSelfTest to HibernateL2CacheStrategySelfTest.
Merged fix for issue IGNITE-4760 and issue IGNITE-1084 and checked that
HibernateL2CacheSelfTest#testNaturalIdCache() did not fail after fix IGNITE-
4760.

Review please again.

https://github.com/apache/ignite/pull/1841

Vadim Opolski




2017-04-19 14:06 GMT+03:00 Semyon Boikov <[hidden email]>:

> Vadim,
>
> I found that real cause of IGNITE-1084 is IGNITE-4760, so suggested test
> fix in pull/1828 is not correct. I added new comments in IGNITE-4760,
> please take a look.
>
> Thanks,
> Semyon
>
> On Wed, Apr 19, 2017 at 12:17 PM, Вадим Опольский <[hidden email]>
> wrote:
>
>> Hello guys!
>>
>> The issue IGNITE-1084 https://issues.apache.org/jira/browse/IGNITE-1794 fixed
>> originally by Milap Wadhwa.
>>
>> I reassigned it on myself because she didn't make improvements from Anton
>> Vinogradov's comments. Also I just finished another issue with hibernate's
>> test.
>>
>> Review it please - https://github.com/apache/ignite/pull/1828
>>
>> Vadim Opolski
>>
>
>