How to begin to contribute

[Michael Fong]

Hi, all,

I happened to have a fix for IGNITE-7153 and created pull request for it. (
https://github.com/apache/ignite/pull/5044)

I tried to follow the How to Contribute Workflow
<https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-Workflow>
but
kind of got stuck on TeamCity CI, where all the test suite build failed at
unrelated library (ignite-tool). Is there any other easier or more
intuitive CI or documentation to guide through the testing process?

Furthermore, I wonder what would the code review process be, still via
github comment review?

Regards,

Michael

[Michael Fong]

Ah, never mind. I found out that I chose the wrong test suite to begin with
on Team City. :-)

On Sun, Oct 21, 2018 at 10:20 PM Michael Fong <[hidden email]> wrote:

> Hi, all,
>
> I happened to have a fix for IGNITE-7153 and created pull request for it. (
> https://github.com/apache/ignite/pull/5044)
>
> I tried to follow the How to Contribute Workflow
> <https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-Workflow> but
> kind of got stuck on TeamCity CI, where all the test suite build failed at
> unrelated library (ignite-tool). Is there any other easier or more
> intuitive CI or documentation to guide through the testing process?
>
> Furthermore, I wonder what would the code review process be, still via
> github comment review?
>
> Regards,
>
> Michael
>

[Dmitriy Pavlov]

Hi Michael,

I can see that https://issues.apache.org/jira/browse/IGNITE-7153 is already
assigned to Roman Shtykh and is In Progress status.

I hope Roman can step in and comment if he is interested in continuing of
developing this issue/or he could apply you PR as well.

Sincerely,
Dmitriy Pavlov

пн, 22 окт. 2018 г. в 11:33, Michael Fong <[hidden email]>:

> Ah, never mind. I found out that I chose the wrong test suite to begin with
> on Team City. :-)
>
> On Sun, Oct 21, 2018 at 10:20 PM Michael Fong <[hidden email]>
> wrote:
>
> > Hi, all,
> >
> > I happened to have a fix for IGNITE-7153 and created pull request for
> it. (
> > https://github.com/apache/ignite/pull/5044)
> >
> > I tried to follow the How to Contribute Workflow
> > <
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-Workflow>
> but
> > kind of got stuck on TeamCity CI, where all the test suite build failed
> at
> > unrelated library (ignite-tool). Is there any other easier or more
> > intuitive CI or documentation to guide through the testing process?
> >
> > Furthermore, I wonder what would the code review process be, still via
> > github comment review?
> >
> > Regards,
> >
> > Michael
> >
>

[Michael Fong]

Absolutely, I am glad to see this problem solved regardless whom the
assignee is. After all, we are suffering this Redis problem in our Ignite
PoC, and we are in urgency to solve this problem.
I would be glad to provide my solution for you guys to apply if you think
it is a good (enough) solution. :-)

Regards,

Michael

On Tue, Oct 30, 2018 at 7:53 PM Dmitriy Pavlov <[hidden email]>
wrote:

> Hi Michael,
>
> I can see that https://issues.apache.org/jira/browse/IGNITE-7153 is
> already
> assigned to Roman Shtykh and is In Progress status.
>
> I hope Roman can step in and comment if he is interested in continuing of
> developing this issue/or he could apply you PR as well.
>
> Sincerely,
> Dmitriy Pavlov
>
> пн, 22 окт. 2018 г. в 11:33, Michael Fong <[hidden email]>:
>
> > Ah, never mind. I found out that I chose the wrong test suite to begin
> with
> > on Team City. :-)
> >
> > On Sun, Oct 21, 2018 at 10:20 PM Michael Fong <[hidden email]>
> > wrote:
> >
> > > Hi, all,
> > >
> > > I happened to have a fix for IGNITE-7153 and created pull request for
> > it. (
> > > https://github.com/apache/ignite/pull/5044)
> > >
> > > I tried to follow the How to Contribute Workflow
> > > <
> >
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-Workflow
> >
> > but
> > > kind of got stuck on TeamCity CI, where all the test suite build failed
> > at
> > > unrelated library (ignite-tool). Is there any other easier or more
> > > intuitive CI or documentation to guide through the testing process?
> > >
> > > Furthermore, I wonder what would the code review process be, still via
> > > github comment review?
> > >
> > > Regards,
> > >
> > > Michael
> > >
> >
>

[Dmitry Pavlov]

Hi Michael,

I'm trying to reach you in https://issues.apache.org/jira/browse/IGNITE-7153
 mentions.

To proceed with patch according to
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-SubmittingforReview
we
need to set the ticket to Patch Available state. If you feel your patch is
ready, please set ticket status.

Sincerely,
Dmitriy Pavlov

ср, 31 окт. 2018 г. в 06:04, Michael Fong <[hidden email]>:

> Absolutely, I am glad to see this problem solved regardless whom the
> assignee is. After all, we are suffering this Redis problem in our Ignite
> PoC, and we are in urgency to solve this problem.
> I would be glad to provide my solution for you guys to apply if you think
> it is a good (enough) solution. :-)
>
> Regards,
>
> Michael
>
> On Tue, Oct 30, 2018 at 7:53 PM Dmitriy Pavlov <[hidden email]>
> wrote:
>
> > Hi Michael,
> >
> > I can see that https://issues.apache.org/jira/browse/IGNITE-7153 is
> > already
> > assigned to Roman Shtykh and is In Progress status.
> >
> > I hope Roman can step in and comment if he is interested in continuing of
> > developing this issue/or he could apply you PR as well.
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > пн, 22 окт. 2018 г. в 11:33, Michael Fong <[hidden email]>:
> >
> > > Ah, never mind. I found out that I chose the wrong test suite to begin
> > with
> > > on Team City. :-)
> > >
> > > On Sun, Oct 21, 2018 at 10:20 PM Michael Fong <[hidden email]>
> > > wrote:
> > >
> > > > Hi, all,
> > > >
> > > > I happened to have a fix for IGNITE-7153 and created pull request for
> > > it. (
> > > > https://github.com/apache/ignite/pull/5044)
> > > >
> > > > I tried to follow the How to Contribute Workflow
> > > > <
> > >
> >
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-Workflow
> > >
> > > but
> > > > kind of got stuck on TeamCity CI, where all the test suite build
> failed
> > > at
> > > > unrelated library (ignite-tool). Is there any other easier or more
> > > > intuitive CI or documentation to guide through the testing process?
> > > >
> > > > Furthermore, I wonder what would the code review process be, still
> via
> > > > github comment review?
> > > >
> > > > Regards,
> > > >
> > > > Michael
> > > >
> > >
> >
>