GridFunc.view

[Sergi]

Guys,

We have quite a few usages of *F.view* in the project. I believe this thing
is usually harmful for performance and correctness. Better thing would look
like:


*Collection filter(Collection src, CollectionFactory dstFactory,
IgnitePredicate p)*
For example it is used in *GridDiscoveryManager.nodes* method which is
called almost from everywhere.

I think we have to try dropping it and look at performance. If the impact
will be positive, then
it makes sense to look at other F.view* methods.

Sergi

[Vladimir Ozerov]

I created ticket for this several days ago:
https://issues.apache.org/jira/browse/IGNITE-2263

On Tue, Dec 29, 2015 at 5:05 PM, Sergi Vladykin <[hidden email]>
wrote:

> Guys,
>
> We have quite a few usages of *F.view* in the project. I believe this thing
> is usually harmful for performance and correctness. Better thing would look
> like:
>
>
> *Collection filter(Collection src, CollectionFactory dstFactory,
> IgnitePredicate p)*
> For example it is used in *GridDiscoveryManager.nodes* method which is
> called almost from everywhere.
>
> I think we have to try dropping it and look at performance. If the impact
> will be positive, then
> it makes sense to look at other F.view* methods.
>
> Sergi
>

[Sergi]

Cool :)

Sergi

2015-12-29 17:08 GMT+03:00 Vladimir Ozerov <[hidden email]>:

> I created ticket for this several days ago:
> https://issues.apache.org/jira/browse/IGNITE-2263
>
> On Tue, Dec 29, 2015 at 5:05 PM, Sergi Vladykin <[hidden email]>
> wrote:
>
> > Guys,
> >
> > We have quite a few usages of *F.view* in the project. I believe this
> thing
> > is usually harmful for performance and correctness. Better thing would
> look
> > like:
> >
> >
> > *Collection filter(Collection src, CollectionFactory dstFactory,
> > IgnitePredicate p)*
> > For example it is used in *GridDiscoveryManager.nodes* method which is
> > called almost from everywhere.
> >
> > I think we have to try dropping it and look at performance. If the impact
> > will be positive, then
> > it makes sense to look at other F.view* methods.
> >
> > Sergi
> >
>

[dsetrakyan]

I think this ticket should also describe examples of how to remove these
GridFunc methods. For example, what is an alternative code for
GridFunc.veiw(Collection) method?

D.

On Tue, Dec 29, 2015 at 6:12 AM, Sergi Vladykin <[hidden email]>
wrote:

> Cool :)
>
> Sergi
>
> 2015-12-29 17:08 GMT+03:00 Vladimir Ozerov <[hidden email]>:
>
> > I created ticket for this several days ago:
> > https://issues.apache.org/jira/browse/IGNITE-2263
> >
> > On Tue, Dec 29, 2015 at 5:05 PM, Sergi Vladykin <
> [hidden email]>
> > wrote:
> >
> > > Guys,
> > >
> > > We have quite a few usages of *F.view* in the project. I believe this
> > thing
> > > is usually harmful for performance and correctness. Better thing would
> > look
> > > like:
> > >
> > >
> > > *Collection filter(Collection src, CollectionFactory dstFactory,
> > > IgnitePredicate p)*
> > > For example it is used in *GridDiscoveryManager.nodes* method which is
> > > called almost from everywhere.
> > >
> > > I think we have to try dropping it and look at performance. If the
> impact
> > > will be positive, then
> > > it makes sense to look at other F.view* methods.
> > >
> > > Sergi
> > >
> >
>

[Sergi]

Responded in jira.

Sergi

2015-12-29 21:10 GMT+03:00 Dmitriy Setrakyan <[hidden email]>:

> I think this ticket should also describe examples of how to remove these
> GridFunc methods. For example, what is an alternative code for
> GridFunc.veiw(Collection) method?
>
> D.
>
> On Tue, Dec 29, 2015 at 6:12 AM, Sergi Vladykin <[hidden email]>
> wrote:
>
> > Cool :)
> >
> > Sergi
> >
> > 2015-12-29 17:08 GMT+03:00 Vladimir Ozerov <[hidden email]>:
> >
> > > I created ticket for this several days ago:
> > > https://issues.apache.org/jira/browse/IGNITE-2263
> > >
> > > On Tue, Dec 29, 2015 at 5:05 PM, Sergi Vladykin <
> > [hidden email]>
> > > wrote:
> > >
> > > > Guys,
> > > >
> > > > We have quite a few usages of *F.view* in the project. I believe this
> > > thing
> > > > is usually harmful for performance and correctness. Better thing
> would
> > > look
> > > > like:
> > > >
> > > >
> > > > *Collection filter(Collection src, CollectionFactory dstFactory,
> > > > IgnitePredicate p)*
> > > > For example it is used in *GridDiscoveryManager.nodes* method which
> is
> > > > called almost from everywhere.
> > > >
> > > > I think we have to try dropping it and look at performance. If the
> > impact
> > > > will be positive, then
> > > > it makes sense to look at other F.view* methods.
> > > >
> > > > Sergi
> > > >
> > >
> >
>