[GitHub] ignite-release pull request #1: IGNITE-8172

[andrey-kuznetsov]

GitHub user vveider opened a pull request:

    https://github.com/apache/ignite-release/pull/1

    IGNITE-8172

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vveider/ignite-release ignite-8172

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite-release/pull/1.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1
   
----
commit 31dc71092239cfa637eee151dde27c835f816ece
Author: Ivanov Petr <pivanov@...>
Date:   2018-04-09T08:10:03Z

    IGNITE-8172 Update Apache Ignite's release scripts to match new RPM build and deploy architecture
     * updated RPM packages build procedure: they now honor split RPM architecture
     * updated release procedure: RPM packages are now deployed to Bintray
     * updated corresponding comments and result messages
     * overall minimal refactoring of affected code

commit bf101cf52e2fe0a9a85bb927d770be630692c4f1
Author: Ivanov Petr <pivanov@...>
Date:   2018-04-09T15:33:22Z

    IGNITE-8172 Update Apache Ignite's release scripts to match new RPM build and deploy architecture
     * added Bintray authentication process
     * improved progress output
     * fixed minor defects and typos

----


---

[andrey-kuznetsov]

Github user alamar commented on a diff in the pull request:

    https://github.com/apache/ignite-release/pull/1#discussion_r180746462
 
    --- Diff: scripts/vote_3_step_1[rpm]create_repository.sh ---
    @@ -19,17 +27,19 @@ then
     fi
     echo
     
    +
     #
     # Build package
     #
     echo "# Building RPM package #"
    -if [ ! -f rpmbuild ]; then rm -rf rpmbuild; fi
    -mkdir -pv rpmbuild/{BUILD,RPMS,SOURCES,SPECS,SRPMS}
    +if [ -d rpmbuild ]; then rm -r rpmbuild; fi
    +mkdir -pv rpmbuild/{BUILD,RPMS,SRPMS}
     cp -rfv git/packaging/rpm/* rpmbuild
    -cp -rfv svn/vote/apache-ignite-fabric-${ignite_version}-bin.zip rpmbuild/SOURCES/apache-ignite.zip
    +cp -rfv svn/vote/apache-ignite-fabric-${ignite_version}-bin.zip rpmbuild/SOURCES/
     rpmbuild -bb --define "_topdir $(pwd)/rpmbuild" rpmbuild/SPECS/apache-ignite.spec
    --- End diff --
   
    I thought we don't want to be a 'fabric' anymore.


---

[andrey-kuznetsov]

Github user vveider commented on a diff in the pull request:

    https://github.com/apache/ignite-release/pull/1#discussion_r180753764
 
    --- Diff: scripts/vote_3_step_1[rpm]create_repository.sh ---
    @@ -19,17 +27,19 @@ then
     fi
     echo
     
    +
     #
     # Build package
     #
     echo "# Building RPM package #"
    -if [ ! -f rpmbuild ]; then rm -rf rpmbuild; fi
    -mkdir -pv rpmbuild/{BUILD,RPMS,SOURCES,SPECS,SRPMS}
    +if [ -d rpmbuild ]; then rm -r rpmbuild; fi
    +mkdir -pv rpmbuild/{BUILD,RPMS,SRPMS}
     cp -rfv git/packaging/rpm/* rpmbuild
    -cp -rfv svn/vote/apache-ignite-fabric-${ignite_version}-bin.zip rpmbuild/SOURCES/apache-ignite.zip
    +cp -rfv svn/vote/apache-ignite-fabric-${ignite_version}-bin.zip rpmbuild/SOURCES/
     rpmbuild -bb --define "_topdir $(pwd)/rpmbuild" rpmbuild/SPECS/apache-ignite.spec
    --- End diff --
   
    Not until https://issues.apache.org/jira/browse/IGNITE-7251 is reviewed and merged to master.


---