[GitHub] ignite pull request #2804: IGNITE-6362: NPE in Log4J2Logger

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] ignite pull request #2804: IGNITE-6362: NPE in Log4J2Logger

andrey-kuznetsov
GitHub user apopovgg opened a pull request:

    https://github.com/apache/ignite/pull/2804

    IGNITE-6362: NPE in Log4J2Logger

    1. There was an issue inside Log4J2Logger.createConsoleLogger(). null was passed instead of LoggerContext during ad-hoc logger creation via LoggerConfig.createLogger()
    2. There were issues with unit tests:
    Log4J2Logger holds context (static) for all logger instances and it is not expected to re-configure it on the fly. That was the issue to run tests one-by-one with different log configuration. A new method Log4J2Logger.cleanup() was implemented to terminate the Log4J logger context.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-6362

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/2804.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2804
   
----
commit 7f3fed9f83b252a6d723f9e76ea4d9a9221629ed
Author: apopov <[hidden email]>
Date:   2017-10-05T07:19:46Z

    IGNITE-6362: NPE in Log4J2Logger

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] ignite pull request #2804: IGNITE-6362: NPE in Log4J2Logger

andrey-kuznetsov
Github user apopovgg closed the pull request at:

    https://github.com/apache/ignite/pull/2804


---