[GitHub] dspavlov commented on a change in pull request #95: IGNITE-9542: new run history stripe

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] dspavlov commented on a change in pull request #95: IGNITE-9542: new run history stripe

GitBox
dspavlov commented on a change in pull request #95: IGNITE-9542: new run history stripe
URL: https://github.com/apache/ignite-teamcity-bot/pull/95#discussion_r240287246
 
 

 ##########
 File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/issue/IssueDetector.java
 ##########
 @@ -446,9 +463,9 @@ protected String checkFailuresEx(String brachName) {
                         backgroundOpsCreds
                 );
 
-        registerIssuesAndNotifyLater(failures, backgroundOpsCreds);
+        String issResult = registerIssuesAndNotifyLater(failures, backgroundOpsCreds);
 
 Review comment:
   Yes, I agree, but this string will go to the monitoring, so it is better to see null showing there is some unexpected behavior there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services