[GitHub] dspavlov commented on a change in pull request #89: IGNITE-10454 Create page with muted tests

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] dspavlov commented on a change in pull request #89: IGNITE-10454 Create page with muted tests

GitBox
dspavlov commented on a change in pull request #89: IGNITE-10454 Create page with muted tests
URL: https://github.com/apache/ignite-teamcity-bot/pull/89#discussion_r239799469
 
 

 ##########
 File path: ignite-tc-helper-web/src/test/java/org/apache/ignite/ci/di/scheduler/DirectExecNoWaitScheduler.java
 ##########
 @@ -21,7 +21,7 @@
 /**
  * Sheduler which never waits
  */
-public class DirectExecNoWaitSheduler implements IScheduler {
+public class DirectExecNoWaitScheduler implements IScheduler {
 
 Review comment:
   Always feel free to create a separate small PRs for such changes (srvNme, misprints, etc). It is easier to accept such small changes without relation to a big feature. Big feature change can be rejected, but small and needed changes will wait. With a separate PRs is it easy to accept separately A)refactoring/improving/misprints corrections and B) big feature.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services