[GitHub] dspavlov commented on a change in pull request #57: IGNITE-9849 Refactor Master trends

[GitBox]

dspavlov commented on a change in pull request #57: IGNITE-9849 Refactor Master trends
URL: https://github.com/apache/ignite-teamcity-bot/pull/57#discussion_r229880842
 
 

 ##########
 File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/hist/BuildsHistory.java
 ##########
 @@ -92,25 +91,26 @@
 
     /** */
     public void initialize(ICredentialsProv prov, ServletContext context) {
-        if (!prov.hasAccess(srvId))
-            throw ServiceUnauthorizedException.noCreds(srvId);
+        final IStringCompactor compactor = CtxListener.getInjector(context).getInstance(IStringCompactor.class);
 
         ITcHelper tcHelper = CtxListener.getTcHelper(context);
 
-        IAnalyticsEnabledTeamcity teamcity = tcHelper.server(srvId, prov);
+        ITeamcity teamcity = tcHelper.server(srvId, prov);
 
         ITeamcityIgnitedProvider tcIgnitedProv = CtxListener.getInjector(context)
             .getInstance(ITeamcityIgnitedProvider.class);
 
-        ITeamcityIgnited ignited = tcIgnitedProv.server(srvId, prov);
+        ITeamcityIgnited ignitedTeamcity = tcIgnitedProv.server(srvId, prov);
 
-        int[] finishedBuildsIds = teamcity.getBuildNumbersFromHistory(buildTypeId, branchName,
-            sinceDateFilter, untilDateFilter);
+        List<Integer> finishedBuildsIds = ignitedTeamcity
+            .getFinishedBuildsCompacted(buildTypeId, branchName, sinceDateFilter, untilDateFilter)
 
 Review comment:
   Probably we need filter out canceled builds here. New method may return finished build, but having status Unknown. It may mean build was canceled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services