[GitHub] dspavlov commented on a change in pull request #1: MTCGA-002 Build trigger timeout.

[GitBox]

dspavlov commented on a change in pull request #1: MTCGA-002 Build trigger timeout.
URL: https://github.com/apache/ignite-teamcity-bot/pull/1#discussion_r210347861
 
 

 ##########
 File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/conf/ChainAtServer.java
 ##########
 @@ -17,46 +17,62 @@
 
 package org.apache.ignite.ci.conf;
 
+import java.util.Objects;
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 
 /**
  * Created by Дмитрий on 09.11.2017.
  */
 public class ChainAtServer {
-    /** Server ID to access config files within helper */
+    /** Server ID to access config files within helper. */
     @Nullable public String serverId;
 
-    /** Suite identifier by teamcity identification for root chain */
+    /** Suite identifier by teamcity identification for root chain. */
     @Nonnull public String suiteId;
 
     /** Automatic build triggering. */
     @Nullable private Boolean triggerBuild;
 
+    /** Automatic build triggering timeout in minutes. */
+    @Nullable private Integer triggerBuildTimeout;
+
+    /** {@inheritDoc} */
     @Override public boolean equals(Object o) {
         if (this == o)
             return true;
         if (o == null || getClass() != o.getClass())
             return false;
-
         ChainAtServer server = (ChainAtServer)o;
-
-        if (serverId != null ? !serverId.equals(server.serverId) : server.serverId != null)
-            return false;
-        return suiteId.equals(server.suiteId);
+        return Objects.equals(serverId, server.serverId) &&
+            Objects.equals(suiteId, server.suiteId) &&
+            Objects.equals(triggerBuild, server.triggerBuild) &&
+            Objects.equals(triggerBuildTimeout, server.triggerBuildTimeout);
     }
 
+    /** {@inheritDoc} */
     @Override public int hashCode() {
-        int result = serverId != null ? serverId.hashCode() : 0;
-        result = 31 * result + suiteId.hashCode();
-        return result;
+        return Objects.hash(serverId, suiteId, triggerBuild, triggerBuildTimeout);
     }
 
+    /**
+     * @return Server ID to access config files within helper.
+     */
     @Nullable public String getServerId() {
         return serverId;
     }
 
+    /**
+     * @return {@code True} If automatic build triggering enabled.
+     */
     @Nonnull public boolean isTriggerBuild() {
         return triggerBuild == null ? false : triggerBuild;
     }
+
+    /**
+     * @return Timeout in minutes between triggering builds or zero if timeout is not set and should be ignored.
+     */
+    @Nonnull public int getTriggerBuildTimeout() {
 
 Review comment:
   I suggest naming this property as the quiet period or something like that. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[Dmitriy Pavlov]

Hi Igniters,

do you know how to disable PR comments to be forwarded to dev.list? I think
notification about PR creation is OK to be forwarded.

But I'm not sure we need each comment to be forwarded to dev.list. WDYT?

Sincerely,
Dmitriy Pavlov

ср, 15 авг. 2018 г. в 20:39, GitBox <[hidden email]>:

> dspavlov commented on a change in pull request #1: MTCGA-002 Build trigger
> timeout.
> URL:
> https://github.com/apache/ignite-teamcity-bot/pull/1#discussion_r210347861
>
>
>
>  ##########
>  File path:
> ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/conf/ChainAtServer.java
>  ##########
>  @@ -17,46 +17,62 @@
>
>  package org.apache.ignite.ci.conf;
>
> +import java.util.Objects;
>  import javax.annotation.Nonnull;
>  import javax.annotation.Nullable;
>
>  /**
>   * Created by Дмитрий on 09.11.2017.
>   */
>  public class ChainAtServer {
> -    /** Server ID to access config files within helper */
> +    /** Server ID to access config files within helper. */
>      @Nullable public String serverId;
>
> -    /** Suite identifier by teamcity identification for root chain */
> +    /** Suite identifier by teamcity identification for root chain. */
>      @Nonnull public String suiteId;
>
>      /** Automatic build triggering. */
>      @Nullable private Boolean triggerBuild;
>
> +    /** Automatic build triggering timeout in minutes. */
> +    @Nullable private Integer triggerBuildTimeout;
> +
> +    /** {@inheritDoc} */
>      @Override public boolean equals(Object o) {
>          if (this == o)
>              return true;
>          if (o == null || getClass() != o.getClass())
>              return false;
> -
>          ChainAtServer server = (ChainAtServer)o;
> -
> -        if (serverId != null ? !serverId.equals(server.serverId) :
> server.serverId != null)
> -            return false;
> -        return suiteId.equals(server.suiteId);
> +        return Objects.equals(serverId, server.serverId) &&
> +            Objects.equals(suiteId, server.suiteId) &&
> +            Objects.equals(triggerBuild, server.triggerBuild) &&
> +            Objects.equals(triggerBuildTimeout,
> server.triggerBuildTimeout);
>      }
>
> +    /** {@inheritDoc} */
>      @Override public int hashCode() {
> -        int result = serverId != null ? serverId.hashCode() : 0;
> -        result = 31 * result + suiteId.hashCode();
> -        return result;
> +        return Objects.hash(serverId, suiteId, triggerBuild,
> triggerBuildTimeout);
>      }
>
> +    /**
> +     * @return Server ID to access config files within helper.
> +     */
>      @Nullable public String getServerId() {
>          return serverId;
>      }
>
> +    /**
> +     * @return {@code True} If automatic build triggering enabled.
> +     */
>      @Nonnull public boolean isTriggerBuild() {
>          return triggerBuild == null ? false : triggerBuild;
>      }
> +
> +    /**
> +     * @return Timeout in minutes between triggering builds or zero if
> timeout is not set and should be ignored.
> +     */
> +    @Nonnull public int getTriggerBuildTimeout() {
>
>  Review comment:
>    I suggest naming this property as the quiet period or something like
> that. WDYT?
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> [hidden email]
>
>
> With regards,
> Apache Git Services
>

[dsetrakyan]

Agree, we should disable the comments.

On Wed, Aug 15, 2018 at 10:46 AM, Dmitriy Pavlov <[hidden email]>
wrote:

> Hi Igniters,
>
> do you know how to disable PR comments to be forwarded to dev.list? I think
> notification about PR creation is OK to be forwarded.
>
> But I'm not sure we need each comment to be forwarded to dev.list. WDYT?
>
> Sincerely,
> Dmitriy Pavlov
>
> ср, 15 авг. 2018 г. в 20:39, GitBox <[hidden email]>:
>
> > dspavlov commented on a change in pull request #1: MTCGA-002 Build
> trigger
> > timeout.
> > URL:
> > https://github.com/apache/ignite-teamcity-bot/pull/1#
> discussion_r210347861
> >
> >
> >
> >  ##########
> >  File path:
> > ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/
> conf/ChainAtServer.java
> >  ##########
> >  @@ -17,46 +17,62 @@
> >
> >  package org.apache.ignite.ci.conf;
> >
> > +import java.util.Objects;
> >  import javax.annotation.Nonnull;
> >  import javax.annotation.Nullable;
> >
> >  /**
> >   * Created by Дмитрий on 09.11.2017.
> >   */
> >  public class ChainAtServer {
> > -    /** Server ID to access config files within helper */
> > +    /** Server ID to access config files within helper. */
> >      @Nullable public String serverId;
> >
> > -    /** Suite identifier by teamcity identification for root chain */
> > +    /** Suite identifier by teamcity identification for root chain. */
> >      @Nonnull public String suiteId;
> >
> >      /** Automatic build triggering. */
> >      @Nullable private Boolean triggerBuild;
> >
> > +    /** Automatic build triggering timeout in minutes. */
> > +    @Nullable private Integer triggerBuildTimeout;
> > +
> > +    /** {@inheritDoc} */
> >      @Override public boolean equals(Object o) {
> >          if (this == o)
> >              return true;
> >          if (o == null || getClass() != o.getClass())
> >              return false;
> > -
> >          ChainAtServer server = (ChainAtServer)o;
> > -
> > -        if (serverId != null ? !serverId.equals(server.serverId) :
> > server.serverId != null)
> > -            return false;
> > -        return suiteId.equals(server.suiteId);
> > +        return Objects.equals(serverId, server.serverId) &&
> > +            Objects.equals(suiteId, server.suiteId) &&
> > +            Objects.equals(triggerBuild, server.triggerBuild) &&
> > +            Objects.equals(triggerBuildTimeout,
> > server.triggerBuildTimeout);
> >      }
> >
> > +    /** {@inheritDoc} */
> >      @Override public int hashCode() {
> > -        int result = serverId != null ? serverId.hashCode() : 0;
> > -        result = 31 * result + suiteId.hashCode();
> > -        return result;
> > +        return Objects.hash(serverId, suiteId, triggerBuild,
> > triggerBuildTimeout);
> >      }
> >
> > +    /**
> > +     * @return Server ID to access config files within helper.
> > +     */
> >      @Nullable public String getServerId() {
> >          return serverId;
> >      }
> >
> > +    /**
> > +     * @return {@code True} If automatic build triggering enabled.
> > +     */
> >      @Nonnull public boolean isTriggerBuild() {
> >          return triggerBuild == null ? false : triggerBuild;
> >      }
> > +
> > +    /**
> > +     * @return Timeout in minutes between triggering builds or zero if
> > timeout is not set and should be ignored.
> > +     */
> > +    @Nonnull public int getTriggerBuildTimeout() {
> >
> >  Review comment:
> >    I suggest naming this property as the quiet period or something like
> > that. WDYT?
> >
> > ----------------------------------------------------------------
> > This is an automated message from the Apache Git Service.
> > To respond to the message, please log on GitHub and use the
> > URL above to go to the specific comment.
> >
> > For queries about this service, please contact Infrastructure at:
> > [hidden email]
> >
> >
> > With regards,
> > Apache Git Services
> >
>