[GitHub] asfgit closed pull request #70: IGNITE-10215 Suite critical failures registration added

[GitBox]

asfgit closed pull request #70: IGNITE-10215 Suite critical failures registration added
URL: https://github.com/apache/ignite-teamcity-bot/pull/70
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java
index e970c973..e9befbe5 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java
@@ -1116,6 +1116,16 @@ public ProblemOccurrences getProblems(int buildId) {
         return teamcity.getProblems(buildId);
     }
 
+    /** {@inheritDoc} */
+    @Deprecated
+    @Override public ProblemOccurrences getProblemsAndRegisterCtiticals(BuildRef build) {
+        ProblemOccurrences problems = teamcity.getProblems(build.getId());
+
+        registerCriticalBuildProblemInStat(build, problems);
+
+        return problems;
+    }
+
     @Override
     public Statistics getStatistics(int buildId) {
         return teamcity.getStatistics(buildId);
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgniteTeamcityConnection.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgniteTeamcityConnection.java
index 5f044c06..71776546 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgniteTeamcityConnection.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgniteTeamcityConnection.java
@@ -317,6 +317,13 @@ public void init(@Nullable String tcName) {
         }
     }
 
+    /** {@inheritDoc} */
+    @Deprecated
+    @AutoProfiling
+    @Override public ProblemOccurrences getProblemsAndRegisterCtiticals(BuildRef build) {
+        return getProblems(build.getId());
+    }
+
     @Override
     @AutoProfiling
     public ProblemOccurrences getProblems(int buildId) {
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/fatbuild/ProactiveFatBuildSync.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/fatbuild/ProactiveFatBuildSync.java
index dd111dd4..3eab4372 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/fatbuild/ProactiveFatBuildSync.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/fatbuild/ProactiveFatBuildSync.java
@@ -287,7 +287,7 @@ public FatBuildCompacted reloadBuild(ITeamcityConn conn, int buildId, @Nullable
             }
 
             if (build.problemOccurrences != null)
-                problems = conn.getProblems(buildId).getProblemsNonNull();
+                problems = conn.getProblemsAndRegisterCtiticals(build).getProblemsNonNull();
 
             if (build.statisticsRef != null)
                 statistics = conn.getStatistics(buildId);
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/pure/ITeamcityConn.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/pure/ITeamcityConn.java
index 52ae38bf..27dda7ee 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/pure/ITeamcityConn.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/pure/ITeamcityConn.java
@@ -72,4 +72,8 @@
     ChangesList getChangesList(int buildId);
 
     Change getChange(int changeId);
+
+    /** */
+    @Deprecated
+    ProblemOccurrences getProblemsAndRegisterCtiticals(BuildRef build);
 }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services