[GitHub] asfgit closed pull request #67: IGNITE-10215 Inspections:Core failures marked as critical

[GitBox]

asfgit closed pull request #67: IGNITE-10215 Inspections:Core failures marked as critical
URL: https://github.com/apache/ignite-teamcity-bot/pull/67
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java
index 4d0db6e0..e970c973 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java
@@ -780,7 +780,7 @@ private Build realLoadBuild(String href1) {
 
     private void registerCriticalBuildProblemInStat(BuildRef build, ProblemOccurrences problems) {
         boolean criticalFail = problems.getProblemsNonNull().stream().anyMatch(occurrence ->
-            occurrence.isExecutionTimeout() || occurrence.isJvmCrash());
+            occurrence.isExecutionTimeout() || occurrence.isJvmCrash() || occurrence.isFailureOnMetric());
 
         String suiteId = build.suiteId();
         Integer buildId = build.getId();
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/TcHelper.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/TcHelper.java
index 3c56b4e2..44facf29 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/TcHelper.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/TcHelper.java
@@ -305,9 +305,15 @@ private String generateJiraComment(
             if (suiteRes.contains("exit code"))
                 failType = "exit code";
 
-            if(suiteRes.contains(ProblemOccurrence.JAVA_LEVEL_DEADLOCK.toLowerCase()))
+            if (suiteRes.contains(ProblemOccurrence.JAVA_LEVEL_DEADLOCK.toLowerCase()))
                 failType = "java level deadlock";
 
+            if (suiteRes.contains(ProblemOccurrence.BUILD_FAILURE_ON_MESSAGE.toLowerCase()))
+                failType = "build failure on message";
+
+            if (suiteRes.contains(ProblemOccurrence.BUILD_FAILURE_ON_METRIC.toLowerCase()))
+                failType = "build failure on metrics";
+
             if (failType == null) {
                 List<TestFailure> failures = new ArrayList<>();
 
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcmodel/result/problems/ProblemOccurrence.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcmodel/result/problems/ProblemOccurrence.java
index efbd438c..712c9dde 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcmodel/result/problems/ProblemOccurrence.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcmodel/result/problems/ProblemOccurrence.java
@@ -28,6 +28,7 @@
  */
 public class ProblemOccurrence {
     public static final String BUILD_FAILURE_ON_MESSAGE = "BuildFailureOnMessage";
+    public static final String BUILD_FAILURE_ON_METRIC = "BuildFailureOnMetric";
     public static final String TC_EXIT_CODE = "TC_EXIT_CODE";
     public static final String TC_OOME = "TC_OOME";
     public static final String TC_EXECUTION_TIMEOUT = "TC_EXECUTION_TIMEOUT";
@@ -50,6 +51,11 @@
      */
     @Nullable public BuildRef buildRef;
 
+    /** */
+    public boolean isFailureOnMetric() {
+        return BUILD_FAILURE_ON_METRIC.equals(type);
+    }
+
     public boolean isExecutionTimeout() {
         return TC_EXECUTION_TIMEOUT.equals(type);
     }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services