[GitHub] SomeFire commented on a change in pull request #90: IGNITE-10203 Fix TC Bot visa on Jira

[GitBox]

SomeFire commented on a change in pull request #90: IGNITE-10203 Fix TC Bot visa on Jira
URL: https://github.com/apache/ignite-teamcity-bot/pull/90#discussion_r239358963
 
 

 ##########
 File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/visa/TcBotTriggerAndSignOffService.java
 ##########
 @@ -394,8 +398,18 @@ String branchForTcB(String prId) {
 
         ITeamcityIgnited teamcity = teamcityIgnitedProvider.server(srvId, prov);
 
+        StringBuilder buildTypeId = new StringBuilder();
+
+        HelperConfig.getTrackedBranches().get(DEFAULT_TRACKED_BRANCH_NAME)
+            .ifPresent(b -> b.getChainsStream().filter(c -> c.branchForRest.equals(ITeamcity.DEFAULT))
+            .findFirst().ifPresent(ch -> buildTypeId.append(ch.suiteId)));
+
+        BuildTypeCompacted suite = teamcity.getBuildType(buildTypeId.toString());
 
 Review comment:
   Rename `suite` to `buildType`, `compositeBuildTypes` to `compositeBuildTypeIds`, `buildType` to `btId`. Don't forget to check string lengths.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services