[GitHub] SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid builds from the selection

[GitBox]

SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid builds from the selection
URL: https://github.com/apache/ignite-teamcity-bot/pull/38#discussion_r228498911
 
 

 ##########
 File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/build/GetBuildTestFailures.java
 ##########
 @@ -210,10 +255,10 @@ public BuildsHistory getBuildsHistory(
         if (Boolean.valueOf(skipTests))
             builder.skipTests();
 
-        BuildsHistory buildsHistory = builder.build();
+        BuildsHistory buildsHist = builder.build();
 
-        buildsHistory.initialize(ICredentialsProv.get(req), ctx);
+        buildsHist.initialize(ICredentialsProv.get(req), ctx);
 
 Review comment:
   Move authorization check outside of `initialize`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services