[GitHub] SomeFire commented on a change in pull request #15: Incremental build upload

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] SomeFire commented on a change in pull request #15: Incremental build upload

GitBox
SomeFire commented on a change in pull request #15: Incremental build upload
URL: https://github.com/apache/ignite-teamcity-bot/pull/15#discussion_r219074854
 
 

 ##########
 File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgniteTeamcityHelper.java
 ##########
 @@ -566,18 +561,21 @@ public ChangesList getChangesList(String href) {
     @Override public List<BuildRef> getFinishedBuilds(String projectId,
         String branch) {
 
-        return getFinishedBuilds(projectId, branch, null);
+        return getFinishedBuilds(projectId, branch, null, null);
     }
 
     /** {@inheritDoc} */
     @Override
     @AutoProfiling
     public List<BuildRef> getFinishedBuilds(String projectId,
-        String branch, Long cnt) {
+                                            String branch, Long cnt,
+                                            @Nullable Integer sinceBuildNumber) {
         List<BuildRef> finished = getBuildHistory(projectId,
             UrlUtil.escape(branch),
             true,
-            null, cnt);
+            null,
+                cnt,
 
 Review comment:
   Wrong indent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services