[GitHub] SomeFire commented on a change in pull request #14: Performance

[GitBox]

SomeFire commented on a change in pull request #14: Performance
URL: https://github.com/apache/ignite-teamcity-bot/pull/14#discussion_r218863424
 
 

 ##########
 File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/issue/IssueDetector.java
 ##########
 @@ -386,15 +386,17 @@ private void checkFailures() {
     private void checkFailuresEx() {
         int buildsToQry = EventTemplates.templates.stream().mapToInt(EventTemplate::cntEvents).max().getAsInt();
 
+        ExecutorService executor = MoreExecutors.newDirectExecutorService();
+
         GetTrackedBranchTestResults.getTrackedBranchTestFailures(FullQueryParams.DEFAULT_BRANCH_NAME,
-            false, buildsToQry, backgroundOpsTcHelper, backgroundOpsCreds);
+            false, buildsToQry, backgroundOpsTcHelper, backgroundOpsCreds, executor);
 
         TestFailuresSummary failures =
             GetTrackedBranchTestResults.getTrackedBranchTestFailures(FullQueryParams.DEFAULT_BRANCH_NAME,
                 false,
                 1,
                 backgroundOpsTcHelper,
-                backgroundOpsCreds);
+                backgroundOpsCreds, executor);
 
 Review comment:
   Move executor to a new line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[Dmitriy Pavlov]

Hi Dmitriy Ryabov,

could you please create and share INFRA ticket to disable comment
forwarding to the dev list?

Sincerely,
Dmitriy Pavlov

ср, 19 сент. 2018 г. в 19:02, GitBox <[hidden email]>:

> SomeFire commented on a change in pull request #14: Performance
> URL:
> https://github.com/apache/ignite-teamcity-bot/pull/14#discussion_r218863424
>
>
>
>  ##########
>  File path:
> ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/issue/IssueDetector.java
>  ##########
>  @@ -386,15 +386,17 @@ private void checkFailures() {
>      private void checkFailuresEx() {
>          int buildsToQry =
> EventTemplates.templates.stream().mapToInt(EventTemplate::cntEvents).max().getAsInt();
>
> +        ExecutorService executor =
> MoreExecutors.newDirectExecutorService();
> +
>
>  GetTrackedBranchTestResults.getTrackedBranchTestFailures(FullQueryParams.DEFAULT_BRANCH_NAME,
> -            false, buildsToQry, backgroundOpsTcHelper,
> backgroundOpsCreds);
> +            false, buildsToQry, backgroundOpsTcHelper,
> backgroundOpsCreds, executor);
>
>          TestFailuresSummary failures =
>
>  GetTrackedBranchTestResults.getTrackedBranchTestFailures(FullQueryParams.DEFAULT_BRANCH_NAME,
>                  false,
>                  1,
>                  backgroundOpsTcHelper,
> -                backgroundOpsCreds);
> +                backgroundOpsCreds, executor);
>
>  Review comment:
>    Move executor to a new line.
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> [hidden email]
>
>
> With regards,
> Apache Git Services
>

[Dmitrii Ryabov]

Hi, Dmitiy,

I created ticket [1] 3 days ago.

[1] https://issues.apache.org/jira/browse/INFRA-17032

2018-09-19 20:51 GMT+03:00 Dmitriy Pavlov <[hidden email]>:

> Hi Dmitriy Ryabov,
>
> could you please create and share INFRA ticket to disable comment
> forwarding to the dev list?
>
> Sincerely,
> Dmitriy Pavlov
>
> ср, 19 сент. 2018 г. в 19:02, GitBox <[hidden email]>:
>
> > SomeFire commented on a change in pull request #14: Performance
> > URL:
> > https://github.com/apache/ignite-teamcity-bot/pull/14#
> discussion_r218863424
> >
> >
> >
> >  ##########
> >  File path:
> > ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/
> issue/IssueDetector.java
> >  ##########
> >  @@ -386,15 +386,17 @@ private void checkFailures() {
> >      private void checkFailuresEx() {
> >          int buildsToQry =
> > EventTemplates.templates.stream().mapToInt(
> EventTemplate::cntEvents).max().getAsInt();
> >
> > +        ExecutorService executor =
> > MoreExecutors.newDirectExecutorService();
> > +
> >
> >  GetTrackedBranchTestResults.getTrackedBranchTestFailures(
> FullQueryParams.DEFAULT_BRANCH_NAME,
> > -            false, buildsToQry, backgroundOpsTcHelper,
> > backgroundOpsCreds);
> > +            false, buildsToQry, backgroundOpsTcHelper,
> > backgroundOpsCreds, executor);
> >
> >          TestFailuresSummary failures =
> >
> >  GetTrackedBranchTestResults.getTrackedBranchTestFailures(
> FullQueryParams.DEFAULT_BRANCH_NAME,
> >                  false,
> >                  1,
> >                  backgroundOpsTcHelper,
> > -                backgroundOpsCreds);
> > +                backgroundOpsCreds, executor);
> >
> >  Review comment:
> >    Move executor to a new line.
> >
> > ----------------------------------------------------------------
> > This is an automated message from the Apache Git Service.
> > To respond to the message, please log on GitHub and use the
> > URL above to go to the specific comment.
> >
> > For queries about this service, please contact Infrastructure at:
> > [hidden email]
> >
> >
> > With regards,
> > Apache Git Services
> >
>

[Dmitriy Pavlov]

Got it, thanks! I'll watch this ticket too.

пт, 21 сент. 2018 г. в 20:16, Dmitrii Ryabov <[hidden email]>:

> Hi, Dmitiy,
>
> I created ticket [1] 3 days ago.
>
> [1] https://issues.apache.org/jira/browse/INFRA-17032
>
> 2018-09-19 20:51 GMT+03:00 Dmitriy Pavlov <[hidden email]>:
>
>> Hi Dmitriy Ryabov,
>>
>> could you please create and share INFRA ticket to disable comment
>> forwarding to the dev list?
>>
>> Sincerely,
>> Dmitriy Pavlov
>>
>> ср, 19 сент. 2018 г. в 19:02, GitBox <[hidden email]>:
>>
>> > SomeFire commented on a change in pull request #14: Performance
>> > URL:
>> >
>> https://github.com/apache/ignite-teamcity-bot/pull/14#discussion_r218863424
>> >
>> >
>> >
>> >  ##########
>> >  File path:
>> >
>> ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/issue/IssueDetector.java
>> >  ##########
>> >  @@ -386,15 +386,17 @@ private void checkFailures() {
>> >      private void checkFailuresEx() {
>> >          int buildsToQry =
>> >
>> EventTemplates.templates.stream().mapToInt(EventTemplate::cntEvents).max().getAsInt();
>> >
>> > +        ExecutorService executor =
>> > MoreExecutors.newDirectExecutorService();
>> > +
>> >
>> >
>> GetTrackedBranchTestResults.getTrackedBranchTestFailures(FullQueryParams.DEFAULT_BRANCH_NAME,
>> > -            false, buildsToQry, backgroundOpsTcHelper,
>> > backgroundOpsCreds);
>> > +            false, buildsToQry, backgroundOpsTcHelper,
>> > backgroundOpsCreds, executor);
>> >
>> >          TestFailuresSummary failures =
>> >
>> >
>> GetTrackedBranchTestResults.getTrackedBranchTestFailures(FullQueryParams.DEFAULT_BRANCH_NAME,
>> >                  false,
>> >                  1,
>> >                  backgroundOpsTcHelper,
>> > -                backgroundOpsCreds);
>> > +                backgroundOpsCreds, executor);
>> >
>> >  Review comment:
>> >    Move executor to a new line.
>> >
>> > ----------------------------------------------------------------
>> > This is an automated message from the Apache Git Service.
>> > To respond to the message, please log on GitHub and use the
>> > URL above to go to the specific comment.
>> >
>> > For queries about this service, please contact Infrastructure at:
>> > [hidden email]
>> >
>> >
>> > With regards,
>> > Apache Git Services
>> >
>>
>
>