[GitHub] SomeFire commented on a change in pull request #14: Performance

[GitBox]

SomeFire commented on a change in pull request #14: Performance
URL: https://github.com/apache/ignite-teamcity-bot/pull/14#discussion_r218862350
 
 

 ##########
 File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/BuildChainProcessor.java
 ##########
 @@ -101,47 +109,24 @@
         Map<Integer, BuildRef> unique = new ConcurrentHashMap<>();
         Map<String, MultBuildRunCtx> buildsCtxMap = new ConcurrentHashMap<>();
 
-        entryPoints.stream()
-            .parallel()
-            .unordered()
-            .flatMap(ref -> dependencies(teamcity, ref)).filter(Objects::nonNull)
-            .flatMap(ref -> dependencies(teamcity, ref)).filter(Objects::nonNull)
-            .filter(ref -> ensureUnique(unique, ref))
-            .flatMap((BuildRef buildRef) -> {
-                    if (includeLatestRebuild == LatestRebuildMode.NONE)
-                        return Stream.of(buildRef);
-
-                    final String branch = getBranchOrDefault(buildRef.branchName);
-
-                    final List<BuildRef> builds = teamcity.getFinishedBuilds(buildRef.buildTypeId, branch);
-
-                    if (includeLatestRebuild == LatestRebuildMode.LATEST) {
-                        BuildRef recentRef = builds.stream().max(Comparator.comparing(BuildRef::getId)).orElse(buildRef);
-
-                        return Stream.of(recentRef.isFakeStub() ? buildRef : recentRef);
-                    }
-
-                    if (includeLatestRebuild == LatestRebuildMode.ALL) {
-                        return builds.stream()
-                            .filter(ref -> !ref.isFakeStub())
-                            .filter(ref -> ensureUnique(unique, ref))
-                            .sorted(Comparator.comparing(BuildRef::getId).reversed())
-                            .limit(entryPoints.size()); // applying same limit
-                    }
-
-                    throw new UnsupportedOperationException("invalid mode " + includeLatestRebuild);
-                }
-            )
-            .forEach((BuildRef buildRef) -> {
-                Build build = teamcity.getBuild(buildRef.href);
-
-                if (build == null || build.isFakeStub())
-                    return;
-
-                MultBuildRunCtx ctx = buildsCtxMap.computeIfAbsent(build.buildTypeId, k -> new MultBuildRunCtx(build));
-
-                ctx.addBuild(teamcity.loadTestsAndProblems(build, ctx));
-            });
+        Stream<? extends BuildRef> uniqueBuldsInvolved = entryPoints.stream()
+                .parallel()
+                .unordered()
+                .flatMap(ref -> dependencies(teamcity, ref)).filter(Objects::nonNull)
+                .flatMap(ref -> dependencies(teamcity, ref)).filter(Objects::nonNull)
+                .filter(ref -> ensureUnique(unique, ref));
+
+
+        uniqueBuldsInvolved
+                .map((buildRef) -> executor.submit(() -> {
+                    return replaceWithRecent(teamcity, includeLatestRebuild, unique, buildRef, entryPoints.size());
+                }))
+                .map(FutureUtil::getResult)
+                .map((s) -> executor.submit(()-> {
+                    return processBuildList(teamcity, buildsCtxMap, s);
+                        }
+                ))
 
 Review comment:
   Combine with previous line to make it like in `.map((buildRef) ->` call.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services