First contribute to Ignite ML

[Mark Andreev]

Hello, I want to join the Ignite community as a developer. My field of
interests is Machine learning, so I can start with extending
DistanceMeasure implementations (migrate from scipy).

Please, could you give me a contribution permission (username: mrkandreev)?

--
Best regards,
Mark Andreev

[dmagda]

Hi Mark,

Welcome to the community! Hope you'll find it delightful to contribute to
the Ignite ML component.

I've added you to JIRA's contributors' list, so you're good to go. Just in
case, @Alexey Zinoviev <[hidden email]>  is our main ML maintainer,
but, probably, you already know him.

-
Denis


On Mon, Aug 24, 2020 at 3:42 PM Mark Andreev <[hidden email]> wrote:

> Hello, I want to join the Ignite community as a developer. My field of
> interests is Machine learning, so I can start with extending
> DistanceMeasure implementations (migrate from scipy).
>
> Please, could you give me a contribution permission (username: mrkandreev)?
>
> --
> Best regards,
> Mark Andreev
>

[Mark Andreev]

Hi, @Alexey Zinoviev <[hidden email]>.

Currently, Ignite supports only these distances
(org.apache.ignite.ml.math.distances) :
- ChebyshevDistance
- CosineSimilarity
- EuclideanDistance
- HammingDistance
- JaccardIndex
- ManhattanDistance
- MinkowskiDistance

But in scipy (
https://docs.scipy.org/doc/scipy/reference/spatial.distance.html) we can
find at least:
- BrayCurtis
- Canberra
- Jensen-Shannon
- Seuclidean
- Weighted Minkowski

I can implement those and coverage with unit tests.

On Tue, 25 Aug 2020 at 02:36, Denis Magda <[hidden email]> wrote:

> Hi Mark,
>
> Welcome to the community! Hope you'll find it delightful to contribute to
> the Ignite ML component.
>
> I've added you to JIRA's contributors' list, so you're good to go. Just in
> case, @Alexey Zinoviev <[hidden email]>  is our main ML
> maintainer,
> but, probably, you already know him.
>
> -
> Denis
>
>
> On Mon, Aug 24, 2020 at 3:42 PM Mark Andreev <[hidden email]>
> wrote:
>
> > Hello, I want to join the Ignite community as a developer. My field of
> > interests is Machine learning, so I can start with extending
> > DistanceMeasure implementations (migrate from scipy).
> >
> > Please, could you give me a contribution permission (username:
> mrkandreev)?
> >
> > --
> > Best regards,
> > Mark Andreev
> >
>

--
Best regards,
Mark Andreev

[Alexey Zinoviev]

Great, I'll create a ticket for that case and assign it for you, I think it
could be very useful contribution.



вт, 25 авг. 2020 г., 10:07 Mark Andreev <[hidden email]>:

> Hi, @Alexey Zinoviev <[hidden email]>.
>
> Currently, Ignite supports only these distances
> (org.apache.ignite.ml.math.distances) :
> - ChebyshevDistance
> - CosineSimilarity
> - EuclideanDistance
> - HammingDistance
> - JaccardIndex
> - ManhattanDistance
> - MinkowskiDistance
>
> But in scipy (
> https://docs.scipy.org/doc/scipy/reference/spatial.distance.html) we can
> find at least:
> - BrayCurtis
> - Canberra
> - Jensen-Shannon
> - Seuclidean
> - Weighted Minkowski
>
> I can implement those and coverage with unit tests.
>
> On Tue, 25 Aug 2020 at 02:36, Denis Magda <[hidden email]> wrote:
>
> > Hi Mark,
> >
> > Welcome to the community! Hope you'll find it delightful to contribute to
> > the Ignite ML component.
> >
> > I've added you to JIRA's contributors' list, so you're good to go. Just
> in
> > case, @Alexey Zinoviev <[hidden email]>  is our main ML
> > maintainer,
> > but, probably, you already know him.
> >
> > -
> > Denis
> >
> >
> > On Mon, Aug 24, 2020 at 3:42 PM Mark Andreev <[hidden email]>
> > wrote:
> >
> > > Hello, I want to join the Ignite community as a developer. My field of
> > > interests is Machine learning, so I can start with extending
> > > DistanceMeasure implementations (migrate from scipy).
> > >
> > > Please, could you give me a contribution permission (username:
> > mrkandreev)?
> > >
> > > --
> > > Best regards,
> > > Mark Andreev
> > >
> >
>
>
> --
> Best regards,
> Mark Andreev
>

[Alexey Zinoviev]

Hi, Mark, I've created a ticket and assigned on you
https://issues.apache.org/jira/browse/IGNITE-13386

Create PR to the main repository according the next schema
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute
process is described in the chapter " Git Process "

Keep in mind next coding guidelines
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-JavadocComments


We have automated checks for part of them as a part of the CI.

As a reference PR you could have a look to
https://issues.apache.org/jira/browse/IGNITE-12383 related to the distances.
Good luck!
Alex


вт, 25 авг. 2020 г. в 10:42, Alexey Zinoviev <[hidden email]>:

> Great, I'll create a ticket for that case and assign it for you, I think
> it could be very useful contribution.
>
>
>
> вт, 25 авг. 2020 г., 10:07 Mark Andreev <[hidden email]>:
>
>> Hi, @Alexey Zinoviev <[hidden email]>.
>>
>> Currently, Ignite supports only these distances
>> (org.apache.ignite.ml.math.distances) :
>> - ChebyshevDistance
>> - CosineSimilarity
>> - EuclideanDistance
>> - HammingDistance
>> - JaccardIndex
>> - ManhattanDistance
>> - MinkowskiDistance
>>
>> But in scipy (
>> https://docs.scipy.org/doc/scipy/reference/spatial.distance.html) we can
>> find at least:
>> - BrayCurtis
>> - Canberra
>> - Jensen-Shannon
>> - Seuclidean
>> - Weighted Minkowski
>>
>> I can implement those and coverage with unit tests.
>>
>> On Tue, 25 Aug 2020 at 02:36, Denis Magda <[hidden email]> wrote:
>>
>> > Hi Mark,
>> >
>> > Welcome to the community! Hope you'll find it delightful to contribute
>> to
>> > the Ignite ML component.
>> >
>> > I've added you to JIRA's contributors' list, so you're good to go. Just
>> in
>> > case, @Alexey Zinoviev <[hidden email]>  is our main ML
>> > maintainer,
>> > but, probably, you already know him.
>> >
>> > -
>> > Denis
>> >
>> >
>> > On Mon, Aug 24, 2020 at 3:42 PM Mark Andreev <[hidden email]>
>> > wrote:
>> >
>> > > Hello, I want to join the Ignite community as a developer. My field of
>> > > interests is Machine learning, so I can start with extending
>> > > DistanceMeasure implementations (migrate from scipy).
>> > >
>> > > Please, could you give me a contribution permission (username:
>> > mrkandreev)?
>> > >
>> > > --
>> > > Best regards,
>> > > Mark Andreev
>> > >
>> >
>>
>>
>> --
>> Best regards,
>> Mark Andreev
>>
>

[Mark Andreev]

Hi,

I have created a PR for BrayCurtis,Canberra,JensenShannon,WeightedMinkowski
distances.

Jira https://issues.apache.org/jira/browse/IGNITE-13386
PR https://github.com/apache/ignite/pull/8197

Please review and share feedback.

On Wed, 26 Aug 2020 at 16:11, Alexey Zinoviev <[hidden email]>
wrote:

> Hi, Mark, I've created a ticket and assigned on you
> https://issues.apache.org/jira/browse/IGNITE-13386
>
> Create PR to the main repository according the next schema
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute
> process is described in the chapter " Git Process "
>
> Keep in mind next coding guidelines
>
> https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-JavadocComments
>
>
> We have automated checks for part of them as a part of the CI.
>
> As a reference PR you could have a look to
> https://issues.apache.org/jira/browse/IGNITE-12383 related to the
> distances.
> Good luck!
> Alex
>
>
> вт, 25 авг. 2020 г. в 10:42, Alexey Zinoviev <[hidden email]>:
>
> > Great, I'll create a ticket for that case and assign it for you, I think
> > it could be very useful contribution.
> >
> >
> >
> > вт, 25 авг. 2020 г., 10:07 Mark Andreev <[hidden email]>:
> >
> >> Hi, @Alexey Zinoviev <[hidden email]>.
> >>
> >> Currently, Ignite supports only these distances
> >> (org.apache.ignite.ml.math.distances) :
> >> - ChebyshevDistance
> >> - CosineSimilarity
> >> - EuclideanDistance
> >> - HammingDistance
> >> - JaccardIndex
> >> - ManhattanDistance
> >> - MinkowskiDistance
> >>
> >> But in scipy (
> >> https://docs.scipy.org/doc/scipy/reference/spatial.distance.html) we
> can
> >> find at least:
> >> - BrayCurtis
> >> - Canberra
> >> - Jensen-Shannon
> >> - Seuclidean
> >> - Weighted Minkowski
> >>
> >> I can implement those and coverage with unit tests.
> >>
> >> On Tue, 25 Aug 2020 at 02:36, Denis Magda <[hidden email]> wrote:
> >>
> >> > Hi Mark,
> >> >
> >> > Welcome to the community! Hope you'll find it delightful to contribute
> >> to
> >> > the Ignite ML component.
> >> >
> >> > I've added you to JIRA's contributors' list, so you're good to go.
> Just
> >> in
> >> > case, @Alexey Zinoviev <[hidden email]>  is our main ML
> >> > maintainer,
> >> > but, probably, you already know him.
> >> >
> >> > -
> >> > Denis
> >> >
> >> >
> >> > On Mon, Aug 24, 2020 at 3:42 PM Mark Andreev <[hidden email]>
> >> > wrote:
> >> >
> >> > > Hello, I want to join the Ignite community as a developer. My field
> of
> >> > > interests is Machine learning, so I can start with extending
> >> > > DistanceMeasure implementations (migrate from scipy).
> >> > >
> >> > > Please, could you give me a contribution permission (username:
> >> > mrkandreev)?
> >> > >
> >> > > --
> >> > > Best regards,
> >> > > Mark Andreev
> >> > >
> >> >
> >>
> >>
> >> --
> >> Best regards,
> >> Mark Andreev
> >>
> >
>

--
Best regards,
Mark Andreev

[Alexey Zinoviev]

Great, I'll try to review at the end of this week

пн, 31 авг. 2020 г. в 09:02, Mark Andreev <[hidden email]>:

> Hi,
>
> I have created a PR for BrayCurtis,Canberra,JensenShannon,WeightedMinkowski
> distances.
>
> Jira https://issues.apache.org/jira/browse/IGNITE-13386
> PR https://github.com/apache/ignite/pull/8197
>
> Please review and share feedback.
>
> On Wed, 26 Aug 2020 at 16:11, Alexey Zinoviev <[hidden email]>
> wrote:
>
> > Hi, Mark, I've created a ticket and assigned on you
> > https://issues.apache.org/jira/browse/IGNITE-13386
> >
> > Create PR to the main repository according the next schema
> > https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute
> > process is described in the chapter " Git Process "
> >
> > Keep in mind next coding guidelines
> >
> >
> https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-JavadocComments
> >
> >
> > We have automated checks for part of them as a part of the CI.
> >
> > As a reference PR you could have a look to
> > https://issues.apache.org/jira/browse/IGNITE-12383 related to the
> > distances.
> > Good luck!
> > Alex
> >
> >
> > вт, 25 авг. 2020 г. в 10:42, Alexey Zinoviev <[hidden email]>:
> >
> > > Great, I'll create a ticket for that case and assign it for you, I
> think
> > > it could be very useful contribution.
> > >
> > >
> > >
> > > вт, 25 авг. 2020 г., 10:07 Mark Andreev <[hidden email]>:
> > >
> > >> Hi, @Alexey Zinoviev <[hidden email]>.
> > >>
> > >> Currently, Ignite supports only these distances
> > >> (org.apache.ignite.ml.math.distances) :
> > >> - ChebyshevDistance
> > >> - CosineSimilarity
> > >> - EuclideanDistance
> > >> - HammingDistance
> > >> - JaccardIndex
> > >> - ManhattanDistance
> > >> - MinkowskiDistance
> > >>
> > >> But in scipy (
> > >> https://docs.scipy.org/doc/scipy/reference/spatial.distance.html) we
> > can
> > >> find at least:
> > >> - BrayCurtis
> > >> - Canberra
> > >> - Jensen-Shannon
> > >> - Seuclidean
> > >> - Weighted Minkowski
> > >>
> > >> I can implement those and coverage with unit tests.
> > >>
> > >> On Tue, 25 Aug 2020 at 02:36, Denis Magda <[hidden email]> wrote:
> > >>
> > >> > Hi Mark,
> > >> >
> > >> > Welcome to the community! Hope you'll find it delightful to
> contribute
> > >> to
> > >> > the Ignite ML component.
> > >> >
> > >> > I've added you to JIRA's contributors' list, so you're good to go.
> > Just
> > >> in
> > >> > case, @Alexey Zinoviev <[hidden email]>  is our main ML
> > >> > maintainer,
> > >> > but, probably, you already know him.
> > >> >
> > >> > -
> > >> > Denis
> > >> >
> > >> >
> > >> > On Mon, Aug 24, 2020 at 3:42 PM Mark Andreev <
> [hidden email]>
> > >> > wrote:
> > >> >
> > >> > > Hello, I want to join the Ignite community as a developer. My
> field
> > of
> > >> > > interests is Machine learning, so I can start with extending
> > >> > > DistanceMeasure implementations (migrate from scipy).
> > >> > >
> > >> > > Please, could you give me a contribution permission (username:
> > >> > mrkandreev)?
> > >> > >
> > >> > > --
> > >> > > Best regards,
> > >> > > Mark Andreev
> > >> > >
> > >> >
> > >>
> > >>
> > >> --
> > >> Best regards,
> > >> Mark Andreev
> > >>
> > >
> >
>
>
> --
> Best regards,
> Mark Andreev
>