Failing tests question

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Failing tests question

Patrick Peralta
Hello list!

According to the coding guidelines[1], we should do the following for tests that fail due to a known defect:

--
We try to not use commented code. So, in case if test(s) is broken the test should be muted on TeamCity with a related to JIRA ticket comment which describe a reason of fail. If test hangs or works too long then

fail("https://issues.apache.org/jira/browse/IGNITE-1113”);
--

I assume that TeamCity has a way of ignoring these test failures. Is this a feature in TeamCity, or is this part of the Maven build?
Is the status of the JIRA ticket taken into account? For instance, if the ticket is marked closed, will the test still be ignored?

Thanks!
Patrick

1. https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines

Patrick Peralta
Senior Server Engineer
Workday, Inc.
617-852-8388 (mobile)
[hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Failing tests question

Denis Magda
Hi Patrick,

Historically, such tests had to be explicitly muted on TeamCity. Here is an example of muted tests
http://149.202.210.143:8111/viewLog.html?buildId=301551&tab=buildResultsDiv&buildTypeId=IgniteTests_IgniteAws <http://149.202.210.143:8111/viewLog.html?buildId=301551&tab=buildResultsDiv&buildTypeId=IgniteTests_IgniteAws>

When you mute a test you can say that the test should be automatically un-muted once it passes or it should be un-muted explicitly by a contributor. TeamCity doesn’t treat JIRA statuses at all.

However Vladimir Ozerov, recently proposed and implemented a more flexible solution based on @IgniteIgnore annotation.
Vladimir can you describe how this annotation can be leveraged and update our coding guidelines if needed.


Denis

> On Aug 22, 2016, at 6:58 AM, Patrick Peralta <[hidden email]> wrote:
>
> Hello list!
>
> According to the coding guidelines[1], we should do the following for tests that fail due to a known defect:
>
> --
> We try to not use commented code. So, in case if test(s) is broken the test should be muted on TeamCity with a related to JIRA ticket comment which describe a reason of fail. If test hangs or works too long then
>
> fail("https://issues.apache.org/jira/browse/IGNITE-1113”);
> --
>
> I assume that TeamCity has a way of ignoring these test failures. Is this a feature in TeamCity, or is this part of the Maven build?
> Is the status of the JIRA ticket taken into account? For instance, if the ticket is marked closed, will the test still be ignored?
>
> Thanks!
> Patrick
>
> 1. https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines
>
> Patrick Peralta
> Senior Server Engineer
> Workday, Inc.
> 617-852-8388 (mobile)
> [hidden email]
>