Erroneous Baseline Topology documentation

[Ivan Rakov]

Igniters,

Seems like we have an inconsistency in our Baseline Topology
documentation:
https://apacheignite.readme.io/docs/baseline-topology#section-setting-the-topology-from-code

> Java developers can use the IgniteCluster interface to initialize the
> very first baseline topology or to adjust an existing one. The sample
> below shows how to add all the existing server nodes to the baseline
> topology:​
> // Connecting to the cluster.
> Ignite ignite = Ignition.start();
>
> // Setting the baseline topology to a specific Ignite cluster topology
> version.
> ignite.cluster().setBaselineTopology(2);

This is not true; baseline topology can't be changed on inactive
cluster. The only viable way to initialize the very first baseline
topology is manual cluster activation. This is correctly explained in
this section:
https://apacheignite.readme.io/docs/baseline-topology#section-first-cluster-startup

--
Best Regards,
Ivan Rakov

[Denis Magda]

Prachi,

I do remember that that code, Ivan is referring to, worked fine for you.
Please double check. Probably you need to add "ignite.cluster.activate()"
to the code snippet.

--
Denis

On Tue, Jul 3, 2018 at 12:19 PM Ivan Rakov <[hidden email]> wrote:

> Igniters,
>
> Seems like we have an inconsistency in our Baseline Topology
> documentation:
>
> https://apacheignite.readme.io/docs/baseline-topology#section-setting-the-topology-from-code
>
> > Java developers can use the IgniteCluster interface to initialize the
> > very first baseline topology or to adjust an existing one. The sample
> > below shows how to add all the existing server nodes to the baseline
> > topology:​
> > // Connecting to the cluster.
> > Ignite ignite = Ignition.start();
> >
> > // Setting the baseline topology to a specific Ignite cluster topology
> > version.
> > ignite.cluster().setBaselineTopology(2);
> This is not true; baseline topology can't be changed on inactive
> cluster. The only viable way to initialize the very first baseline
> topology is manual cluster activation. This is correctly explained in
> this section:
>
> https://apacheignite.readme.io/docs/baseline-topology#section-first-cluster-startup
>
> --
> Best Regards,
> Ivan Rakov
>
>

[Ivan Rakov]

I've tried to execute exactly the same code, it resulted with

> class org.apache.ignite.IgniteException: Changing BaselineTopology on
> inactive cluster is not allowed.
Basically, the code snippet is in "Setting the Topology From Code"
section, so we can make it correct by just removing "activation" and
"first baseline topology" parts.

Best Regards,
Ivan Rakov


On 03.07.2018 22:30, Denis Magda wrote:

> Prachi,
>
> I do remember that that code, Ivan is referring to, worked fine for you.
> Please double check. Probably you need to add "ignite.cluster.activate()"
> to the code snippet.
>
> --
> Denis
>
> On Tue, Jul 3, 2018 at 12:19 PM Ivan Rakov <[hidden email]> wrote:
>
>> Igniters,
>>
>> Seems like we have an inconsistency in our Baseline Topology
>> documentation:
>>
>> https://apacheignite.readme.io/docs/baseline-topology#section-setting-the-topology-from-code
>>
>>> Java developers can use the IgniteCluster interface to initialize the
>>> very first baseline topology or to adjust an existing one. The sample
>>> below shows how to add all the existing server nodes to the baseline
>>> topology:​
>>> // Connecting to the cluster.
>>> Ignite ignite = Ignition.start();
>>>
>>> // Setting the baseline topology to a specific Ignite cluster topology
>>> version.
>>> ignite.cluster().setBaselineTopology(2);
>> This is not true; baseline topology can't be changed on inactive
>> cluster. The only viable way to initialize the very first baseline
>> topology is manual cluster activation. This is correctly explained in
>> this section:
>>
>> https://apacheignite.readme.io/docs/baseline-topology#section-first-cluster-startup
>>
>> --
>> Best Regards,
>> Ivan Rakov
>>
>>

[Prachi Garg]

Hi Ivan,

I have fixed and rephrased the section -
https://apacheignite.readme.io/v2.5/docs/baseline-topology#section-cluster-activation

However, I have a question regarding setting the baseline topology when
activating the cluster for the first time. In the web console, when we
activate the cluster, using the toggle switch, all server nodes in the
cluster are automatically added to the baseline topology. Does this mean
that when we activate the cluster for the first time, via code, we do not
need the following piece code?

// Get all server nodes that are already up and running.
Collection<ClusterNode> nodes = ignite.cluster().forServers().nodes();

// Set the baseline topology that is represented by these nodes.
ignite.cluster().setBaselineTopology(nodes);

I guess just activating the cluster would add all the existing nodes to the
baseline topology?



On Tue, Jul 3, 2018 at 12:48 PM, Ivan Rakov <[hidden email]> wrote:

> I've tried to execute exactly the same code, it resulted with
>
> class org.apache.ignite.IgniteException: Changing BaselineTopology on
>> inactive cluster is not allowed.
>>
> Basically, the code snippet is in "Setting the Topology From Code"
> section, so we can make it correct by just removing "activation" and "first
> baseline topology" parts.
>
> Best Regards,
> Ivan Rakov
>
>
>
> On 03.07.2018 22:30, Denis Magda wrote:
>
>> Prachi,
>>
>> I do remember that that code, Ivan is referring to, worked fine for you.
>> Please double check. Probably you need to add "ignite.cluster.activate()"
>> to the code snippet.
>>
>> --
>> Denis
>>
>> On Tue, Jul 3, 2018 at 12:19 PM Ivan Rakov <[hidden email]> wrote:
>>
>> Igniters,
>>>
>>> Seems like we have an inconsistency in our Baseline Topology
>>> documentation:
>>>
>>> https://apacheignite.readme.io/docs/baseline-topology#sectio
>>> n-setting-the-topology-from-code
>>>
>>> Java developers can use the IgniteCluster interface to initialize the
>>>> very first baseline topology or to adjust an existing one. The sample
>>>> below shows how to add all the existing server nodes to the baseline
>>>> topology:​
>>>> // Connecting to the cluster.
>>>> Ignite ignite = Ignition.start();
>>>>
>>>> // Setting the baseline topology to a specific Ignite cluster topology
>>>> version.
>>>> ignite.cluster().setBaselineTopology(2);
>>>>
>>> This is not true; baseline topology can't be changed on inactive
>>> cluster. The only viable way to initialize the very first baseline
>>> topology is manual cluster activation. This is correctly explained in
>>> this section:
>>>
>>> https://apacheignite.readme.io/docs/baseline-topology#sectio
>>> n-first-cluster-startup
>>>
>>> --
>>> Best Regards,
>>> Ivan Rakov
>>>
>>>
>>>
>

[Ivan Rakov]

> I guess just activating the cluster would add all the existing nodes
> to the baseline topology?
Exactly. Persistent cluster can't exist in active state without baseline
topology. First activation will establish BLT from current set of server
nodes.

Best Regards,
Ivan Rakov

On 04.07.2018 1:55, Prachi Garg wrote:

> Hi Ivan,
>
> I have fixed and rephrased the section -
> https://apacheignite.readme.io/v2.5/docs/baseline-topology#section-cluster-activation
>
> However, I have a question regarding setting the baseline topology
> when activating the cluster for the first time. In the web console,
> when we activate the cluster, using the toggle switch, all server
> nodes in the cluster are automatically added to the baseline topology.
> Does this mean that when we activate the cluster for the first time,
> via code, we do not need the following piece code?
>
> // Get all server nodes that are already up and running.
> Collection<ClusterNode> nodes = ignite.cluster().forServers().nodes();
>
> // Set the baseline topology that is represented by these nodes.
> ignite.cluster().setBaselineTopology(nodes);
>
> I guess just activating the cluster would add all the existing nodes
> to the baseline topology?
>
>
>
> On Tue, Jul 3, 2018 at 12:48 PM, Ivan Rakov <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     I've tried to execute exactly the same code, it resulted with
>
>         class org.apache.ignite.IgniteException: Changing
>         BaselineTopology on inactive cluster is not allowed.
>
>     Basically, the code snippet is in "Setting the Topology From Code"
>     section, so we can make it correct by just removing "activation"
>     and "first baseline topology" parts.
>
>     Best Regards,
>     Ivan Rakov
>
>
>
>     On 03.07.2018 22:30, Denis Magda wrote:
>
>         Prachi,
>
>         I do remember that that code, Ivan is referring to, worked
>         fine for you.
>         Please double check. Probably you need to add
>         "ignite.cluster.activate()"
>         to the code snippet.
>
>         --
>         Denis
>
>         On Tue, Jul 3, 2018 at 12:19 PM Ivan Rakov
>         <[hidden email] <mailto:[hidden email]>> wrote:
>
>             Igniters,
>
>             Seems like we have an inconsistency in our Baseline Topology
>             documentation:
>
>             https://apacheignite.readme.io/docs/baseline-topology#section-setting-the-topology-from-code
>             <https://apacheignite.readme.io/docs/baseline-topology#section-setting-the-topology-from-code>
>
>                 Java developers can use the IgniteCluster interface to
>                 initialize the
>                 very first baseline topology or to adjust an existing
>                 one. The sample
>                 below shows how to add all the existing server nodes
>                 to the baseline
>                 topology:​
>                 // Connecting to the cluster.
>                 Ignite ignite = Ignition.start();
>
>                 // Setting the baseline topology to a specific Ignite
>                 cluster topology
>                 version.
>                 ignite.cluster().setBaselineTopology(2);
>
>             This is not true; baseline topology can't be changed on
>             inactive
>             cluster. The only viable way to initialize the very first
>             baseline
>             topology is manual cluster activation. This is correctly
>             explained in
>             this section:
>
>             https://apacheignite.readme.io/docs/baseline-topology#section-first-cluster-startup
>             <https://apacheignite.readme.io/docs/baseline-topology#section-first-cluster-startup>
>
>             --
>             Best Regards,
>             Ivan Rakov
>
>
>
>

[Prachi Garg]

Thanks Ivan. I will fix the doc accordingly.

On Thu, Jul 5, 2018 at 5:31 AM, Ivan Rakov <[hidden email]> wrote:

> I guess just activating the cluster would add all the existing nodes to
> the baseline topology?
>
> Exactly. Persistent cluster can't exist in active state without baseline
> topology. First activation will establish BLT from current set of server
> nodes.
>
> Best Regards,
> Ivan Rakov
>
> On 04.07.2018 1:55, Prachi Garg wrote:
>
> Hi Ivan,
>
> I have fixed and rephrased the section - https://apacheignite.readme.
> io/v2.5/docs/baseline-topology#section-cluster-activation
>
> However, I have a question regarding setting the baseline topology when
> activating the cluster for the first time. In the web console, when we
> activate the cluster, using the toggle switch, all server nodes in the
> cluster are automatically added to the baseline topology. Does this mean
> that when we activate the cluster for the first time, via code, we do not
> need the following piece code?
>
> // Get all server nodes that are already up and running.
> Collection<ClusterNode> nodes = ignite.cluster().forServers().nodes();
>
> // Set the baseline topology that is represented by these nodes.
> ignite.cluster().setBaselineTopology(nodes);
>
> I guess just activating the cluster would add all the existing nodes to
> the baseline topology?
>
>
>
> On Tue, Jul 3, 2018 at 12:48 PM, Ivan Rakov <[hidden email]> wrote:
>
>> I've tried to execute exactly the same code, it resulted with
>>
>> class org.apache.ignite.IgniteException: Changing BaselineTopology on
>>> inactive cluster is not allowed.
>>>
>> Basically, the code snippet is in "Setting the Topology From Code"
>> section, so we can make it correct by just removing "activation" and "first
>> baseline topology" parts.
>>
>> Best Regards,
>> Ivan Rakov
>>
>>
>>
>> On 03.07.2018 22:30, Denis Magda wrote:
>>
>>> Prachi,
>>>
>>> I do remember that that code, Ivan is referring to, worked fine for you.
>>> Please double check. Probably you need to add "ignite.cluster.activate()"
>>> to the code snippet.
>>>
>>> --
>>> Denis
>>>
>>> On Tue, Jul 3, 2018 at 12:19 PM Ivan Rakov <[hidden email]>
>>> wrote:
>>>
>>> Igniters,
>>>>
>>>> Seems like we have an inconsistency in our Baseline Topology
>>>> documentation:
>>>>
>>>> https://apacheignite.readme.io/docs/baseline-topology#sectio
>>>> n-setting-the-topology-from-code
>>>>
>>>> Java developers can use the IgniteCluster interface to initialize the
>>>>> very first baseline topology or to adjust an existing one. The sample
>>>>> below shows how to add all the existing server nodes to the baseline
>>>>> topology:​
>>>>> // Connecting to the cluster.
>>>>> Ignite ignite = Ignition.start();
>>>>>
>>>>> // Setting the baseline topology to a specific Ignite cluster topology
>>>>> version.
>>>>> ignite.cluster().setBaselineTopology(2);
>>>>>
>>>> This is not true; baseline topology can't be changed on inactive
>>>> cluster. The only viable way to initialize the very first baseline
>>>> topology is manual cluster activation. This is correctly explained in
>>>> this section:
>>>>
>>>> https://apacheignite.readme.io/docs/baseline-topology#sectio
>>>> n-first-cluster-startup
>>>>
>>>> --
>>>> Best Regards,
>>>> Ivan Rakov
>>>>
>>>>
>>>>
>>
>
>

[Prachi Garg]

Ivan,

I have fixed the documentation for baseline topology. Please review -
https://apacheignite.readme.io/v2.5/docs/baseline-topology#section-cluster-activation

-P

On Thu, Jul 5, 2018 at 11:55 AM, Prachi Garg <[hidden email]> wrote:

> Thanks Ivan. I will fix the doc accordingly.
>
> On Thu, Jul 5, 2018 at 5:31 AM, Ivan Rakov <[hidden email]> wrote:
>
>> I guess just activating the cluster would add all the existing nodes to
>> the baseline topology?
>>
>> Exactly. Persistent cluster can't exist in active state without baseline
>> topology. First activation will establish BLT from current set of server
>> nodes.
>>
>> Best Regards,
>> Ivan Rakov
>>
>> On 04.07.2018 1:55, Prachi Garg wrote:
>>
>> Hi Ivan,
>>
>> I have fixed and rephrased the section - https://apacheignite.readme.
>> io/v2.5/docs/baseline-topology#section-cluster-activation
>>
>> However, I have a question regarding setting the baseline topology when
>> activating the cluster for the first time. In the web console, when we
>> activate the cluster, using the toggle switch, all server nodes in the
>> cluster are automatically added to the baseline topology. Does this mean
>> that when we activate the cluster for the first time, via code, we do not
>> need the following piece code?
>>
>> // Get all server nodes that are already up and running.
>> Collection<ClusterNode> nodes = ignite.cluster().forServers().nodes();
>>
>> // Set the baseline topology that is represented by these nodes.
>> ignite.cluster().setBaselineTopology(nodes);
>>
>> I guess just activating the cluster would add all the existing nodes to
>> the baseline topology?
>>
>>
>>
>> On Tue, Jul 3, 2018 at 12:48 PM, Ivan Rakov <[hidden email]>
>> wrote:
>>
>>> I've tried to execute exactly the same code, it resulted with
>>>
>>> class org.apache.ignite.IgniteException: Changing BaselineTopology on
>>>> inactive cluster is not allowed.
>>>>
>>> Basically, the code snippet is in "Setting the Topology From Code"
>>> section, so we can make it correct by just removing "activation" and "first
>>> baseline topology" parts.
>>>
>>> Best Regards,
>>> Ivan Rakov
>>>
>>>
>>>
>>> On 03.07.2018 22:30, Denis Magda wrote:
>>>
>>>> Prachi,
>>>>
>>>> I do remember that that code, Ivan is referring to, worked fine for you.
>>>> Please double check. Probably you need to add
>>>> "ignite.cluster.activate()"
>>>> to the code snippet.
>>>>
>>>> --
>>>> Denis
>>>>
>>>> On Tue, Jul 3, 2018 at 12:19 PM Ivan Rakov <[hidden email]>
>>>> wrote:
>>>>
>>>> Igniters,
>>>>>
>>>>> Seems like we have an inconsistency in our Baseline Topology
>>>>> documentation:
>>>>>
>>>>> https://apacheignite.readme.io/docs/baseline-topology#sectio
>>>>> n-setting-the-topology-from-code
>>>>>
>>>>> Java developers can use the IgniteCluster interface to initialize the
>>>>>> very first baseline topology or to adjust an existing one. The sample
>>>>>> below shows how to add all the existing server nodes to the baseline
>>>>>> topology:​
>>>>>> // Connecting to the cluster.
>>>>>> Ignite ignite = Ignition.start();
>>>>>>
>>>>>> // Setting the baseline topology to a specific Ignite cluster topology
>>>>>> version.
>>>>>> ignite.cluster().setBaselineTopology(2);
>>>>>>
>>>>> This is not true; baseline topology can't be changed on inactive
>>>>> cluster. The only viable way to initialize the very first baseline
>>>>> topology is manual cluster activation. This is correctly explained in
>>>>> this section:
>>>>>
>>>>> https://apacheignite.readme.io/docs/baseline-topology#sectio
>>>>> n-first-cluster-startup
>>>>>
>>>>> --
>>>>> Best Regards,
>>>>> Ivan Rakov
>>>>>
>>>>>
>>>>>
>>>
>>
>>
>

[Ivan Rakov]

Prachi, thanks!

Documentation looks good now.

Best Regards,
Ivan Rakov

On 09.07.2018 22:06, Prachi Garg wrote:

> Ivan,
>
> I have fixed the documentation for baseline topology. Please review -
> https://apacheignite.readme.io/v2.5/docs/baseline-topology#section-cluster-activation
>
> -P
>
> On Thu, Jul 5, 2018 at 11:55 AM, Prachi Garg <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     Thanks Ivan. I will fix the doc accordingly.
>
>     On Thu, Jul 5, 2018 at 5:31 AM, Ivan Rakov <[hidden email]
>     <mailto:[hidden email]>> wrote:
>
>>         I guess just activating the cluster would add all the
>>         existing nodes to the baseline topology?
>         Exactly. Persistent cluster can't exist in active state
>         without baseline topology. First activation will establish BLT
>         from current set of server nodes.
>
>         Best Regards,
>         Ivan Rakov
>
>         On 04.07.2018 1:55, Prachi Garg wrote:
>>         Hi Ivan,
>>
>>         I have fixed and rephrased the section -
>>         https://apacheignite.readme.io/v2.5/docs/baseline-topology#section-cluster-activation
>>         <https://apacheignite.readme.io/v2.5/docs/baseline-topology#section-cluster-activation>
>>
>>         However, I have a question regarding setting the baseline
>>         topology when activating the cluster for the first time. In
>>         the web console, when we activate the cluster, using the
>>         toggle switch, all server nodes in the cluster are
>>         automatically added to the baseline topology. Does this mean
>>         that when we activate the cluster for the first time, via
>>         code, we do not need the following piece code?
>>
>>         // Get all server nodes that are already up and running.
>>         Collection<ClusterNode> nodes =
>>         ignite.cluster().forServers().nodes();
>>
>>         // Set the baseline topology that is represented by these nodes.
>>         ignite.cluster().setBaselineTopology(nodes);
>>
>>         I guess just activating the cluster would add all the
>>         existing nodes to the baseline topology?
>>
>>
>>
>>         On Tue, Jul 3, 2018 at 12:48 PM, Ivan Rakov
>>         <[hidden email] <mailto:[hidden email]>> wrote:
>>
>>             I've tried to execute exactly the same code, it resulted with
>>
>>                 class org.apache.ignite.IgniteException: Changing
>>                 BaselineTopology on inactive cluster is not allowed.
>>
>>             Basically, the code snippet is in "Setting the Topology
>>             From Code" section, so we can make it correct by just
>>             removing "activation" and "first baseline topology" parts.
>>
>>             Best Regards,
>>             Ivan Rakov
>>
>>
>>
>>             On 03.07.2018 22:30, Denis Magda wrote:
>>
>>                 Prachi,
>>
>>                 I do remember that that code, Ivan is referring to,
>>                 worked fine for you.
>>                 Please double check. Probably you need to add
>>                 "ignite.cluster.activate()"
>>                 to the code snippet.
>>
>>                 --
>>                 Denis
>>
>>                 On Tue, Jul 3, 2018 at 12:19 PM Ivan Rakov
>>                 <[hidden email]
>>                 <mailto:[hidden email]>> wrote:
>>
>>                     Igniters,
>>
>>                     Seems like we have an inconsistency in our
>>                     Baseline Topology
>>                     documentation:
>>
>>                     https://apacheignite.readme.io/docs/baseline-topology#section-setting-the-topology-from-code
>>                     <https://apacheignite.readme.io/docs/baseline-topology#section-setting-the-topology-from-code>
>>
>>                         Java developers can use the IgniteCluster
>>                         interface to initialize the
>>                         very first baseline topology or to adjust an
>>                         existing one. The sample
>>                         below shows how to add all the existing
>>                         server nodes to the baseline
>>                         topology:​
>>                         // Connecting to the cluster.
>>                         Ignite ignite = Ignition.start();
>>
>>                         // Setting the baseline topology to a
>>                         specific Ignite cluster topology
>>                         version.
>>                         ignite.cluster().setBaselineTopology(2);
>>
>>                     This is not true; baseline topology can't be
>>                     changed on inactive
>>                     cluster. The only viable way to initialize the
>>                     very first baseline
>>                     topology is manual cluster activation. This is
>>                     correctly explained in
>>                     this section:
>>
>>                     https://apacheignite.readme.io/docs/baseline-topology#section-first-cluster-startup
>>                     <https://apacheignite.readme.io/docs/baseline-topology#section-first-cluster-startup>
>>
>>                     --
>>                     Best Regards,
>>                     Ivan Rakov
>>
>>
>>
>>
>
>
>