Do we need "IgniteCache.randomEntry()" method?

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Do we need "IgniteCache.randomEntry()" method?

Vladimir Ozerov
Igniters,

We have the ticket about broken randomEntry() method:
https://issues.apache.org/jira/browse/IGNITE-512

This method can return null even if cache is not empty. And it is even
impossible to return an entry in constant time provided that concurrent
deletes and expirations could occur.

Do we really need this method? As for me it is better to deprecate it and
do not spend any efforts trying to make it work.

Thoughts?
Reply | Threaded
Open this post in threaded view
|

Re: Do we need "IgniteCache.randomEntry()" method?

Roman Shtykh
And another ticket for randomEntry() https://issues.apache.org/jira/browse/IGNITE-1180 


     On Thursday, October 15, 2015 9:47 PM, Vladimir Ozerov <[hidden email]> wrote:
   

 Igniters,

We have the ticket about broken randomEntry() method:
https://issues.apache.org/jira/browse/IGNITE-512

This method can return null even if cache is not empty. And it is even
impossible to return an entry in constant time provided that concurrent
deletes and expirations could occur.

Do we really need this method? As for me it is better to deprecate it and
do not spend any efforts trying to make it work.

Thoughts?


Reply | Threaded
Open this post in threaded view
|

Re: Do we need "IgniteCache.randomEntry()" method?

Sergi
Agree, it is doubtfully useful.

Sergi

2015-10-15 17:26 GMT+03:00 Roman <[hidden email]>:

> And another ticket for randomEntry()
> https://issues.apache.org/jira/browse/IGNITE-1180
>
>
>      On Thursday, October 15, 2015 9:47 PM, Vladimir Ozerov <
> [hidden email]> wrote:
>
>
>  Igniters,
>
> We have the ticket about broken randomEntry() method:
> https://issues.apache.org/jira/browse/IGNITE-512
>
> This method can return null even if cache is not empty. And it is even
> impossible to return an entry in constant time provided that concurrent
> deletes and expirations could occur.
>
> Do we really need this method? As for me it is better to deprecate it and
> do not spend any efforts trying to make it work.
>
> Thoughts?
>
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Do we need "IgniteCache.randomEntry()" method?

dsetrakyan
I agree that method randomEntry() can be deprecated. However, in that case
we should also deprecate RandomEvictionPolicy, which probably is used in
some tests.

Does anyone see any potential issues here?

D.

On Thu, Oct 15, 2015 at 7:37 AM, Sergi Vladykin <[hidden email]>
wrote:

> Agree, it is doubtfully useful.
>
> Sergi
>
> 2015-10-15 17:26 GMT+03:00 Roman <[hidden email]>:
>
> > And another ticket for randomEntry()
> > https://issues.apache.org/jira/browse/IGNITE-1180
> >
> >
> >      On Thursday, October 15, 2015 9:47 PM, Vladimir Ozerov <
> > [hidden email]> wrote:
> >
> >
> >  Igniters,
> >
> > We have the ticket about broken randomEntry() method:
> > https://issues.apache.org/jira/browse/IGNITE-512
> >
> > This method can return null even if cache is not empty. And it is even
> > impossible to return an entry in constant time provided that concurrent
> > deletes and expirations could occur.
> >
> > Do we really need this method? As for me it is better to deprecate it and
> > do not spend any efforts trying to make it work.
> >
> > Thoughts?
> >
> >
> >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Do we need "IgniteCache.randomEntry()" method?

William Kemper
I never filed a ticket, but for what it's worth, I tried using this method
in a test scenario just last week from a _client_ node and it never
returned (i.e., blocked forever).

On Thu, Oct 15, 2015 at 8:41 AM, Dmitriy Setrakyan <[hidden email]>
wrote:

> I agree that method randomEntry() can be deprecated. However, in that case
> we should also deprecate RandomEvictionPolicy, which probably is used in
> some tests.
>
> Does anyone see any potential issues here?
>
> D.
>
> On Thu, Oct 15, 2015 at 7:37 AM, Sergi Vladykin <[hidden email]>
> wrote:
>
> > Agree, it is doubtfully useful.
> >
> > Sergi
> >
> > 2015-10-15 17:26 GMT+03:00 Roman <[hidden email]>:
> >
> > > And another ticket for randomEntry()
> > > https://issues.apache.org/jira/browse/IGNITE-1180
> > >
> > >
> > >      On Thursday, October 15, 2015 9:47 PM, Vladimir Ozerov <
> > > [hidden email]> wrote:
> > >
> > >
> > >  Igniters,
> > >
> > > We have the ticket about broken randomEntry() method:
> > > https://issues.apache.org/jira/browse/IGNITE-512
> > >
> > > This method can return null even if cache is not empty. And it is even
> > > impossible to return an entry in constant time provided that concurrent
> > > deletes and expirations could occur.
> > >
> > > Do we really need this method? As for me it is better to deprecate it
> and
> > > do not spend any efforts trying to make it work.
> > >
> > > Thoughts?
> > >
> > >
> > >
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Do we need "IgniteCache.randomEntry()" method?

yzhdanov
This behavior should definitely be fixed - exception should be thrown on
client node. I will update ticket. William, thanks for pointing this out.

--Yakov

2015-10-15 20:33 GMT+03:00 William Kemper <[hidden email]>:

> I never filed a ticket, but for what it's worth, I tried using this method
> in a test scenario just last week from a _client_ node and it never
> returned (i.e., blocked forever).
>
> On Thu, Oct 15, 2015 at 8:41 AM, Dmitriy Setrakyan <[hidden email]>
> wrote:
>
> > I agree that method randomEntry() can be deprecated. However, in that
> case
> > we should also deprecate RandomEvictionPolicy, which probably is used in
> > some tests.
> >
> > Does anyone see any potential issues here?
> >
> > D.
> >
> > On Thu, Oct 15, 2015 at 7:37 AM, Sergi Vladykin <
> [hidden email]>
> > wrote:
> >
> > > Agree, it is doubtfully useful.
> > >
> > > Sergi
> > >
> > > 2015-10-15 17:26 GMT+03:00 Roman <[hidden email]>:
> > >
> > > > And another ticket for randomEntry()
> > > > https://issues.apache.org/jira/browse/IGNITE-1180
> > > >
> > > >
> > > >      On Thursday, October 15, 2015 9:47 PM, Vladimir Ozerov <
> > > > [hidden email]> wrote:
> > > >
> > > >
> > > >  Igniters,
> > > >
> > > > We have the ticket about broken randomEntry() method:
> > > > https://issues.apache.org/jira/browse/IGNITE-512
> > > >
> > > > This method can return null even if cache is not empty. And it is
> even
> > > > impossible to return an entry in constant time provided that
> concurrent
> > > > deletes and expirations could occur.
> > > >
> > > > Do we really need this method? As for me it is better to deprecate it
> > and
> > > > do not spend any efforts trying to make it work.
> > > >
> > > > Thoughts?
> > > >
> > > >
> > > >
> > > >
> > >
> >
>