[DISCUSS] Relevance of CacheConfiguration.DefaultLockTimeout

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[DISCUSS] Relevance of CacheConfiguration.DefaultLockTimeout

Ivan Pavlukhin
Hi,

I failed to find where CacheConfiguration.DefaultLockTimeout property
is used. Does anyone know how is it used? If it is not used I suppose
we can mark this property deprecated.

Please share your thoughts!

--
Best regards,
Ivan Pavlukhin
Reply | Threaded
Open this post in threaded view
|

Re: [DISCUSS] Relevance of CacheConfiguration.DefaultLockTimeout

Ivan Pavlukhin
Anybody?

Best regards,
Ivan Pavlukhin

вт, 28 янв. 2020 г. в 18:29, Ivan Pavlukhin <[hidden email]>:

>
> Hi,
>
> I failed to find where CacheConfiguration.DefaultLockTimeout property
> is used. Does anyone know how is it used? If it is not used I suppose
> we can mark this property deprecated.
>
> Please share your thoughts!
>
> --
> Best regards,
> Ivan Pavlukhin
Reply | Threaded
Open this post in threaded view
|

Re: [DISCUSS] Relevance of CacheConfiguration.DefaultLockTimeout

Alexey Goncharuk
Ivan,

Nothing from my side as well - looks like the property is not used.
Reply | Threaded
Open this post in threaded view
|

Re: [DISCUSS] Relevance of CacheConfiguration.DefaultLockTimeout

agura
I couldn't find any usages too.

But value if this property is serialized in some places and we can't
remove this due to a backward compatibility.

I think we can safely remove it on 3.0. But for now it is better to
mark it as deprecated.

On Thu, Feb 13, 2020 at 5:42 PM Alexey Goncharuk
<[hidden email]> wrote:
>
> Ivan,
>
> Nothing from my side as well - looks like the property is not used.
Reply | Threaded
Open this post in threaded view
|

Re: [DISCUSS] Relevance of CacheConfiguration.DefaultLockTimeout

Ivan Pavlukhin
Andrey,

Good that we care about compatibility!

A note for a careful reader: nobody told about removal in this thread ;-)

Created a ticket for this and a neighbor thread [1].

[1] https://issues.apache.org/jira/browse/IGNITE-12686

Best regards,
Ivan Pavlukhin

пт, 14 февр. 2020 г. в 17:40, Andrey Gura <[hidden email]>:

>
> I couldn't find any usages too.
>
> But value if this property is serialized in some places and we can't
> remove this due to a backward compatibility.
>
> I think we can safely remove it on 3.0. But for now it is better to
> mark it as deprecated.
>
> On Thu, Feb 13, 2020 at 5:42 PM Alexey Goncharuk
> <[hidden email]> wrote:
> >
> > Ivan,
> >
> > Nothing from my side as well - looks like the property is not used.
Reply | Threaded
Open this post in threaded view
|

Re: [DISCUSS] Relevance of CacheConfiguration.DefaultLockTimeout

Ivan Pavlukhin
Ticket [1] is ready for review. Comments about deprecation statements
and overall approach are highly appreciated.

[1] https://issues.apache.org/jira/browse/IGNITE-12686

Best regards,
Ivan Pavlukhin

вс, 16 февр. 2020 г. в 15:02, Ivan Pavlukhin <[hidden email]>:

>
> Andrey,
>
> Good that we care about compatibility!
>
> A note for a careful reader: nobody told about removal in this thread ;-)
>
> Created a ticket for this and a neighbor thread [1].
>
> [1] https://issues.apache.org/jira/browse/IGNITE-12686
>
> Best regards,
> Ivan Pavlukhin
>
> пт, 14 февр. 2020 г. в 17:40, Andrey Gura <[hidden email]>:
> >
> > I couldn't find any usages too.
> >
> > But value if this property is serialized in some places and we can't
> > remove this due to a backward compatibility.
> >
> > I think we can safely remove it on 3.0. But for now it is better to
> > mark it as deprecated.
> >
> > On Thu, Feb 13, 2020 at 5:42 PM Alexey Goncharuk
> > <[hidden email]> wrote:
> > >
> > > Ivan,
> > >
> > > Nothing from my side as well - looks like the property is not used.
Reply | Threaded
Open this post in threaded view
|

Re: [DISCUSS] Relevance of CacheConfiguration.DefaultLockTimeout

Ivan Pavlukhin
Merged to master.

Best regards,
Ivan Pavlukhin

пн, 17 февр. 2020 г. в 20:08, Ivan Pavlukhin <[hidden email]>:

>
> Ticket [1] is ready for review. Comments about deprecation statements
> and overall approach are highly appreciated.
>
> [1] https://issues.apache.org/jira/browse/IGNITE-12686
>
> Best regards,
> Ivan Pavlukhin
>
> вс, 16 февр. 2020 г. в 15:02, Ivan Pavlukhin <[hidden email]>:
> >
> > Andrey,
> >
> > Good that we care about compatibility!
> >
> > A note for a careful reader: nobody told about removal in this thread ;-)
> >
> > Created a ticket for this and a neighbor thread [1].
> >
> > [1] https://issues.apache.org/jira/browse/IGNITE-12686
> >
> > Best regards,
> > Ivan Pavlukhin
> >
> > пт, 14 февр. 2020 г. в 17:40, Andrey Gura <[hidden email]>:
> > >
> > > I couldn't find any usages too.
> > >
> > > But value if this property is serialized in some places and we can't
> > > remove this due to a backward compatibility.
> > >
> > > I think we can safely remove it on 3.0. But for now it is better to
> > > mark it as deprecated.
> > >
> > > On Thu, Feb 13, 2020 at 5:42 PM Alexey Goncharuk
> > > <[hidden email]> wrote:
> > > >
> > > > Ivan,
> > > >
> > > > Nothing from my side as well - looks like the property is not used.