Contribution

[Лев Киселев]

Hello everyone, I have question about following task:
[https://issues.apache.org/jira/browse/IGNITE-10698]
Solution proposed in task description is seem to be logical.
So, I need to every replace @MXBeanParametersNames and
@MXBeanParametersDescriptions (everywhere, for uniformity) with something
like:
void methodName(@MXBeanParameterInformation(name = "name", description =
"description") firstParameter, ...) {}.
And, of course, need to change processing logic at
getParameterName/getDescription methods from IgniteStandardMXBean.
Do I understand correctly what needs to be done?

[dmagda]

Nikolay, Andrey,

Would you be the best committers to help out here? You are already deeply
involved in metrics development and can quickly suggest Lev how to proceed
with this task.

-
Denis


On Thu, Jan 30, 2020 at 2:46 AM Лев Киселев <[hidden email]>
wrote:

> Hello everyone, I have question about following task:
> [https://issues.apache.org/jira/browse/IGNITE-10698]
> Solution proposed in task description is seem to be logical.
> So, I need to every replace @MXBeanParametersNames and
> @MXBeanParametersDescriptions (everywhere, for uniformity) with something
> like:
> void methodName(@MXBeanParameterInformation(name = "name", description =
> "description") firstParameter, ...) {}.
> And, of course, need to change processing logic at
> getParameterName/getDescription methods from IgniteStandardMXBean.
> Do I understand correctly what needs to be done?
>

[agura]

Hi, Lev!

I think you understand task correctly.

A couple of comments:

- Existing annotations and related functionality must not be deleted
because it is part of public API and we committed to have stable API
between major releases.
- I would suggest introduce @MXBeanParameter annotation instead of
@MXBeanParameterInformation. Just shorten name.

On Thu, Jan 30, 2020 at 8:53 PM Denis Magda <[hidden email]> wrote:

>
> Nikolay, Andrey,
>
> Would you be the best committers to help out here? You are already deeply involved in metrics development and can quickly suggest Lev how to proceed with this task.
>
> -
> Denis
>
>
> On Thu, Jan 30, 2020 at 2:46 AM Лев Киселев <[hidden email]> wrote:
>>
>> Hello everyone, I have question about following task:
>> [https://issues.apache.org/jira/browse/IGNITE-10698]
>> Solution proposed in task description is seem to be logical.
>> So, I need to every replace @MXBeanParametersNames and
>> @MXBeanParametersDescriptions (everywhere, for uniformity) with something
>> like:
>> void methodName(@MXBeanParameterInformation(name = "name", description =
>> "description") firstParameter, ...) {}.
>> And, of course, need to change processing logic at
>> getParameterName/getDescription methods from IgniteStandardMXBean.
>> Do I understand correctly what needs to be done?

[Лев Киселев]

Thanks for answer, Andrey.
I'm confused about your first comment. Does it mean, that the only thing I
can do is to create new annotation?
Because, as you said, I must leave unchanged all related to old annotations
functionality.
So, I can't change implementation of *getDescription / getParameterName
(MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods from*
IgniteStandardMXBean* class,
and replace current annotations with new one.

вт, 4 февр. 2020 г. в 14:28, Andrey Gura <[hidden email]>:

> Hi, Lev!
>
> I think you understand task correctly.
>
> A couple of comments:
>
> - Existing annotations and related functionality must not be deleted
> because it is part of public API and we committed to have stable API
> between major releases.
> - I would suggest introduce @MXBeanParameter annotation instead of
> @MXBeanParameterInformation. Just shorten name.
>
> On Thu, Jan 30, 2020 at 8:53 PM Denis Magda <[hidden email]> wrote:
> >
> > Nikolay, Andrey,
> >
> > Would you be the best committers to help out here? You are already
> deeply involved in metrics development and can quickly suggest Lev how to
> proceed with this task.
> >
> > -
> > Denis
> >
> >
> > On Thu, Jan 30, 2020 at 2:46 AM Лев Киселев <[hidden email]>
> wrote:
> >>
> >> Hello everyone, I have question about following task:
> >> [https://issues.apache.org/jira/browse/IGNITE-10698]
> >> Solution proposed in task description is seem to be logical.
> >> So, I need to every replace @MXBeanParametersNames and
> >> @MXBeanParametersDescriptions (everywhere, for uniformity) with
> something
> >> like:
> >> void methodName(@MXBeanParameterInformation(name = "name", description =
> >> "description") firstParameter, ...) {}.
> >> And, of course, need to change processing logic at
> >> getParameterName/getDescription methods from IgniteStandardMXBean.
> >> Do I understand correctly what needs to be done?
>

[agura]

Lev,

> I'm confused about your first comment. Does it mean, that the only thing I
can do is to create new annotation?

Yes, it does. But in this case you can mark old annotations as
deprecated because new annotations are real alternative.

> So, I can't change implementation of *getDescription / getParameterName
> (MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods from*
> IgniteStandardMXBean* class,
> and replace current annotations with new one.

You have to support both old and new annotations due to a backward
compatibility.

On Tue, Feb 4, 2020 at 3:14 PM Лев Киселев <[hidden email]> wrote:

>
> Thanks for answer, Andrey.
> I'm confused about your first comment. Does it mean, that the only thing I
> can do is to create new annotation?
> Because, as you said, I must leave unchanged all related to old annotations
> functionality.
> So, I can't change implementation of *getDescription / getParameterName
> (MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods from*
> IgniteStandardMXBean* class,
> and replace current annotations with new one.
>
> вт, 4 февр. 2020 г. в 14:28, Andrey Gura <[hidden email]>:
>
> > Hi, Lev!
> >
> > I think you understand task correctly.
> >
> > A couple of comments:
> >
> > - Existing annotations and related functionality must not be deleted
> > because it is part of public API and we committed to have stable API
> > between major releases.
> > - I would suggest introduce @MXBeanParameter annotation instead of
> > @MXBeanParameterInformation. Just shorten name.
> >
> > On Thu, Jan 30, 2020 at 8:53 PM Denis Magda <[hidden email]> wrote:
> > >
> > > Nikolay, Andrey,
> > >
> > > Would you be the best committers to help out here? You are already
> > deeply involved in metrics development and can quickly suggest Lev how to
> > proceed with this task.
> > >
> > > -
> > > Denis
> > >
> > >
> > > On Thu, Jan 30, 2020 at 2:46 AM Лев Киселев <[hidden email]>
> > wrote:
> > >>
> > >> Hello everyone, I have question about following task:
> > >> [https://issues.apache.org/jira/browse/IGNITE-10698]
> > >> Solution proposed in task description is seem to be logical.
> > >> So, I need to every replace @MXBeanParametersNames and
> > >> @MXBeanParametersDescriptions (everywhere, for uniformity) with
> > something
> > >> like:
> > >> void methodName(@MXBeanParameterInformation(name = "name", description =
> > >> "description") firstParameter, ...) {}.
> > >> And, of course, need to change processing logic at
> > >> getParameterName/getDescription methods from IgniteStandardMXBean.
> > >> Do I understand correctly what needs to be done?
> >

[Ivan Pavlukhin]

Should we mark old annotations deprecated?

вт, 4 февр. 2020 г. в 16:57, Andrey Gura <[hidden email]>:

>
> Lev,
>
> > I'm confused about your first comment. Does it mean, that the only thing I
> can do is to create new annotation?
>
> Yes, it does. But in this case you can mark old annotations as
> deprecated because new annotations are real alternative.
>
> > So, I can't change implementation of *getDescription / getParameterName
> > (MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods from*
> > IgniteStandardMXBean* class,
> > and replace current annotations with new one.
>
> You have to support both old and new annotations due to a backward
> compatibility.
>
> On Tue, Feb 4, 2020 at 3:14 PM Лев Киселев <[hidden email]> wrote:
> >
> > Thanks for answer, Andrey.
> > I'm confused about your first comment. Does it mean, that the only thing I
> > can do is to create new annotation?
> > Because, as you said, I must leave unchanged all related to old annotations
> > functionality.
> > So, I can't change implementation of *getDescription / getParameterName
> > (MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods from*
> > IgniteStandardMXBean* class,
> > and replace current annotations with new one.
> >
> > вт, 4 февр. 2020 г. в 14:28, Andrey Gura <[hidden email]>:
> >
> > > Hi, Lev!
> > >
> > > I think you understand task correctly.
> > >
> > > A couple of comments:
> > >
> > > - Existing annotations and related functionality must not be deleted
> > > because it is part of public API and we committed to have stable API
> > > between major releases.
> > > - I would suggest introduce @MXBeanParameter annotation instead of
> > > @MXBeanParameterInformation. Just shorten name.
> > >
> > > On Thu, Jan 30, 2020 at 8:53 PM Denis Magda <[hidden email]> wrote:
> > > >
> > > > Nikolay, Andrey,
> > > >
> > > > Would you be the best committers to help out here? You are already
> > > deeply involved in metrics development and can quickly suggest Lev how to
> > > proceed with this task.
> > > >
> > > > -
> > > > Denis
> > > >
> > > >
> > > > On Thu, Jan 30, 2020 at 2:46 AM Лев Киселев <[hidden email]>
> > > wrote:
> > > >>
> > > >> Hello everyone, I have question about following task:
> > > >> [https://issues.apache.org/jira/browse/IGNITE-10698]
> > > >> Solution proposed in task description is seem to be logical.
> > > >> So, I need to every replace @MXBeanParametersNames and
> > > >> @MXBeanParametersDescriptions (everywhere, for uniformity) with
> > > something
> > > >> like:
> > > >> void methodName(@MXBeanParameterInformation(name = "name", description =
> > > >> "description") firstParameter, ...) {}.
> > > >> And, of course, need to change processing logic at
> > > >> getParameterName/getDescription methods from IgniteStandardMXBean.
> > > >> Do I understand correctly what needs to be done?
> > >

--
Best regards,
Ivan Pavlukhin

[agura]

MXBeanParametersNames and MXBeanParametersDescriptions could be marked
as deprecated if MXBeanParameter will be added.

On Tue, Feb 4, 2020 at 5:12 PM Ivan Pavlukhin <[hidden email]> wrote:

>
> Should we mark old annotations deprecated?
>
> вт, 4 февр. 2020 г. в 16:57, Andrey Gura <[hidden email]>:
> >
> > Lev,
> >
> > > I'm confused about your first comment. Does it mean, that the only thing I
> > can do is to create new annotation?
> >
> > Yes, it does. But in this case you can mark old annotations as
> > deprecated because new annotations are real alternative.
> >
> > > So, I can't change implementation of *getDescription / getParameterName
> > > (MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods from*
> > > IgniteStandardMXBean* class,
> > > and replace current annotations with new one.
> >
> > You have to support both old and new annotations due to a backward
> > compatibility.
> >
> > On Tue, Feb 4, 2020 at 3:14 PM Лев Киселев <[hidden email]> wrote:
> > >
> > > Thanks for answer, Andrey.
> > > I'm confused about your first comment. Does it mean, that the only thing I
> > > can do is to create new annotation?
> > > Because, as you said, I must leave unchanged all related to old annotations
> > > functionality.
> > > So, I can't change implementation of *getDescription / getParameterName
> > > (MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods from*
> > > IgniteStandardMXBean* class,
> > > and replace current annotations with new one.
> > >
> > > вт, 4 февр. 2020 г. в 14:28, Andrey Gura <[hidden email]>:
> > >
> > > > Hi, Lev!
> > > >
> > > > I think you understand task correctly.
> > > >
> > > > A couple of comments:
> > > >
> > > > - Existing annotations and related functionality must not be deleted
> > > > because it is part of public API and we committed to have stable API
> > > > between major releases.
> > > > - I would suggest introduce @MXBeanParameter annotation instead of
> > > > @MXBeanParameterInformation. Just shorten name.
> > > >
> > > > On Thu, Jan 30, 2020 at 8:53 PM Denis Magda <[hidden email]> wrote:
> > > > >
> > > > > Nikolay, Andrey,
> > > > >
> > > > > Would you be the best committers to help out here? You are already
> > > > deeply involved in metrics development and can quickly suggest Lev how to
> > > > proceed with this task.
> > > > >
> > > > > -
> > > > > Denis
> > > > >
> > > > >
> > > > > On Thu, Jan 30, 2020 at 2:46 AM Лев Киселев <[hidden email]>
> > > > wrote:
> > > > >>
> > > > >> Hello everyone, I have question about following task:
> > > > >> [https://issues.apache.org/jira/browse/IGNITE-10698]
> > > > >> Solution proposed in task description is seem to be logical.
> > > > >> So, I need to every replace @MXBeanParametersNames and
> > > > >> @MXBeanParametersDescriptions (everywhere, for uniformity) with
> > > > something
> > > > >> like:
> > > > >> void methodName(@MXBeanParameterInformation(name = "name", description =
> > > > >> "description") firstParameter, ...) {}.
> > > > >> And, of course, need to change processing logic at
> > > > >> getParameterName/getDescription methods from IgniteStandardMXBean.
> > > > >> Do I understand correctly what needs to be done?
> > > >
>
>
>
> --
> Best regards,
> Ivan Pavlukhin

[Лев Киселев]

Andrey, then I suggest firstly check if old annotations are present, and if
not - are there any new annotations. Do you agree?
And should I also replace usage of old annotations or leave it as it is?

вт, 4 февр. 2020 г. в 16:57, Andrey Gura <[hidden email]>:

> Lev,
>
> > I'm confused about your first comment. Does it mean, that the only thing
> I
> can do is to create new annotation?
>
> Yes, it does. But in this case you can mark old annotations as
> deprecated because new annotations are real alternative.
>
> > So, I can't change implementation of *getDescription / getParameterName
> > (MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods from*
> > IgniteStandardMXBean* class,
> > and replace current annotations with new one.
>
> You have to support both old and new annotations due to a backward
> compatibility.
>
> On Tue, Feb 4, 2020 at 3:14 PM Лев Киселев <[hidden email]>
> wrote:
> >
> > Thanks for answer, Andrey.
> > I'm confused about your first comment. Does it mean, that the only thing
> I
> > can do is to create new annotation?
> > Because, as you said, I must leave unchanged all related to old
> annotations
> > functionality.
> > So, I can't change implementation of *getDescription / getParameterName
> > (MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods from*
> > IgniteStandardMXBean* class,
> > and replace current annotations with new one.
> >
> > вт, 4 февр. 2020 г. в 14:28, Andrey Gura <[hidden email]>:
> >
> > > Hi, Lev!
> > >
> > > I think you understand task correctly.
> > >
> > > A couple of comments:
> > >
> > > - Existing annotations and related functionality must not be deleted
> > > because it is part of public API and we committed to have stable API
> > > between major releases.
> > > - I would suggest introduce @MXBeanParameter annotation instead of
> > > @MXBeanParameterInformation. Just shorten name.
> > >
> > > On Thu, Jan 30, 2020 at 8:53 PM Denis Magda <[hidden email]> wrote:
> > > >
> > > > Nikolay, Andrey,
> > > >
> > > > Would you be the best committers to help out here? You are already
> > > deeply involved in metrics development and can quickly suggest Lev how
> to
> > > proceed with this task.
> > > >
> > > > -
> > > > Denis
> > > >
> > > >
> > > > On Thu, Jan 30, 2020 at 2:46 AM Лев Киселев <
> [hidden email]>
> > > wrote:
> > > >>
> > > >> Hello everyone, I have question about following task:
> > > >> [https://issues.apache.org/jira/browse/IGNITE-10698]
> > > >> Solution proposed in task description is seem to be logical.
> > > >> So, I need to every replace @MXBeanParametersNames and
> > > >> @MXBeanParametersDescriptions (everywhere, for uniformity) with
> > > something
> > > >> like:
> > > >> void methodName(@MXBeanParameterInformation(name = "name",
> description =
> > > >> "description") firstParameter, ...) {}.
> > > >> And, of course, need to change processing logic at
> > > >> getParameterName/getDescription methods from IgniteStandardMXBean.
> > > >> Do I understand correctly what needs to be done?
> > >
>

[agura]

> Andrey, then I suggest firstly check if old annotations are present, and if
> not - are there any new annotations. Do you agree?

I'm afraid I don't understand. Old annotations are present and new
annotations don't exist yet :)

> And should I also replace usage of old annotations or leave it as it is?

It would be great to replace old annotations by new ones.

On Tue, Feb 4, 2020 at 6:09 PM Лев Киселев <[hidden email]> wrote:

>
> Andrey, then I suggest firstly check if old annotations are present, and if
> not - are there any new annotations. Do you agree?
> And should I also replace usage of old annotations or leave it as it is?
>
> вт, 4 февр. 2020 г. в 16:57, Andrey Gura <[hidden email]>:
>
> > Lev,
> >
> > > I'm confused about your first comment. Does it mean, that the only thing
> > I
> > can do is to create new annotation?
> >
> > Yes, it does. But in this case you can mark old annotations as
> > deprecated because new annotations are real alternative.
> >
> > > So, I can't change implementation of *getDescription / getParameterName
> > > (MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods from*
> > > IgniteStandardMXBean* class,
> > > and replace current annotations with new one.
> >
> > You have to support both old and new annotations due to a backward
> > compatibility.
> >
> > On Tue, Feb 4, 2020 at 3:14 PM Лев Киселев <[hidden email]>
> > wrote:
> > >
> > > Thanks for answer, Andrey.
> > > I'm confused about your first comment. Does it mean, that the only thing
> > I
> > > can do is to create new annotation?
> > > Because, as you said, I must leave unchanged all related to old
> > annotations
> > > functionality.
> > > So, I can't change implementation of *getDescription / getParameterName
> > > (MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods from*
> > > IgniteStandardMXBean* class,
> > > and replace current annotations with new one.
> > >
> > > вт, 4 февр. 2020 г. в 14:28, Andrey Gura <[hidden email]>:
> > >
> > > > Hi, Lev!
> > > >
> > > > I think you understand task correctly.
> > > >
> > > > A couple of comments:
> > > >
> > > > - Existing annotations and related functionality must not be deleted
> > > > because it is part of public API and we committed to have stable API
> > > > between major releases.
> > > > - I would suggest introduce @MXBeanParameter annotation instead of
> > > > @MXBeanParameterInformation. Just shorten name.
> > > >
> > > > On Thu, Jan 30, 2020 at 8:53 PM Denis Magda <[hidden email]> wrote:
> > > > >
> > > > > Nikolay, Andrey,
> > > > >
> > > > > Would you be the best committers to help out here? You are already
> > > > deeply involved in metrics development and can quickly suggest Lev how
> > to
> > > > proceed with this task.
> > > > >
> > > > > -
> > > > > Denis
> > > > >
> > > > >
> > > > > On Thu, Jan 30, 2020 at 2:46 AM Лев Киселев <
> > [hidden email]>
> > > > wrote:
> > > > >>
> > > > >> Hello everyone, I have question about following task:
> > > > >> [https://issues.apache.org/jira/browse/IGNITE-10698]
> > > > >> Solution proposed in task description is seem to be logical.
> > > > >> So, I need to every replace @MXBeanParametersNames and
> > > > >> @MXBeanParametersDescriptions (everywhere, for uniformity) with
> > > > something
> > > > >> like:
> > > > >> void methodName(@MXBeanParameterInformation(name = "name",
> > description =
> > > > >> "description") firstParameter, ...) {}.
> > > > >> And, of course, need to change processing logic at
> > > > >> getParameterName/getDescription methods from IgniteStandardMXBean.
> > > > >> Do I understand correctly what needs to be done?
> > > >
> >

[Лев Киселев]

Andrey,
> > Andrey, then I suggest firstly check if old annotations are present,
and if
> > not - are there any new annotations. Do you agree?

> I'm afraid I don't understand. Old annotations are present and new
> annotations don't exist yet :)


I talked about implementation of methods *getDescription* /
*getParameterName* in *IgniteStandardMXBean *class. To support backward
compatibility I need to check if there are old annotations above method, or
new one before parameters. So, my question was the order of searching
annotations (first - old, after - new).

вт, 4 февр. 2020 г. в 21:10, Andrey Gura <[hidden email]>:

> > Andrey, then I suggest firstly check if old annotations are present, and
> if
> > not - are there any new annotations. Do you agree?
>
> I'm afraid I don't understand. Old annotations are present and new
> annotations don't exist yet :)
>
> > And should I also replace usage of old annotations or leave it as it is?
>
> It would be great to replace old annotations by new ones.
>
> On Tue, Feb 4, 2020 at 6:09 PM Лев Киселев <[hidden email]>
> wrote:
> >
> > Andrey, then I suggest firstly check if old annotations are present, and
> if
> > not - are there any new annotations. Do you agree?
> > And should I also replace usage of old annotations or leave it as it is?
> >
> > вт, 4 февр. 2020 г. в 16:57, Andrey Gura <[hidden email]>:
> >
> > > Lev,
> > >
> > > > I'm confused about your first comment. Does it mean, that the only
> thing
> > > I
> > > can do is to create new annotation?
> > >
> > > Yes, it does. But in this case you can mark old annotations as
> > > deprecated because new annotations are real alternative.
> > >
> > > > So, I can't change implementation of *getDescription /
> getParameterName
> > > > (MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods
> from*
> > > > IgniteStandardMXBean* class,
> > > > and replace current annotations with new one.
> > >
> > > You have to support both old and new annotations due to a backward
> > > compatibility.
> > >
> > > On Tue, Feb 4, 2020 at 3:14 PM Лев Киселев <[hidden email]
> >
> > > wrote:
> > > >
> > > > Thanks for answer, Andrey.
> > > > I'm confused about your first comment. Does it mean, that the only
> thing
> > > I
> > > > can do is to create new annotation?
> > > > Because, as you said, I must leave unchanged all related to old
> > > annotations
> > > > functionality.
> > > > So, I can't change implementation of *getDescription /
> getParameterName
> > > > (MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods
> from*
> > > > IgniteStandardMXBean* class,
> > > > and replace current annotations with new one.
> > > >
> > > > вт, 4 февр. 2020 г. в 14:28, Andrey Gura <[hidden email]>:
> > > >
> > > > > Hi, Lev!
> > > > >
> > > > > I think you understand task correctly.
> > > > >
> > > > > A couple of comments:
> > > > >
> > > > > - Existing annotations and related functionality must not be
> deleted
> > > > > because it is part of public API and we committed to have stable
> API
> > > > > between major releases.
> > > > > - I would suggest introduce @MXBeanParameter annotation instead of
> > > > > @MXBeanParameterInformation. Just shorten name.
> > > > >
> > > > > On Thu, Jan 30, 2020 at 8:53 PM Denis Magda <[hidden email]>
> wrote:
> > > > > >
> > > > > > Nikolay, Andrey,
> > > > > >
> > > > > > Would you be the best committers to help out here? You are
> already
> > > > > deeply involved in metrics development and can quickly suggest Lev
> how
> > > to
> > > > > proceed with this task.
> > > > > >
> > > > > > -
> > > > > > Denis
> > > > > >
> > > > > >
> > > > > > On Thu, Jan 30, 2020 at 2:46 AM Лев Киселев <
> > > [hidden email]>
> > > > > wrote:
> > > > > >>
> > > > > >> Hello everyone, I have question about following task:
> > > > > >> [https://issues.apache.org/jira/browse/IGNITE-10698]
> > > > > >> Solution proposed in task description is seem to be logical.
> > > > > >> So, I need to every replace @MXBeanParametersNames and
> > > > > >> @MXBeanParametersDescriptions (everywhere, for uniformity) with
> > > > > something
> > > > > >> like:
> > > > > >> void methodName(@MXBeanParameterInformation(name = "name",
> > > description =
> > > > > >> "description") firstParameter, ...) {}.
> > > > > >> And, of course, need to change processing logic at
> > > > > >> getParameterName/getDescription methods from
> IgniteStandardMXBean.
> > > > > >> Do I understand correctly what needs to be done?
> > > > >
> > >
>

[agura]

Different approaches are possible. For me it would be logical if
MXBeanParameter override MXBeanParametersNames and
MXBeanParametersDescriptions.
In such case the order of annotation processing is fixed: old on
method then new on method's parameters if exists.

On Wed, Feb 5, 2020 at 1:11 PM Лев Киселев <[hidden email]> wrote:

>
> Andrey,
> > > Andrey, then I suggest firstly check if old annotations are present,
> and if
> > > not - are there any new annotations. Do you agree?
>
> > I'm afraid I don't understand. Old annotations are present and new
> > annotations don't exist yet :)
>
>
> I talked about implementation of methods *getDescription* /
> *getParameterName* in *IgniteStandardMXBean *class. To support backward
> compatibility I need to check if there are old annotations above method, or
> new one before parameters. So, my question was the order of searching
> annotations (first - old, after - new).
>
> вт, 4 февр. 2020 г. в 21:10, Andrey Gura <[hidden email]>:
>
> > > Andrey, then I suggest firstly check if old annotations are present, and
> > if
> > > not - are there any new annotations. Do you agree?
> >
> > I'm afraid I don't understand. Old annotations are present and new
> > annotations don't exist yet :)
> >
> > > And should I also replace usage of old annotations or leave it as it is?
> >
> > It would be great to replace old annotations by new ones.
> >
> > On Tue, Feb 4, 2020 at 6:09 PM Лев Киселев <[hidden email]>
> > wrote:
> > >
> > > Andrey, then I suggest firstly check if old annotations are present, and
> > if
> > > not - are there any new annotations. Do you agree?
> > > And should I also replace usage of old annotations or leave it as it is?
> > >
> > > вт, 4 февр. 2020 г. в 16:57, Andrey Gura <[hidden email]>:
> > >
> > > > Lev,
> > > >
> > > > > I'm confused about your first comment. Does it mean, that the only
> > thing
> > > > I
> > > > can do is to create new annotation?
> > > >
> > > > Yes, it does. But in this case you can mark old annotations as
> > > > deprecated because new annotations are real alternative.
> > > >
> > > > > So, I can't change implementation of *getDescription /
> > getParameterName
> > > > > (MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods
> > from*
> > > > > IgniteStandardMXBean* class,
> > > > > and replace current annotations with new one.
> > > >
> > > > You have to support both old and new annotations due to a backward
> > > > compatibility.
> > > >
> > > > On Tue, Feb 4, 2020 at 3:14 PM Лев Киселев <[hidden email]
> > >
> > > > wrote:
> > > > >
> > > > > Thanks for answer, Andrey.
> > > > > I'm confused about your first comment. Does it mean, that the only
> > thing
> > > > I
> > > > > can do is to create new annotation?
> > > > > Because, as you said, I must leave unchanged all related to old
> > > > annotations
> > > > > functionality.
> > > > > So, I can't change implementation of *getDescription /
> > getParameterName
> > > > > (MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods
> > from*
> > > > > IgniteStandardMXBean* class,
> > > > > and replace current annotations with new one.
> > > > >
> > > > > вт, 4 февр. 2020 г. в 14:28, Andrey Gura <[hidden email]>:
> > > > >
> > > > > > Hi, Lev!
> > > > > >
> > > > > > I think you understand task correctly.
> > > > > >
> > > > > > A couple of comments:
> > > > > >
> > > > > > - Existing annotations and related functionality must not be
> > deleted
> > > > > > because it is part of public API and we committed to have stable
> > API
> > > > > > between major releases.
> > > > > > - I would suggest introduce @MXBeanParameter annotation instead of
> > > > > > @MXBeanParameterInformation. Just shorten name.
> > > > > >
> > > > > > On Thu, Jan 30, 2020 at 8:53 PM Denis Magda <[hidden email]>
> > wrote:
> > > > > > >
> > > > > > > Nikolay, Andrey,
> > > > > > >
> > > > > > > Would you be the best committers to help out here? You are
> > already
> > > > > > deeply involved in metrics development and can quickly suggest Lev
> > how
> > > > to
> > > > > > proceed with this task.
> > > > > > >
> > > > > > > -
> > > > > > > Denis
> > > > > > >
> > > > > > >
> > > > > > > On Thu, Jan 30, 2020 at 2:46 AM Лев Киселев <
> > > > [hidden email]>
> > > > > > wrote:
> > > > > > >>
> > > > > > >> Hello everyone, I have question about following task:
> > > > > > >> [https://issues.apache.org/jira/browse/IGNITE-10698]
> > > > > > >> Solution proposed in task description is seem to be logical.
> > > > > > >> So, I need to every replace @MXBeanParametersNames and
> > > > > > >> @MXBeanParametersDescriptions (everywhere, for uniformity) with
> > > > > > something
> > > > > > >> like:
> > > > > > >> void methodName(@MXBeanParameterInformation(name = "name",
> > > > description =
> > > > > > >> "description") firstParameter, ...) {}.
> > > > > > >> And, of course, need to change processing logic at
> > > > > > >> getParameterName/getDescription methods from
> > IgniteStandardMXBean.
> > > > > > >> Do I understand correctly what needs to be done?
> > > > > >
> > > >
> >