Confusing IGNITE_ATOMIC_CACHE_DELETE_HISTORY_SIZE property

[Denis Magda]

Igniters,

As you know there is a property that controls maximum remove queue
history for atomic caches
(IgniteSystemProperties.IGNITE_ATOMIC_CACHE_DELETE_HISTORY_SIZE).

The strange thing is that this property is also used for transactional
caches as well. I see that GridDhtLocalPartition allocates rmvQueue
regardless of a cache atomicity type which looks confusing.

Do we need to avoid the allocation of the queue for transactional caches?

--
Denis

[dsetrakyan]

Is there any way to get rid of this property completely?

On Wed, Mar 9, 2016 at 4:10 AM, Denis Magda <[hidden email]> wrote:

> Igniters,
>
> As you know there is a property that controls maximum remove queue history
> for atomic caches
> (IgniteSystemProperties.IGNITE_ATOMIC_CACHE_DELETE_HISTORY_SIZE).
>
> The strange thing is that this property is also used for transactional
> caches as well. I see that GridDhtLocalPartition allocates rmvQueue
> regardless of a cache atomicity type which looks confusing.
>
> Do we need to avoid the allocation of the queue for transactional caches?
>
> --
> Denis
>

[yzhdanov]

To get rid of this completely we need to switch to fair
thread-per-partition.

Denis, it this queue is used in TX caches to resolve rebalancing and
concurrent puts races. We can try removin it once partition gets loaded,
btw. Can you please file a ticket?

--Yakov

2016-03-09 23:12 GMT+03:00 Dmitriy Setrakyan <[hidden email]>:

> Is there any way to get rid of this property completely?
>
> On Wed, Mar 9, 2016 at 4:10 AM, Denis Magda <[hidden email]> wrote:
>
> > Igniters,
> >
> > As you know there is a property that controls maximum remove queue
> history
> > for atomic caches
> > (IgniteSystemProperties.IGNITE_ATOMIC_CACHE_DELETE_HISTORY_SIZE).
> >
> > The strange thing is that this property is also used for transactional
> > caches as well. I see that GridDhtLocalPartition allocates rmvQueue
> > regardless of a cache atomicity type which looks confusing.
> >
> > Do we need to avoid the allocation of the queue for transactional caches?
> >
> > --
> > Denis
> >
>

[Denis Magda]

Done
https://issues.apache.org/jira/browse/IGNITE-2885

On 3/24/2016 11:46 AM, Yakov Zhdanov wrote:

> To get rid of this completely we need to switch to fair
> thread-per-partition.
>
> Denis, it this queue is used in TX caches to resolve rebalancing and
> concurrent puts races. We can try removin it once partition gets loaded,
> btw. Can you please file a ticket?
>
> --Yakov
>
> 2016-03-09 23:12 GMT+03:00 Dmitriy Setrakyan <[hidden email]>:
>
>> Is there any way to get rid of this property completely?
>>
>> On Wed, Mar 9, 2016 at 4:10 AM, Denis Magda <[hidden email]> wrote:
>>
>>> Igniters,
>>>
>>> As you know there is a property that controls maximum remove queue
>> history
>>> for atomic caches
>>> (IgniteSystemProperties.IGNITE_ATOMIC_CACHE_DELETE_HISTORY_SIZE).
>>>
>>> The strange thing is that this property is also used for transactional
>>> caches as well. I see that GridDhtLocalPartition allocates rmvQueue
>>> regardless of a cache atomicity type which looks confusing.
>>>
>>> Do we need to avoid the allocation of the queue for transactional caches?
>>>
>>> --
>>> Denis
>>>