Cluster metrics - review for PageMemory

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Cluster metrics - review for PageMemory

Alexey Goncharuk
Igniters,

Since we moved to the PageMemory architecture, several ClusterMetrics
methods became questionable, so I would like to discuss this before the
release. Currently, ClusterMetrics contains the following methods:
getNonHeapMemoryCommitted(),
getNonHeapMemoryUsed(),
getNonHeapMemoryInitialized(),
getNonHeapMemoryTotal(),
getNonHeapMemoryMaximum()

I suggest we remove Total and Committed metrics, and the rest of the
methods will have the following semantics:
Initialized() - start size of all memory policies
Max - max size of all memory policies
Used - size of all allocated pages

Thoughts?
Reply | Threaded
Open this post in threaded view
|

Re: Cluster metrics - review for PageMemory

dmagda
Personally, Total and Committed metrics look confusing to me. Moreover, looks like they interfere with the rest of the metrics this or that way.

So, +1 for the changes proposed by Alex G.


Denis

> On Apr 25, 2017, at 6:53 AM, Alexey Goncharuk <[hidden email]> wrote:
>
> Igniters,
>
> Since we moved to the PageMemory architecture, several ClusterMetrics
> methods became questionable, so I would like to discuss this before the
> release. Currently, ClusterMetrics contains the following methods:
> getNonHeapMemoryCommitted(),
> getNonHeapMemoryUsed(),
> getNonHeapMemoryInitialized(),
> getNonHeapMemoryTotal(),
> getNonHeapMemoryMaximum()
>
> I suggest we remove Total and Committed metrics, and the rest of the
> methods will have the following semantics:
> Initialized() - start size of all memory policies
> Max - max size of all memory policies
> Used - size of all allocated pages
>
> Thoughts?

Reply | Threaded
Open this post in threaded view
|

Re: Cluster metrics - review for PageMemory

Sergi
In reply to this post by Alexey Goncharuk
Looks good to me.

Sergi

2017-04-25 16:53 GMT+03:00 Alexey Goncharuk <[hidden email]>:

> Igniters,
>
> Since we moved to the PageMemory architecture, several ClusterMetrics
> methods became questionable, so I would like to discuss this before the
> release. Currently, ClusterMetrics contains the following methods:
> getNonHeapMemoryCommitted(),
> getNonHeapMemoryUsed(),
> getNonHeapMemoryInitialized(),
> getNonHeapMemoryTotal(),
> getNonHeapMemoryMaximum()
>
> I suggest we remove Total and Committed metrics, and the rest of the
> methods will have the following semantics:
> Initialized() - start size of all memory policies
> Max - max size of all memory policies
> Used - size of all allocated pages
>
> Thoughts?
>
Reply | Threaded
Open this post in threaded view
|

Re: Cluster metrics - review for PageMemory

dsetrakyan
In reply to this post by Alexey Goncharuk
Is there a way to provide such metrics for a specific memory policy?

On Tue, Apr 25, 2017 at 4:53 PM, Alexey Goncharuk <
[hidden email]> wrote:

> Igniters,
>
> Since we moved to the PageMemory architecture, several ClusterMetrics
> methods became questionable, so I would like to discuss this before the
> release. Currently, ClusterMetrics contains the following methods:
> getNonHeapMemoryCommitted(),
> getNonHeapMemoryUsed(),
> getNonHeapMemoryInitialized(),
> getNonHeapMemoryTotal(),
> getNonHeapMemoryMaximum()
>
> I suggest we remove Total and Committed metrics, and the rest of the
> methods will have the following semantics:
> Initialized() - start size of all memory policies
> Max - max size of all memory policies
> Used - size of all allocated pages
>
> Thoughts?
>