[Check Code Style] is broken in master

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[Check Code Style] is broken in master

Ivan Bessonov
Hi Igniters,

today I wanted to run tests on one of my PRs and found out that master is
broken [1].
Issue that broked it was merged 4 hours ago and "TC Bot" VISA was presumably
from the obsolete commit [2].

Sergey Kalashnikov, Aleksey Plekhanov, please be careful next time.

Can someone please fix it? I'm not a committer, otherwise I would do it
myself.

Fix is simple
- org.apache.ignite.internal.processors.query.SqlNotNullKeyValueFieldTest
class requires imports reorganization.

I guess this applies to the 2.9 release branch as well.

Thank you!

[1]
https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_CheckCodeStyle&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=%3Cdefault%3E
[2] https://issues.apache.org/jira/browse/IGNITE-13142

--
Sincerely yours,
Ivan Bessonov
Reply | Threaded
Open this post in threaded view
|

Re: [Check Code Style] is broken in master

Alexey Plekhanov
Ivan,

Fixed. Thanks for noticing.

пт, 10 июл. 2020 г. в 15:18, Ivan Bessonov <[hidden email]>:

> Hi Igniters,
>
> today I wanted to run tests on one of my PRs and found out that master is
> broken [1].
> Issue that broked it was merged 4 hours ago and "TC Bot" VISA was
> presumably
> from the obsolete commit [2].
>
> Sergey Kalashnikov, Aleksey Plekhanov, please be careful next time.
>
> Can someone please fix it? I'm not a committer, otherwise I would do it
> myself.
>
> Fix is simple
> - org.apache.ignite.internal.processors.query.SqlNotNullKeyValueFieldTest
> class requires imports reorganization.
>
> I guess this applies to the 2.9 release branch as well.
>
> Thank you!
>
> [1]
>
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_CheckCodeStyle&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=%3Cdefault%3E
> [2] https://issues.apache.org/jira/browse/IGNITE-13142
>
> --
> Sincerely yours,
> Ivan Bessonov
>